Re: [PATCH v2] drm/amdgpu/display: Fix reload driver error

On 5/28/19 11:12 PM, Emily Deng wrote: > Issue: > Will have follow error when reload driver: > [ 3986.567739] sysfs: cannot create duplicate filename > '/devices/pci:00/:00:07.0/drm_dp_aux_dev' > [ 3986.567743] CPU: 6 PID: 1767 Comm: modprobe Tainted: G OE > 5.0.0-rc1-custom

Re: [PATCH] drm/amdgpu: add pmu counters

On Wed, May 29, 2019 at 11:02 AM Kim, Jonathan wrote: > > add pmu counters to monitor amdgpu device performance. > each pmu registered recorded per pmu type per asic type. > > Change-Id: I8449f4ea824c411ee24a5b783ac066189b9de08e > Signed-off-by: Jonathan Kim > --- > drivers/gpu/drm/amd/amdgpu/Ma

[PATCH] drm/amdgpu: use new HMM APIs and helpers

HMM provides new APIs and helps in kernel 5.2-rc1 to simplify driver path. The old hmm APIs are deprecated and will be removed in future. Below are changes in driver: 1. Change hmm_vma_fault to hmm_range_register and hmm_range_fault which supports range with multiple vmas, remove the multiple vma

Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

Alex, Are any of these non-booting systems laptops? If all the laptops don't have this issue, is there a way we can detect we are on mobile and load the DMCU? Seeing as ABM and PSR are both practically only used on mobile, maybe we can check for that. This way we only enable it on systems th

[PATCH] drm/amd/doc: add rough outline of tracepoint documentation

Signed-off-by: Tom St Denis --- Documentation/gpu/amdgpu.rst | 10 + drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 221 ++ 2 files changed, 231 insertions(+) diff --git a/Documentation/gpu/amdgpu.rst b/Documentation/gpu/amdgpu.rst index 86138798128f..3564765110e5

Re: [PATCH] drm/sched: Fix make htmldocs warnings.

Am 29.05.19 um 21:36 schrieb Daniel Vetter: On Wed, May 29, 2019 at 04:43:45PM +, Grodzovsky, Andrey wrote: I don't, sorry. Should we fix that? Seems like you do plenty of scheduler stuff, so would make sense I guess ... Reviewed-by: Christian König for the patch. And +1 for giving Andr

Re: [PATCH v15 05/17] arms64: untag user pointers passed to memory syscalls

On Wed, May 29, 2019 at 01:16:37PM -0600, Khalid Aziz wrote: > On 5/29/19 8:20 AM, Catalin Marinas wrote: > > On Tue, May 28, 2019 at 05:33:04PM -0600, Khalid Aziz wrote: > >> Steps 1 and 2 are accomplished by userspace by calling mprotect() with > >> PROT_ADI. Tags are set by storing tags in a loo

Re: [PATCH] drm/amd/doc: add rough outline of tracepoint documentation

Comments inline (marked with [slava a]). General comment - word capitalisation in the lists is inconsistent From: amd-gfx on behalf of StDenis, Tom Sent: Thursday, May 30, 2019 10:56 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] drm/a

Re: [PATCH] drm/amd/display: Don't load DMCU for Raven 1 (v2)

On Thu, May 30, 2019 at 10:48 AM Samantha McVey wrote: > > Alex, > > > > Are any of these non-booting systems laptops? If all the laptops don't have > this issue, is there a way we can detect we are on mobile and load the DMCU? > Seeing as ABM and PSR are both practically only used on mobile, ma

Re: [PATCH] drm/amd/doc: add rough outline of tracepoint documentation

Fixed with "is". Thanks. I'll wait for more feedback before submitting a v2. Tom On Thu, May 30, 2019 at 11:45 AM Abramov, Slava wrote: > Comments inline (marked with [slava a]). > > > General comment - word capitalisation in the lists is inconsistent > > > -- > *F

Re: RX 580 and 5K displays, bandwidth validation failed whith multiple monitors

On 2019-05-27 10:58 a.m., Gaël HERMET wrote: > Hi, > > I have been facing an issue with my 5K display (iiyama ProLite > XB2779QQS-S1). > > It works fine as long as it is the only active monitor, as soon as I > activate another monitor the main one (5k) can't display more than 4k. > > Debug using

Re: [PATCH v15 05/17] arms64: untag user pointers passed to memory syscalls

On 5/30/19 9:11 AM, Catalin Marinas wrote: > On Wed, May 29, 2019 at 01:16:37PM -0600, Khalid Aziz wrote: >> mmap() can return the same tagged address but I am uneasy about kernel >> pre-coloring the pages. Database can mmap 100's of GB of memory. That is >> lot of work being offloaded to the kerne

[PATCH][next] drm/amd/display: remove redundant assignment to status

From: Colin Ian King The variable status is initialized with a value that is never read and status is reassigned several statements later. This initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc/

Re: [PATCH v15 05/17] arms64: untag user pointers passed to memory syscalls

On Thu, May 30, 2019 at 10:05:55AM -0600, Khalid Aziz wrote: > On 5/30/19 9:11 AM, Catalin Marinas wrote: > > So if a database program is doing an anonymous mmap(PROT_TBI) of 100GB, > > IIUC for sparc the faulted-in pages will have random colours (on 64-byte > > granularity). Ignoring the informati

Re: [PATCH v15 00/17] arm64: untag user pointers passed to the kernel

On Tue, May 28, 2019 at 04:14:45PM +0200, Andrey Konovalov wrote: > Thanks for a lot of valuable input! I've read through all the replies > and got somewhat lost. What are the changes I need to do to this > series? > > 1. Should I move untagging for memory syscalls back to the generic > code so ot

Re: [PATCH 2/7] drm/dp_mst: Register AUX devices for MST ports

Hey, sorry for my late response! On 2019-05-16 5:40 p.m., Lyude Paul wrote: >>if (old_pdt != port->pdt && !port->input) { >> @@ -1220,6 +1268,8 @@ static void drm_dp_add_port(struct drm_dp_mst_branch >> *mstb, >>drm_connector_set_tile_property(port->connector); >>

[PATCH] drm/amdgpu: Remove call to memset after dma_alloc_coherent

This patch fixes below warning reported by coccicheck ./drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c:63:13-31: WARNING: dma_alloc_coherent use in ih -> ring already zeroes out memory, so memset is not needed Signed-off-by: Hariprasad Kelam --- drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 1 - 1 file cha

[bug report] drm/amd/display: Move link functions from dc to dc_link

Hello Chris Park, This is a semi-automatic email about new static checker warnings. The patch f5692f69f673: "drm/amd/display: Move link functions from dc to dc_link" from May 10, 2019, leads to the following Smatch complaint: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:2929 dc

[PATCH] drm/amd/display: Don't set mode_changed=false if the stream was removed

[Why] When switching from vt to desktop with EDID emulation we can receive an atomic commit such that we have a crtc where mode_changed = true. During the dm_update_crtc_state disable pass we remove the stream from the context and free it on the dm_new_crtc_state. During the enable pass we compar

Re: [PATCH] drm/amdgpu: use new HMM APIs and helpers

This is a nice simplification. See a few comments inline. On 2019-05-30 10:41 a.m., Yang, Philip wrote: > HMM provides new APIs and helps in kernel 5.2-rc1 to simplify driver > path. The old hmm APIs are deprecated and will be removed in future. > > Below are changes in driver: > > 1. Change hmm_v

Re: [PATCH 6/8] drm/amdkfd: New IOCTL to allocate queue GWS

On Sat, 25 May 2019 at 05:48, Kuehling, Felix wrote: > > On 2019-05-23 6:41 p.m., Zeng, Oak wrote: > > Add a new kfd ioctl to allocate queue GWS. Queue > > GWS is released on queue destroy. > > > > Change-Id: I60153c26a577992ad873e4292e759e5c3d5bbd15 > > Signed-off-by: Oak Zeng > > Reviewed-by: F

[PATCH] drm/amdgpu/sriov: Correct some register program method

For the VF, some registers only could be programmed with RLC. Signed-off-by: Emily Deng --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c| 10 +- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/