Re: [PATCH 1/2] drm/ttm: fix busy memory to fail other user v6

2019-05-08 Thread Thomas Hellstrom
On 5/7/19 1:42 PM, Koenig, Christian wrote: Am 07.05.19 um 13:37 schrieb Thomas Hellstrom: [CAUTION: External Email] On 5/7/19 1:24 PM, Christian König wrote: Am 07.05.19 um 13:22 schrieb zhoucm1: On 2019年05月07日 19:13, Koenig, Christian wrote: Am 07.05.19 um 13:08 schrieb zhoucm1: On 2019年

Re: [PATCH 1/2] drm/ttm: fix busy memory to fail other user v6

2019-05-08 Thread Koenig, Christian
Am 08.05.19 um 10:34 schrieb Thomas Hellstrom: > [SNIP] No, what I mean is to add the acquire_ctx as separate parameter to ttm_mem_evict_first(). E.g. we only need it in this function and it is actually not related to the ttm operation context filled in by the driver. >>> >

[PATCH] drm/amd/display: Make some functions static

2019-05-08 Thread Wang Hai
Fix the following sparse warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:483:21: warning: symbol 'dce120_clock_source_create' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:506:6: warning: symbol 'dce120_clock

[PATCH 2/6] drm/amdgpu/UVD: set no_user_fence flag to true

2019-05-08 Thread Liu, Leo
There is no user fence support for UVD Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 1 + drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 1 + drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 3 +++ drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 2 ++ 4 files changed, 7 insertions(+) diff --git a/

[PATCH 4/6] drm/amdgpu/VCN: set no_user_fence flag to true

2019-05-08 Thread Liu, Leo
There is no user fence support for VCN Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c index 3dbc51f9d3b9..ac2e5a1eb576 100644 --- a/drivers/gpu/

[PATCH 3/6] drm/amdgpu/VCE: set no_user_fence flag to true

2019-05-08 Thread Liu, Leo
There is no user fence support for VCE Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/vce_v2_0.c | 1 + drivers/gpu/drm/amd/amdgpu/vce_v3_0.c | 2 ++ drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 1 + 3 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/vce_v2_0.c b/driver

[PATCH 6/6] drm/amdgpu: remove MM engine related WARN_ON for user fence

2019-05-08 Thread Liu, Leo
Since the check aleady done with command submission check --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 2 -- drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 2 -- drivers/gpu/drm/amd/amdgpu/uvd_v5_0.c | 2 -- drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 4 drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c |

[PATCH 5/6] drm/amdgpu: check no_user_fence flag for engines

2019-05-08 Thread Liu, Leo
To replace checking ring type and make them generic Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index d0e221c8d940..d72

[PATCH 1/6] drm/amdgpu: add no_user_fence flag to ring funcs

2019-05-08 Thread Liu, Leo
So we can generalize the no user fence supported engine Signed-off-by: Leo Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h index d7fae2676269..cdddce938bf5 10

RE: [PATCH] drm/amdgpu: Report firmware versions with sysfs

2019-05-08 Thread Russell, Kent
Hi Christian, Are you worried about him putting them in a fw_version subfolder like the ras* files are, or are they fine in the regular sysfs pool? Kent -Original Message- From: amd-gfx On Behalf Of Russell, Kent Sent: Tuesday, May 7, 2019 1:53 PM To: Koenig, Christian ; Messinger, Or

Re: [PATCH AUTOSEL 4.19 29/53] drm/amdkfd: Add picasso pci id

2019-05-08 Thread Sasha Levin
On Sat, Apr 27, 2019 at 01:49:27PM +, Deucher, Alexander wrote: NACK. 4.19 did not contain support for picasso. Please drop this patch for 4.19. Dropped, thank you! -- Thanks, Sasha ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https:/

Re: [PATCH 6/6] drm/amdgpu: remove MM engine related WARN_ON for user fence

2019-05-08 Thread Alex Deucher
On Wed, May 8, 2019 at 11:51 AM Liu, Leo wrote: > > Since the check aleady done with command submission check Missing signed-off-by. patches 1-5 are: Reviewed-by: Alex Deucher As for this patch, I don't think these are directly related to user fences and we may want to keep them. Alex > ---

Re: [PATCH 6/6] drm/amdgpu: remove MM engine related WARN_ON for user fence

2019-05-08 Thread Liu, Leo
On 5/8/19 1:45 PM, Alex Deucher wrote: > [CAUTION: External Email] > > On Wed, May 8, 2019 at 11:51 AM Liu, Leo wrote: >> Since the check aleady done with command submission check > Missing signed-off-by. > > patches 1-5 are: > Reviewed-by: Alex Deucher > > As for this patch, I don't think these

Re: [PATCH v2] drm/amdgpu: add badpages sysfs interafce

2019-05-08 Thread Alex Deucher
On Tue, May 7, 2019 at 11:15 PM Pan, Xinhui wrote: > > add badpages node. > it will output badpages list in format > page : size : flags gpu pfn : gpu page size : flags > > page is PFN. > flags can be R, P, F. > > example > 0x : 0x1000 : R > 0x0001 : 0x1000 : R > 0x0002

[PATCH] drm/amdgpu: Fix S3 test issue

2019-05-08 Thread Zhu, James
During S3 test, when system wake up and resume, ras interface is already allocated. Move workaround before ras jumps to resume step in gfx_v9_0_ecc_late_init, and make sure workaround applied during resume. Also remove unused mmGB_EDC_MODE clearing. Signed-off-by: James Zhu --- drivers/gpu/drm/a

Kernel crash at reloading amdgpu

2019-05-08 Thread Lin, Amber
Hi, When I do "rmmod amdgpu; modprobe amdgpu", kernel crashed. This is vega20. What happens is in amdgpu_device_init():     /* check if we need to reset the asic *  E.g., driver was not cleanly unloaded previously, etc. */     if (!amdgpu_sriov_vf(adev) && amdgpu_

Re: Kernel crash at reloading amdgpu

2019-05-08 Thread Deucher, Alexander
The attached patch should fix it. Alex From: amd-gfx on behalf of Lin, Amber Sent: Wednesday, May 8, 2019 4:56 PM To: amd-gfx@lists.freedesktop.org Subject: Kernel crash at reloading amdgpu [CAUTION: External Email] Hi, When I do "rmmod amdgpu; modprobe amdg

[PATCH] drm/sched: fix the duplicated TMO message for one IB

2019-05-08 Thread Monk Liu
we don't need duplicated IB's timeout error message reported endlessly, just one report per timedout IB is enough Signed-off-by: Monk Liu --- drivers/gpu/drm/scheduler/sched_main.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/s

Re: [PATCH 2/4] drm/amd/powerplay: valid Vega10 DPMTABLE_OD_UPDATE_VDDC settings V2

2019-05-08 Thread Alex Deucher
On Wed, May 8, 2019 at 2:41 AM Evan Quan wrote: > > With user specified voltage(DPMTABLE_OD_UPDATE_VDDC), the AVFS > will be disabled. However, the buggy code makes this actually not > working as expected. > > - V2: clear all OD flags excpet DPMTABLE_OD_UPDATE_VDDC > > Change-Id: Ifa83a6255bb3f6fa

Re: [PATCH 2/2] drm/amd/powerplay: update Vega10 ACG Avfs Gb parameters

2019-05-08 Thread Alex Deucher
On Wed, May 8, 2019 at 2:43 AM Evan Quan wrote: > > Update Vega10 ACG Avfs GB parameters. > > Change-Id: Ic3d5b170b93a7a92949262323ca710dbf9ac49b4 > Signed-off-by: Evan Quan Series is: Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 4 ++-- > 1 file changed

Re: [PATCH 7/9] drm/amdgpu: Skip setting some regs under Vega10 VF

2019-05-08 Thread Alex Deucher
On Tue, May 7, 2019 at 10:46 PM Trigger Huang wrote: > > For Vega10 SR-IOV VF, skip setting some regs due to: > 1, host will program thme Typo: thme -> them With that fixed: Reviewed-by: Alex Deucher > 2, avoid VF register programming violations > > Change-Id: Id43e7fca7775035be47696c67a74ad41

Re: [PATCH 5/9] drm/amdgpu: call psp to progrm ih cntl in SR-IOV

2019-05-08 Thread Alex Deucher
On Tue, May 7, 2019 at 10:46 PM Trigger Huang wrote: > > call psp to progrm ih cntl in SR-IOV if supported typo in subject and description: progrm -> program With that fixed: Reviewed-by: Alex Deucher > > Change-Id: I466dd66926221e764cbcddca48b1f0fe5cd798b4 > Signed-off-by: Trigger Huang > ---

Re: [PATCH 0/9] Enable new L1 security for Vega10 SR-IOV

2019-05-08 Thread Alex Deucher
Minor comments on 5 and 7. Rest are: Reviewed-by: Alex Deucher Alex On Tue, May 7, 2019 at 10:45 PM Trigger Huang wrote: > > To support new Vega10 SR-IOV L1 security, KMD need some modifications > 1: Due to the new features supported in FW(PSP, RLC, etc), >for register acce

Re: [PATCH] drm/amdgpu: Report firmware versions with sysfs

2019-05-08 Thread Koenig, Christian
Hi Kent, not strong opinion on that and I agree that from a housekeeping point of view we should probably create an own directory for the files. Christian. Am 08.05.19 um 19:11 schrieb Russell, Kent: > Hi Christian, > > Are you worried about him putting them in a fw_version subfolder like the