Re: [PATCH xf86-video-amdgpu] Fix hang when entering into dpms-off mode

2019-03-01 Thread Michel Dänzer
On 2019-03-01 7:37 a.m., Liu, Aaron wrote: > @Michel Dänzer, > > I have reviewed your patch and verified it passed. Thanks Aaron, so I assume I can add Reviewed-by: Aaron Liu Tested-by: Aaron Liu ? > I couldn't merge this merge request to your master manually. Don't worry, I'll merge it vi

RE: [patch] ras fix patch set

2019-03-01 Thread Zhang, Hawking
Okay, Thanks for the clarifying. Yes, we will need the interrupt handler. So let’s just keep the set function as is. Regards, Hawking From: Pan, Xinhui Sent: 2019年3月1日 16:18 To: Zhang, Hawking ; brahma_sw_dev ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [patch] ras fix p

Re: [PATCH xf86-video-amdgpu] Allow changing DCC parameters between flips

2019-03-01 Thread Michel Dänzer
Thanks Marek for the patch, but xf86-video-amdgpu patches are being reviewed as GitLab merge requests since the last release[0]. I'll create a merge request with this patch and some follow-up changes. [0] Isn't README.md clear enough on this? -- Earthling Michel Dänzer |

RE: [PATCH xf86-video-amdgpu] Fix hang when entering into dpms-off mode

2019-03-01 Thread Liu, Aaron
> -Original Message- > From: Michel Dänzer > Sent: Friday, March 01, 2019 4:43 PM > To: Liu, Aaron > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH xf86-video-amdgpu] Fix hang when entering into dpms- > off mode > > On 2019-03-01 7:37 a.m., Liu, Aaron wrote: > > @Michel Dänzer,

RE: [PATCH] drm/amdgpu: add thick tile mode settings for Oland of gfx6

2019-03-01 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: amd-gfx On Behalf Of Tao Zhou Sent: 2019年3月1日 15:47 To: amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Deng, Hui Subject: [PATCH] drm/amdgpu: add thick tile mode settings for Oland of gfx6 Adding thick tile mode for O

[PATCH] drm/amdgpu: fix compile warnings

2019-03-01 Thread Bhawanpreet Lakha
Fixes the warnings below warning: ‘ta_hdr’ may be used uninitialized in this function [-Wmaybe-uninitialized] warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement] warning: unused variable ‘ras_cmd’ [-Wunused-variable] warning: comparison of distinct pointer types

Re: [PATCH] drm/amdgpu: fix compile warnings

2019-03-01 Thread Wentland, Harry
On 2019-03-01 11:43 a.m., Bhawanpreet Lakha wrote: > Fixes the warnings below > > warning: ‘ta_hdr’ may be used uninitialized in this function > [-Wmaybe-uninitialized] > warning: ISO C90 forbids mixed declarations and code > [-Wdeclaration-after-statement] > warning: unused variable ‘ras_cmd’ [

Re: [PATCH] drm/amdgpu: fix compile warnings

2019-03-01 Thread Wentland, Harry
On 2019-03-01 11:46 a.m., Wentland, Harry wrote: > On 2019-03-01 11:43 a.m., Bhawanpreet Lakha wrote: >> Fixes the warnings below >> >> warning: ‘ta_hdr’ may be used uninitialized in this function >> [-Wmaybe-uninitialized] >> warning: ISO C90 forbids mixed declarations and code >> [-Wdeclarati

[PATCH xf86-video-ati 2/2] dri2: Call drm_queue_handle_deferred in dri2_deferred_event

2019-03-01 Thread Michel Dänzer
From: Michel Dänzer drm_queue_handler just puts the event on the signalled list; without calling drm_queue_handle_deferred, actual processing of the event may be delayed indefinitely, e.g. until another event arrives from the kernel. This could result in DRI2 clients hanging during DPMS off. Fi

[PATCH xf86-video-ati 1/2] present: Check that flip and screen pixmap pitches match

2019-03-01 Thread Michel Dänzer
From: Michel Dänzer If they don't, flipping will result in corrupted display. Test case: * Run Xorg at 1920x1080 with no window manager * glxgears -geometry 2048x1080 The Present extension code in xserver 1.21 will check for this. (Ported from amdgpu commit a636f42b496b0604ca00a144690ece61d1a

[PATCH] drm/amdgpu: handle userptr corner cases with HMM path

2019-03-01 Thread Yang, Philip
Those corner cases are found by kfdtest.KFDIPCTest. userptr may cross two vmas if the forked child process (not call exec after fork) malloc buffer, then free it, and then malloc larger size buf, kerenl will create new vma adjacent to old vma which was cloned from parent process, some pages of use

Re: [PATCH xf86-video-ati 2/2] dri2: Call drm_queue_handle_deferred in dri2_deferred_event

2019-03-01 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Michel Dänzer Sent: Friday, March 1, 2019 12:35 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH xf86-video-ati 2/2] dri2: Call drm_queue_handle_deferred in dri2_deferred_event From: Michel Dä

[PATCH] drm/amdgpu/gfx_v8_0: Mark expected switch fall-through

2019-03-01 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function ‘gfx_v8_0_tiling_mode_table_init’: ./include/linux/device.h:1487:2: warning: this statement may

[PATCH] drm/amdgpu/powerplay: Fix missing break in switch statement

2019-03-01 Thread Gustavo A. R. Silva
Add missing break statement in order to prevent the code from falling through to case SMU_Discrete_DpmTable. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: 34a564eaf528 ("drm/amd/powerplay: implement fw image related smum interface for Polaris.") Cc: st

Re: [PATCH] drm/amd/powerplay: fix semicolon code style issue

2019-03-01 Thread Alex Deucher
On Thu, Feb 28, 2019 at 8:12 PM Yang Wei wrote: > > From: Yang Wei > > Delete superfluous semicolons. > > Signed-off-by: Yang Wei Applied. thanks! Alex > --- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 8 > drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-

Re: [PATCH] drm/amdgpu/gfx_v8_0: Mark expected switch fall-through

2019-03-01 Thread Alex Deucher
On Fri, Mar 1, 2019 at 3:58 PM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function > ‘gfx_v8_0_tiling_mode_t

Re: [PATCH] drm/amdgpu/powerplay: Fix missing break in switch statement

2019-03-01 Thread Alex Deucher
On Fri, Mar 1, 2019 at 4:51 PM Gustavo A. R. Silva wrote: > > Add missing break statement in order to prevent the code from falling > through to case SMU_Discrete_DpmTable. > > This bug was found thanks to the ongoing efforts to enable > -Wimplicit-fallthrough. > > Fixes: 34a564eaf528 ("drm/amd/po

RE: [PATCH] drm/amdgpu: handle userptr corner cases with HMM path

2019-03-01 Thread Kuehling, Felix
Since you're addressing two distinct bugs, please split this into two patches. For the multiple VMAs, should we generalize that to handle any number of VMAs? It's not a typical case, but you could easily construct situations with mprotect where different parts of the same buffer have different V