[PATCH] drm/amd/powerplay: fix raven issue for sw smu

2019-02-27 Thread Huang Rui
Raven series doesn't support sw smu so far, so we have to add checking to confirm it return false while the asic is raven. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/powerplay/amdgpu_smu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/amd

RE: [PATCH] drm/amd/powerplay: fix raven issue for sw smu

2019-02-27 Thread Gao, Likun
Patch is Reviewed-by: Likun Gao Regards, Likun -Original Message- From: amd-gfx On Behalf Of Huang Rui Sent: Wednesday, February 27, 2019 6:51 PM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray Subject: [PATCH] drm/amd/powerplay: fix raven issue for sw smu Raven series doesn't suppor

RE: [PATCH 1/6] drm/amdgpu: rework shadow handling during PD clear v2

2019-02-27 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian K?nig > Sent: Tuesday, February 26, 2019 8:47 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 1/6] drm/amdgpu: rework shadow handling during PD clear > v2 > > This way we o

Re: [PATCH 07/18] drm/amd/display: Create overlay planes

2019-02-27 Thread Nicholas Kazlauskas
On 2019-02-26 11:03 p.m., Vishwakarma, Pratik wrote: > > On 2/26/2019 4:16 AM, Bhawanpreet Lakha wrote: >> From: Nicholas Kazlauskas >> >> [Why] >> Raven has support for combining pipes for DRM_PLANE_TYPE_OVERLAY use >> but no overlays are exposed to userspace. >> >> [How] >> Expose overlay plane

Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0

2019-02-27 Thread Zhao, Yong
Pushed. Thanks. Yong From: Alex Deucher Sent: Tuesday, February 26, 2019 10:53 PM To: Zhao, Yong Cc: Koenig, Christian; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Set VM_L2_CNTL.PDE_FAULT_CLASSIFICATION to 0 yes, go ahead. Alex On Tue, Feb 2

KASAN caught amdgpu / HMM use-after-free

2019-02-27 Thread Michel Dänzer
See the attached dmesg excerpt. I've hit this a few times running piglit with amd-staging-drm-next, first on February 22nd. The memory was freed after calling hmm_mirror_unregister in amdgpu_mn_destroy. -- Earthling Michel Dänzer | https://www.amd.com Libre software

Re: KASAN caught amdgpu / HMM use-after-free

2019-02-27 Thread Yang, Philip
Hi Michel, Yes, I found the same issue and the bug has been fixed by Jerome: 876b462120aa mm/hmm: use reference counting for HMM struct The fix is on hmm-for-5.1 branch, I cherry-pick it into my local branch to workaround the issue. Regards, Philip On 2019-02-27 12:02 p.m., Michel Dänzer wrot

Re: KASAN caught amdgpu / HMM use-after-free

2019-02-27 Thread Jerome Glisse
On Wed, Feb 27, 2019 at 06:02:49PM +0100, Michel Dänzer wrote: > > See the attached dmesg excerpt. I've hit this a few times running piglit > with amd-staging-drm-next, first on February 22nd. > > The memory was freed after calling hmm_mirror_unregister in > amdgpu_mn_destroy. So that branch is

Re: KASAN caught amdgpu / HMM use-after-free

2019-02-27 Thread Michel Dänzer
On 2019-02-27 6:14 p.m., Yang, Philip wrote: > Hi Michel, > > Yes, I found the same issue and the bug has been fixed by Jerome: > > 876b462120aa mm/hmm: use reference counting for HMM struct > > The fix is on hmm-for-5.1 branch, I cherry-pick it into my local branch > to workaround the issue.

Re: KASAN caught amdgpu / HMM use-after-free

2019-02-27 Thread Yang, Philip
amd-staging-drm-next will rebase to kernel 5.1 to pickup this fix automatically. As a short-term workaround, please cherry-pick this fix into your local repository. Regards, Philip On 2019-02-27 12:33 p.m., Michel Dänzer wrote: > On 2019-02-27 6:14 p.m., Yang, Philip wrote: >> Hi Michel, >> >>

Re: KASAN caught amdgpu / HMM use-after-free

2019-02-27 Thread Deucher, Alexander
Go ahead an apply it to amd-staging-drm-next. It'll naturally fall out when I rebase it. Alex From: amd-gfx on behalf of Yang, Philip Sent: Wednesday, February 27, 2019 1:05 PM To: Michel Dänzer; Jérôme Glisse Cc: linux...@kvack.org; amd-gfx@lists.freedesktop.

Re: KASAN caught amdgpu / HMM use-after-free

2019-02-27 Thread Yang, Philip
Hi Alex, Pushed, thanks. mm/hmm: use reference counting for HMM struct Philip On 2019-02-27 1:32 p.m., Deucher, Alexander wrote: > Go ahead an apply it to amd-staging-drm-next.  It'll naturally fall out > when I rebase it. > > Alex > ---

[pull] amdgpu drm-fixes-5.0

2019-02-27 Thread Alex Deucher
Hi Dave, Daniel, A fix for freesync to prevent stuttering in certain cases. Freesync was added in 5.0 so it would be nice to get this in. If not, I can just send it to stable once 5.0 is released. The following changes since commit a213c2c7e235cfc0e0a161a558f7fdf2fb3a624a: drm/amdgpu: disabl

RE: [PATCH 2/6] drm/amdgpu: let amdgpu_vm_clear_bo figure out ats status v2

2019-02-27 Thread Zeng, Oak
Making some codes into functions would help people to understand. At least for me the codes is not very easy to understand. See inline comments. But those suggested new functions are only used in this clear_bo function, so it is your call to do it or not. Anyway this patch is Reviewed-by: Oak Ze

Re: [PATCH] drm: add func to better detect wether swiotlb is needed

2019-02-27 Thread Konrad Rzeszutek Wilk
.snip.. > > -u64 drm_get_max_iomem(void) > > +bool drm_need_swiotlb(int dma_bits) > > { > > struct resource *tmp; > > resource_size_t max_iomem = 0; > > > > + /* > > +* Xen paravirtual hosts require swiotlb regardless of requested dma > > +* transfer size. > > +* > > +*

Re: [PATCH] drm: prefix header search paths with $(srctree)/

2019-02-27 Thread Sam Ravnborg
Hi Masahiro. On Thu, Jan 31, 2019 at 12:56:39PM +0900, Masahiro Yamada wrote: > Currently, the Kbuild core manipulates header search paths in a crazy > way [1]. > > To fix this mess, I want all Makefiles to add explicit $(srctree)/ to > the search paths in the srctree. Some Makefiles are already

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2019-02-27 Thread Alex Deucher
Applied. Sorry for the delay. Alex On Fri, Feb 22, 2019 at 10:36 AM Nathan Chancellor wrote: > > On Mon, Dec 10, 2018 at 04:42:01PM -0700, Nathan Chancellor wrote: > > Clang warns when an expression that equals zero is used as a null > > pointer constant (in lieu of NULL): > > > > drivers/gpu/d

Re: [PATCH -next] drm/amdgpu: remove set but not used variables 'vm, bo'

2019-02-27 Thread Alex Deucher
Applied. thanks! On Wed, Feb 20, 2019 at 3:05 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c: In function > 'update_gpuvm_pte': > drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c:840:20: warning: > variable 'bo' set

Re: [PATCH -next] drm/amdgpu: remove set but not used variable 'vbi_time_out'

2019-02-27 Thread Alex Deucher
Applied. thanks! On Tue, Feb 26, 2019 at 12:36 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/amd/amdgpu/si_dpm.c: In function 'si_program_response_times': > drivers/gpu/drm/amd/amdgpu/si_dpm.c:4101:29: warning: > variable 'backbias_response_time' se

[PATCH xf86-video-amdgpu] Fix hang when entering into dpms-off mode

2019-02-27 Thread Aaron Liu
The hang happened in CTS 4.6 glcts. It is dued to inconsistent process in amdgpu_dri2_schedule_swap when system entering into dpms-off mode. Normally, drmmode_wait_vblank will be excuted. But when entering into dpms-off mode, drmmode_wait_vblank can't be excuted and fallback to amdgpu_dri2_schedul

[PATCH v3] drm/amd/powerplay: add limit of pp_feature for smu (v3)

2019-02-27 Thread likun Gao
From: Likun Gao Move pp_feature from the struct of amd_powerplay to amdgpu_device. Add pp_feature limit for overdrive interface. v2: put pp_feature into struct amdgpu_pm. v3: merge feature_mask with pp_feature. Signed-off-by: Likun Gao Reviewed-by: Kevin Wang Suggested-by: Alex Deucher Sugge

Re: [PATCH v3] drm/amd/powerplay: add limit of pp_feature for smu (v3)

2019-02-27 Thread Alex Deucher
Reviewed-by: Alex Deucher On Wed, Feb 27, 2019 at 10:13 PM likun Gao wrote: > > From: Likun Gao > > Move pp_feature from the struct of amd_powerplay to amdgpu_device. > Add pp_feature limit for overdrive interface. > > v2: put pp_feature into struct amdgpu_pm. > v3: merge feature_mask with pp_f

[PATCH libdrm 2/2] tests/amdgpu: add memcpy dispatch test

2019-02-27 Thread Cui, Flora
add memcpy dispatch test for gfx9 Change-Id: If433434c5378f3b318209d4e28c19d7ce9cff1a2 Signed-off-by: Flora Cui Tested-by: Rui Teng --- tests/amdgpu/basic_tests.c | 129 + 1 file changed, 129 insertions(+) diff --git a/tests/amdgpu/basic_tests.c b/te

[PATCH libdrm 1/2] tests/amdgpu: add memset dispatch test

2019-02-27 Thread Cui, Flora
add memset dispatch test for gfx9 Change-Id: If607fbd9c6e49ca830a662adc24fe6b1e2a25bfb Signed-off-by: Flora Cui Tested-by: Rui Teng --- tests/amdgpu/basic_tests.c | 215 - 1 file changed, 213 insertions(+), 2 deletions(-) diff --git a/tests/amdgpu/ba

RE: [PATCH v3] drm/amd/powerplay: add limit of pp_feature for smu (v3)

2019-02-27 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of likun Gao > Sent: Thursday, February 28, 2019 11:14 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Gao, Likun > ; Huang, Ray > Subject: [PATCH v3] drm/amd/powerplay: add li