Re: [PATCH 1/1] [RFC] drm/ttm: Don't init dma32_zone on 64-bit systems

2019-02-22 Thread Thomas Hellstrom
On Fri, 2019-02-22 at 07:10 +, Koenig, Christian wrote: > Am 21.02.19 um 22:02 schrieb Thomas Hellstrom: > > Hi, > > > > On Thu, 2019-02-21 at 20:24 +, Kuehling, Felix wrote: > > > On 2019-02-21 12:34 p.m., Thomas Hellstrom wrote: > > > > On Thu, 2019-02-21 at 16:57 +, Kuehling, Felix

Re: [PATCH] drm/amd/display: Pass app_tf by value rather than by reference

2019-02-22 Thread Nathan Chancellor
On Mon, Dec 10, 2018 at 04:42:01PM -0700, Nathan Chancellor wrote: > Clang warns when an expression that equals zero is used as a null > pointer constant (in lieu of NULL): > > drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4435:3: > warning: expression which evaluates to zero treated

[PATCH] drm/amd/display: don't call dm_pp_ function from an fpu block

2019-02-22 Thread Harry Wentland
Powerplay functions called from dm_pp_* functions tend to do a mutex_lock which isn't safe to do inside a kernel_fpu_begin/end block as those will disable/enable preemption. Rearrange the dm_pp_get_clock_levels_by_type_with_voltage calls to make sure they happen outside of kernel_fpu_begin/end. C

RE: [PATCH 2/7] drm/amdgpu: rework shadow handling during PD clear

2019-02-22 Thread Zeng, Oak
See one comment inline [Oak] Thanks, Oak -Original Message- From: amd-gfx On Behalf Of Christian König Sent: Tuesday, February 19, 2019 8:41 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/7] drm/amdgpu: rework shadow handling during PD clear This way we only deal with the real

Re: [PATCH 2/7] drm/amdgpu: rework shadow handling during PD clear

2019-02-22 Thread Grodzovsky, Andrey
On 2/22/19 10:51 AM, Zeng, Oak wrote: > See one comment inline [Oak] > > Thanks, > Oak > > -Original Message- > From: amd-gfx On Behalf Of Christian > König > Sent: Tuesday, February 19, 2019 8:41 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH 2/7] drm/amdgpu: rework shadow han

Re: [PATCH] drm/amd/display: don't call dm_pp_ function from an fpu block

2019-02-22 Thread Deucher, Alexander
Acked-by: Alex Deucher From: amd-gfx on behalf of Harry Wentland Sent: Friday, February 22, 2019 10:39 AM To: amd-gfx@lists.freedesktop.org Cc: robdcl...@gmail.com; Wentland, Harry; sta...@vger.kernel.org Subject: [PATCH] drm/amd/display: don't call dm_pp_ funct

Re: [PATCH] drm/amd/display: don't call dm_pp_ function from an fpu block

2019-02-22 Thread Rob Clark
On Fri, Feb 22, 2019 at 10:39 AM Harry Wentland wrote: > > Powerplay functions called from dm_pp_* functions tend to do a > mutex_lock which isn't safe to do inside a kernel_fpu_begin/end block as > those will disable/enable preemption. > > Rearrange the dm_pp_get_clock_levels_by_type_with_voltage

Re: [PATCH libdrm] tests/amdgpu: add dispatch test

2019-02-22 Thread Alex Deucher
On Mon, Feb 18, 2019 at 9:26 PM Zhang, Hawking wrote: > > Although the shader is simple enough, please work with CQE to test it on all > gfx9 ASICs before push it. > > The patch is Reviewed-by: Hawking Zhang Please make sure this patch gets upstream as well. It doesn't seem to apply cleanly as

Re: [PATCH libdrm] libdrm: Fix issue about differrent domainID but same BDF

2019-02-22 Thread Alex Deucher
Pushed. Thanks! Alex On Thu, Feb 21, 2019 at 9:36 PM Deng, Emily wrote: > > Hi Alex, > Please help, thanks. > > Best wishes > Emily Deng > > > > >-Original Message- > >From: Alex Deucher > >Sent: Friday, February 22, 2019 12:13 AM > >To: Deng, Emily ; Maling list - DRI developers

[PATCH] drm/amdgpu: Enable XGMI mapping for peer device

2019-02-22 Thread Liu, Shaoyun
Adjust vram base offset for XGMI mapping when update the PT entry so the address will fall into correct XGMI aperture for peer device Change-Id: I78bdf244da699d2559481ef5afe9663b3e752236 Signed-off-by: shaoyunl --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 35 +- 1

Re: [PATCH] drm/amdgpu: Enable XGMI mapping for peer device

2019-02-22 Thread Grodzovsky, Andrey
Acked-by: Andrey Grodzovsky Andrey On 2/22/19 4:28 PM, Liu, Shaoyun wrote: > Adjust vram base offset for XGMI mapping when update the PT entry so > the address will fall into correct XGMI aperture for peer device > > Change-Id: I78bdf244da699d2559481ef5afe9663b3e752236 > Signed-off-by: shaoyunl

Re: [PATCH 1/1] [RFC] drm/ttm: Don't init dma32_zone on 64-bit systems

2019-02-22 Thread Kuehling, Felix
On 2019-02-22 8:45 a.m., Thomas Hellstrom wrote: > On Fri, 2019-02-22 at 07:10 +, Koenig, Christian wrote: >> Am 21.02.19 um 22:02 schrieb Thomas Hellstrom: >>> Hi, >>> >>> On Thu, 2019-02-21 at 20:24 +, Kuehling, Felix wrote: On 2019-02-21 12:34 p.m., Thomas Hellstrom wrote: > On

[PATCH 1/1] drm/ttm: Account for kernel allocations in kernel zone only

2019-02-22 Thread Kuehling, Felix
Don't account for them in other zones such as dma32. The kernel page allocator has its own heuristics to avoid exhausting special zones for regular kernel allocations. Signed-off-by: Felix Kuehling CC: thellst...@vmware.com CC: christian.koe...@amd.com --- drivers/gpu/drm/ttm/ttm_memory.c | 6 ++