[PATCH] drm: prefix header search paths with $(srctree)/

2019-01-31 Thread Masahiro Yamada
Currently, the Kbuild core manipulates header search paths in a crazy way [1]. To fix this mess, I want all Makefiles to add explicit $(srctree)/ to the search paths in the srctree. Some Makefiles are already written in that way, but not all. The goal of this work is to make the notation consisten

RE: [PATCH] drm/amdgpu: partial revert cleanup setting bulk_movable v2

2019-01-31 Thread Zhou, David(ChunMing)
If Tom tests it OK as well, feel free add my RB to submit it ASAP. -David > -Original Message- > From: amd-gfx On Behalf Of > Christian K?nig > Sent: Thursday, January 31, 2019 3:57 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: partial revert cleanup setting bulk_

Re: Yet another RX Vega hang with another kernel panic signature. WARNING: inconsistent lock state

2019-01-31 Thread Yang, Philip
I found same issue while debugging, I will submit patch to fix this shortly. Philip On 2019-01-30 10:35 p.m., Mikhail Gavrilov wrote: > Hi folks. > Yet another kernel panic happens while GPU again is hang: > > [ 1469.906798] > [ 1469.906799] WARNING: inconsistent

[PATCH] drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr

2019-01-31 Thread Yang, Philip
amdgpu_vm_get_task_info is called from interrupt handler and sched timeout workqueue, so it is needed to use irq version spin_lock to avoid deadlock. Change-Id: Ifedd4b97535bf0b5d3936edd2d9688957020efd4 --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 delet

Re: [PATCH] drm/amdgpu: use spin_lock_irqsave to protect vm_manager.pasid_idr

2019-01-31 Thread Christian König
Am 31.01.19 um 15:25 schrieb Yang, Philip: amdgpu_vm_get_task_info is called from interrupt handler and sched timeout workqueue, so it is needed to use irq version spin_lock to avoid deadlock. Change-Id: Ifedd4b97535bf0b5d3936edd2d9688957020efd4 Good catch, but your signed-of-by line is missin

Fwd: Bug#921004: downgrade to firmware-amd-graphics_20180825-1_all.deb

2019-01-31 Thread Michel Dänzer
Bad news I'm afraid, looks like the latest firmware (based on linux-firmware commit bc656509a3cfb60fcdfc905d7e23c18873e4e7b9 from 2019-01-14) broke some RX 580 cards. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast |

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

2019-01-31 Thread StDenis, Tom
On 2019-01-31 4:23 a.m., Przemek Socha wrote: > Dnia środa, 30 stycznia 2019 13:42:33 CET piszesz: >> Does the attached patch fix the issue? >> >> Christian. > > I have tested this one also - "drm/amdgpu: partial revert cleanup setting > bulk_movable v2" > >> We still need to set bulk_movable to

RE: Bug#921004: downgrade to firmware-amd-graphics_20180825-1_all.deb

2019-01-31 Thread Deucher, Alexander
Is there a big report? I haven't heard of any other issues and these updates have been upstream in linux-firmware for over a month now. Alex > -Original Message- > From: amd-gfx On Behalf Of > Michel Dänzer > Sent: Thursday, January 31, 2019 11:03 AM > To: amd-gfx@lists.freedesktop.org

Re: Bug#921004: downgrade to firmware-amd-graphics_20180825-1_all.deb

2019-01-31 Thread Michel Dänzer
On 2019-01-31 6:01 p.m., Deucher, Alexander wrote: > Is there a big report? Yeah, 921...@bugs.debian.org => https://bugs.debian.org/921004 . Doesn't have any more information currently though, we'd have to get in touch with the reporter. > I haven't heard of any other issues and these updates ha

[PATCH] drm/amd/display: Attach VRR properties for eDP connectors

2019-01-31 Thread Nicholas Kazlauskas
[Why] eDP was missing in the checks for supported VRR connectors. [How] Attach the properties for eDP connectors too. Cc: Leo Li Cc: Harry Wentland Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=202449 Signed-off-by: Nicholas Kazlauskas --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_

RE: [PATCH] drm/amd/display: Attach VRR properties for eDP connectors

2019-01-31 Thread Deucher, Alexander
> -Original Message- > From: amd-gfx On Behalf Of > Nicholas Kazlauskas > Sent: Thursday, January 31, 2019 1:58 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Sun peng (Leo) ; Wentland, Harry > ; Kazlauskas, Nicholas > > Subject: [PATCH] drm/amd/display: Attach VRR properties for eDP >

Re: [PATCH] drm/amdkfd: Fix if preprocessor statement above kfd_fill_iolink_info_for_cpu

2019-01-31 Thread Kuehling, Felix
Thank you, Nathan. I applied your patch to amd-staging-drm-next. Sorry for the late response. I'm catching up with my email backlog after a vacation. Regards,   Felix On 2019-01-21 6:52 p.m., Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:866:5: war

Re: [PATCH 2/2] drm/amdgpu: use ring buffer for fault handling on GMC 9

2019-01-31 Thread Kuehling, Felix
I don't see how this solves anything. You'll still need to remove entries from this fault ring buffer. Otherwise you'll ignore faults for addresses that have faulted recently, although it may be a new fault. Also, this reintroduces interrupt storms and repeated processing of the same fault in c

Re: [PATCH 1/2] drm/amdgpu: cleanup amdgpu_ih_process a bit more

2019-01-31 Thread Kuehling, Felix
On 2019-01-24 7:52 a.m., Christian König wrote: > Remove the callback and call the dispatcher directly. > > Signed-off-by: Christian König This patch is Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.c | 6 ++-- > drivers/gpu/drm/amd/amdgpu/amdgpu_ih.h | 4 +--

[PATCH 1/3] drm/amdkfd: Move a constant definition around

2019-01-31 Thread Zhao, Yong
The similar definitions should be consecutive. Change-Id: I936cf076363e641c60e0704d8405ae9493718e18 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/

[PATCH 3/3] drm/amdkfd: Optimize out sdma doorbell array in kgd2kfd_shared_resources

2019-01-31 Thread Zhao, Yong
We can directly calculate the sdma doorbell index in the process doorbell pages through the doorbell_index structure in amdgpu_device, so no need to cache them in kgd2kfd_shared_resources any more, resulting in more portable code. Change-Id: Ic657799856ed0256f36b01e502ef0cab263b1f49 Signed-off-by:

[PATCH 2/3] drm/amdkfd: Fix bugs regarding CP user queue doorbells mask on SOC15

2019-01-31 Thread Zhao, Yong
Reserved doorbells for SDMA IH and VCN were not properly masked out when allocating doorbells for CP user queues. This patch fixed that. Change-Id: I670adfc3fd7725d2ed0bd9665cb7f69f8b9023c2 Signed-off-by: Yong Zhao --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 17 ++--- drivers/gpu

[pull] radeon, amdgpu drm-fixes-5.0

2019-01-31 Thread Alex Deucher
Hi Dave, Daniel, Sorry this is a bit late. I had Internet issues yesterday. A few fixes for 5.0: - Fix radeon crash on SI with VM passthrough - Fencing fix for shared buffers - Fix power hwmon reporting on APUs - Powerplay fix for APUs The following changes since commit f0e7ce1eef5854584dfb59b38

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

2019-01-31 Thread Przemek Socha
Dnia środa, 30 stycznia 2019 13:42:33 CET piszesz: > Does the attached patch fix the issue? > > Christian. I have tested this one also - "drm/amdgpu: partial revert cleanup setting bulk_movable v2" >We still need to set bulk_movable to false when new BOs are added or removed. > >v2: also set it

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

2019-01-31 Thread Przemek Socha
Dnia czwartek, 31 stycznia 2019 17:56:32 CET piszesz: > In my experience only the last chunk of the patch is necessary. Can you > try this without: > > > >> + vm->bulk_moveable = false; > > > Too? > > Thanks, > Tom Sure. I have applied only the last chunk of the patch on top of today's a

[pull] ttm, amdgpu drm-next-5.1

2019-01-31 Thread Alex Deucher
Hi Dave, Daniel, More stuff for 5.1. Mostly bug fixes. ttm: - Replace ref/unref naming with get/put amdgpu: - Revert DC clang fix, causes a segfault with some compiler versions - SR-IOV fix - PCIE fix for vega20 - Misc DC fixes The following changes since commit 10117450735c7a7c0858095fb46a860e