Re: [PATCH] drm/amdgpu: add AMDGPU_IB_FLAG_GET_START_SYNCOBJ to expose scheduled fence

2019-01-30 Thread Christian König
Am 29.01.19 um 22:54 schrieb Marek Olšák: On Tue, Jan 29, 2019 at 3:01 AM Christian König > wrote: Am 28.01.19 um 22:52 schrieb Marek Olšák: > From: Marek Olšák mailto:marek.ol...@amd.com>> > > Normal syncobjs signal when an IB finishes.

Re: [PATCH] Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"

2019-01-30 Thread Christian König
Am 29.01.19 um 19:28 schrieb Wentland, Harry: On 2019-01-29 11:57 a.m., Alex Deucher wrote: This reverts commit 10117450735c7a7c0858095fb46a860e7037cb9a. Causes a crash. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=109487 Signed-off-by: Alex Deucher Cc: sta...@vger.kernel.org # 4.19 Tha

Re: [PATCH v2 2/4] drm/amdgpu: Only add rqs for initialized rings.

2019-01-30 Thread Christian König
Am 30.01.19 um 02:53 schrieb Bas Nieuwenhuizen: I don't see another way to figure out if a ring is initialized if the hardware block might not be initialized. Entities have been fixed up to handle num_rqs = 0. Signed-off-by: Bas Nieuwenhuizen --- drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 11

Re: [PATCH v2 1/4] drm/sched: Fix entities with 0 rqs.

2019-01-30 Thread Christian König
Am 30.01.19 um 02:53 schrieb Bas Nieuwenhuizen: Some blocks in amdgpu can have 0 rqs. Job creation already fails with -ENOENT when entity->rq is NULL, so jobs cannot be pushed. Without a rq there is no scheduler to pop jobs, and rq selection already does the right thing with a list of length 0.

Re: [PATCH v7 2/5] drm: Add vrr_enabled property to drm CRTC

2019-01-30 Thread Daniel Vetter
On Thu, Nov 8, 2018 at 3:44 PM Nicholas Kazlauskas wrote: > > This patch introduces the 'vrr_enabled' CRTC property to allow > dynamic control over variable refresh rate support for a CRTC. > > This property should be treated like a content hint to the driver - > if the hardware or driver is not c

[PATCH] drm/amdgpu: Transfer fences to dmabuf importer

2019-01-30 Thread Chris Wilson
amdgpu only uses shared-fences internally, but dmabuf importers rely on implicit write hazard tracking via the reservation_object.fence_excl. For example, the importer use the write hazard for timing a page flip to only occur after the exporter has finished flushing its write into the surface. As s

Re: [PATCH v7 2/5] drm: Add vrr_enabled property to drm CRTC

2019-01-30 Thread Daniel Vetter
On Wed, Jan 30, 2019 at 11:42 AM Daniel Vetter wrote: > > On Thu, Nov 8, 2018 at 3:44 PM Nicholas Kazlauskas > wrote: > > > > This patch introduces the 'vrr_enabled' CRTC property to allow > > dynamic control over variable refresh rate support for a CRTC. > > > > This property should be treated l

amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

2019-01-30 Thread Przemek Socha
Good morning, after last pull from the amd-staging-drm-next tree (29th of February) I have random Oops on A6 6310 APU with r4 Mullins. Here is the Oops part of the log taken from pstore: <1>[ 55.166270] BUG: unable to handle kernel NULL pointer dereference at 0208 <1>[ 55.16628

[PATCH] drm/amdgpu: fix the incorrect external id for raven series

2019-01-30 Thread Huang Rui
This patch fixes the incorrect external id that kernel reports to user mode driver. Raven2's rev_id is starts from 0x8, so its external id (0x81) should start from rev_id + 0x79 (0x81 - 0x8). And Raven's rev_id should be 0x21 while rev_id == 1. Reported-by: Crystal Jin Signed-off-by: Huang Rui -

Re: [PATCH] drm/amdgpu: Transfer fences to dmabuf importer

2019-01-30 Thread Christian König
Am 30.01.19 um 11:55 schrieb Chris Wilson: amdgpu only uses shared-fences internally, but dmabuf importers rely on implicit write hazard tracking via the reservation_object.fence_excl. For example, the importer use the write hazard for timing a page flip to only occur after the exporter has finis

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

2019-01-30 Thread Christian König
This is a known issue, see here as well https://bugs.freedesktop.org/show_bug.cgi?id=109487 Christian. Am 30.01.19 um 12:07 schrieb Przemek Socha: Good morning, after last pull from the amd-staging-drm-next tree (29th of February) I have random Oops on A6 6310 APU with r4 Mullins. Here is th

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

2019-01-30 Thread Koenig, Christian
Sorry I accidentally replied to the wrong mail. This is a new issue. Going to take a look now. Christian. Am 30.01.19 um 13:02 schrieb Christian König: This is a known issue, see here as well https://bugs.freedesktop.org/show_bug.cgi?id=109487 Christian. Am 30.01.19 um 12:07 schrieb Przemek S

RE: [PATCH] drm/amdgpu: fix the incorrect external id for raven series

2019-01-30 Thread Zhang, Hawking
Reviewed-by: Hawking Zhang Regards, Hawking -Original Message- From: Huang Rui Sent: 2019年1月30日 19:58 To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking ; Jin, Crystal ; Huang, Ray Subject: [PATCH] drm/amdgpu: fix the incorrect external id for raven series This patch fixes the inco

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

2019-01-30 Thread Koenig, Christian
Does the attached patch fix the issue? Christian. Am 30.01.19 um 13:06 schrieb Christian König: Sorry I accidentally replied to the wrong mail. This is a new issue. Going to take a look now. Christian. Am 30.01.19 um 13:02 schrieb Christian König: This is a known issue, see here as well https

[PATCH] drm/amdgpu: partial revert cleanup setting bulk_movable

2019-01-30 Thread Christian König
We still need to set bulk_movable to false when new BOs are added. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 79f9dde70bc0..1e

Re: [PATCH v7 2/5] drm: Add vrr_enabled property to drm CRTC

2019-01-30 Thread Kazlauskas, Nicholas
On 1/30/19 6:02 AM, Daniel Vetter wrote: > On Wed, Jan 30, 2019 at 11:42 AM Daniel Vetter wrote: >> >> On Thu, Nov 8, 2018 at 3:44 PM Nicholas Kazlauskas >> wrote: >>> >>> This patch introduces the 'vrr_enabled' CRTC property to allow >>> dynamic control over variable refresh rate support for a C

RE: [PATCH] drm/amdgpu: partial revert cleanup setting bulk_movable

2019-01-30 Thread Huang, Ray
> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Christian K?nig > Sent: Wednesday, January 30, 2019 8:47 PM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH] drm/amdgpu: partial revert cleanup setting bulk_movable > > We still need to

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

2019-01-30 Thread StDenis, Tom
On 2019-01-30 7:42 a.m., Koenig, Christian wrote: > Does the attached patch fix the issue? No. Now I get a lockup when I start GNOME and try to bring up a terminal. The patch also didn't apply cleanly on top of drm-next but I was able to just manually add the line. [ 88.018735] general prot

Re: [PATCH] drm/amd/powerplay: Remove duplicate header

2019-01-30 Thread Deucher, Alexander
It was already fixed a while ago: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7e07834c12b96214e95a473f7b14fc03b20e2e7a Alex From: Brajeswar Ghosh Sent: Wednesday, January 30, 2019 8:58:52 AM To: Souptick Joarder Cc: Zhu, Rex; Q

Re: [PATCH] drm/amd/powerplay: Remove duplicate header

2019-01-30 Thread Brajeswar Ghosh
On Fri, Dec 21, 2018 at 6:06 PM Souptick Joarder wrote: > > On Fri, Dec 21, 2018 at 2:49 PM Brajeswar Ghosh > wrote: > > > > Remove hwmgr_ppt.h which is included more than once > > > > Signed-off-by: Brajeswar Ghosh > > --- > Acked-by: Souptick Joarder If no further comment, can we get this pa

Re: amd-staging-drm-next: Oops - BUG: unable to handle kernel NULL pointer dereference, bisected.

2019-01-30 Thread Przemek Socha
Dnia środa, 30 stycznia 2019 13:42:33 CET piszesz: > Does the attached patch fix the issue? > > Christian. > > . Thanks for the rapid response, but unfortunately no. System freezes and only mouse pointer is movable (cannot switch tty's, reboot by pwr button, tree-finger-salute doesn't work

Re: [PATCH] drm/amdgpu: tighten gpu_recover in mailbox_flr to avoid duplicate recover in sriov

2019-01-30 Thread Grodzovsky, Andrey
Acked-by: Andrey Grodzovsky Andrey On 01/29/2019 10:16 PM, wentalou wrote: > sriov's gpu_recover inside xgpu_ai_mailbox_flr_work would cause duplicate > recover in TDR. > TDR's gpu_recover would be triggered by amdgpu_job_timedout, > that could avoid vk-cts failure by unexpected recover. > > C

[PATCH libdrm] amdgpu: add some raven marketing names

2019-01-30 Thread Alex Deucher
Signed-off-by: Alex Deucher --- data/amdgpu.ids | 4 1 file changed, 4 insertions(+) diff --git a/data/amdgpu.ids b/data/amdgpu.ids index d9ed5660..d24c7ee6 100644 --- a/data/amdgpu.ids +++ b/data/amdgpu.ids @@ -4,6 +4,10 @@ # device_id, revision_id,product_name<-- single tab

Re: [PATCH libdrm] amdgpu: add some raven marketing names

2019-01-30 Thread Christian König
Am 30.01.19 um 17:33 schrieb Alex Deucher: Signed-off-by: Alex Deucher Acked-by: Christian König --- data/amdgpu.ids | 4 1 file changed, 4 insertions(+) diff --git a/data/amdgpu.ids b/data/amdgpu.ids index d9ed5660..d24c7ee6 100644 --- a/data/amdgpu.ids +++ b/data/amdgpu.ids @@ -4

[PATCH] drm/amdgpu: partial revert cleanup setting bulk_movable v2

2019-01-30 Thread Christian König
We still need to set bulk_movable to false when new BOs are added or removed. v2: also set it to false on removal Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/g