Re: [PATCH] drm/amdgpu: fix VM leaf walking

2018-10-26 Thread Christian König
Yeah, that came to my mind as well. But this is the only case where we would use the return value and not use cursor->pfn as criteria to abort. So to be consistent I rather don't want to do this, Christian. Am 25.10.18 um 17:43 schrieb Zhu, Rex: How about add a return value for the function

Re: [PATCH] drm/amd/display: set backlight level limit to 1

2018-10-26 Thread Guttula
On 10/26/2018 12:04 AM, Wentland, Harry wrote: > On 2018-10-25 2:58 a.m., Guttula, Suresh wrote: >> This patch will work as workaround for silicon limitation >> related to PWM dutycycle when the backlight level goes to 0. >> >> Actually PWM value is 16 bit value and valid range from 1-65535. >> w

Re: [PATCH 1/8] dma-buf: remove shared fence staging in reservation object

2018-10-26 Thread Christian König
Am 25.10.18 um 23:21 schrieb Chris Wilson: Quoting Chris Wilson (2018-10-25 21:20:21) Quoting Chris Wilson (2018-10-25 21:15:17) Quoting Christian König (2018-10-04 14:12:43) No need for that any more. Just replace the list when there isn't enough room any more for the additional fence. Just

Re: [PATCH] drm/amdgpu: Fix compute ring 1.0.0 failure after reset

2018-10-26 Thread Christian König
Am 25.10.18 um 22:16 schrieb Andrey Grodzovsky: Problem: After GPU reset on dGPUs with gfx8 compute ring 1.0.0 fails to pass the ring test. Ring registers inspection shows that it's active and no hang is observed (rptr == wptr) No significant diffs were observed between CP_HQD* registers for the

Re: [igt-dev] [PATCH] RFC: Make igts for cross-driver stuff mandatory?

2018-10-26 Thread Daniel Vetter
On Fri, Oct 26, 2018 at 5:50 AM Zhou, David(ChunMing) wrote: > > Make igt for cross-driver, I think you should rename it first, not an intel > specific. NO company wants their employee working on other company stuff. > You can rename it to DGT(drm graphics test), and published following libdrm,

Re: [igt-dev] [PATCH] RFC: Make igts for cross-driver stuff mandatory?

2018-10-26 Thread zhoucm1
On 2018年10月26日 16:32, Daniel Vetter wrote: On Fri, Oct 26, 2018 at 5:50 AM Zhou, David(ChunMing) wrote: Make igt for cross-driver, I think you should rename it first, not an intel specific. NO company wants their employee working on other company stuff. You can rename it to DGT(drm graphics

Re: [PATCH v2 0/3] A DRM API for adaptive sync and variable refresh rate support

2018-10-26 Thread Michel Dänzer
On 2018-10-25 7:57 p.m., Wentland, Harry wrote: > On 2018-10-12 4:31 a.m., Koenig, Christian wrote: >> Am 12.10.2018 um 10:26 schrieb Michel Dänzer: >>> On 2018-10-11 9:44 p.m., Harry Wentland wrote: On 2018-10-03 04:25 AM, Mike Lothian wrote: > I'm curious to know whether this will/could

[PATCH libdrm] amdgpu: add VM test to exercise max/min address space

2018-10-26 Thread Christian König
Make sure the kernel doesn't crash if we map something at the minimum/maximum address. Signed-off-by: Christian König --- tests/amdgpu/vm_tests.c | 45 - 1 file changed, 44 insertions(+), 1 deletion(-) diff --git a/tests/amdgpu/vm_tests.c b/tests/amdgpu/

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-26 Thread Pekka Paalanen
On Thu, 11 Oct 2018 12:39:41 -0400 Nicholas Kazlauskas wrote: > These include the drm_connector 'vrr_capable' and the drm_crtc > 'vrr_enabled' properties. > > Signed-off-by: Nicholas Kazlauskas > --- > Documentation/gpu/drm-kms.rst | 7 +++ > drivers/gpu/drm/drm_connector.c | 22 +++

Re: [PATCH libdrm] amdgpu: add VM test to exercise max/min address space

2018-10-26 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Friday, October 26, 2018 6:59:21 AM To: amd-gfx@lists.freedesktop.org Subject: [PATCH libdrm] amdgpu: add VM test to exercise max/min address space Make sure the kernel doesn't crash if

[PATCH 3/3] drm/amd:Enable/Disable NBPSTATE on On/OFF of UVD

2018-10-26 Thread Guttula, Suresh
We observe black lines (underflow) on display when playing a 4K video with UVD. On Disabling Low memory P state this issue is not seen. In this patch ,disabling low memory P state only when video size >= 4k. Multiple runs of power measurement shows no imapct Signed-off-by: suresh guttula --- dri

[PATCH 1/3] Revert "drm/amd/powerplay: Enable/Disable NBPSTATE on On/OFF of UVD"

2018-10-26 Thread Guttula, Suresh
From: "S, Shirish" This reverts commit dbd8299c32f6f413f6cfe322fe0308f3cfc577e8. Reason for revert: This patch sends msg PPSMC_MSG_DisableLowMemoryPstate(0x002e) in wrong of sequence to SMU which is before PPSMC_MSG_UVDPowerON (0x0008). This leads to SMU failing to service the request as it is

[PATCH 2/3] drm/amd/powerplay:add hwmgr callback to update nbpstate on Carrizo

2018-10-26 Thread Guttula, Suresh
This callback is used to access hwmgr function named as cz_nbdpm_pstate_enable_disable. Signed-off-by: suresh guttula --- drivers/gpu/drm/amd/powerplay/hwmgr/smu8_hwmgr.c | 1 + drivers/gpu/drm/amd/powerplay/inc/hwmgr.h| 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/d

Re: [PATCH] drm/amd/display: set backlight level limit to 1

2018-10-26 Thread Wentland, Harry
On 2018-10-26 2:44 a.m., Guttula, Suresh wrote: > > > On 10/26/2018 12:04 AM, Wentland, Harry wrote: >> On 2018-10-25 2:58 a.m., Guttula, Suresh wrote: >>> This patch will work as workaround for silicon limitation >>> related to PWM dutycycle when the backlight level goes to 0. >>> >>> Actually P

Re: [PATCH v5 2/4] drm: Add vrr_enabled property to drm CRTC

2018-10-26 Thread Pekka Paalanen
On Mon, 15 Oct 2018 12:06:52 +0200 Michel Dänzer wrote: > On 2018-10-15 11:47 a.m., Christian König wrote: > > Am 15.10.2018 um 11:40 schrieb Michel Dänzer: > >> On 2018-10-13 7:38 p.m., Christian König wrote: > >>> Am 12.10.2018 um 18:44 schrieb Nicholas Kazlauskas: > This patch intro

Re: [igt-dev] [PATCH] RFC: Make igts for cross-driver stuff mandatory?

2018-10-26 Thread Alex Deucher
On Fri, Oct 26, 2018 at 4:32 AM Daniel Vetter wrote: > > On Fri, Oct 26, 2018 at 5:50 AM Zhou, David(ChunMing) > wrote: > > > > Make igt for cross-driver, I think you should rename it first, not an intel > > specific. NO company wants their employee working on other company stuff. > > You can re

[PATCH] drm/v3d: Fix compilation error on kbuilt test robot.

2018-10-26 Thread Andrey Grodzovsky
Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/v3d/v3d_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sched.c index 273d0fb..80b641f 100644 --- a/drivers/gpu/drm/v3d/v3d_sched.c +++ b/drivers/gpu/drm/v3d/

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-26 Thread Kazlauskas, Nicholas
On 10/26/18 7:37 AM, Pekka Paalanen wrote: > On Thu, 11 Oct 2018 12:39:41 -0400 > Nicholas Kazlauskas wrote: > >> These include the drm_connector 'vrr_capable' and the drm_crtc >> 'vrr_enabled' properties. >> >> Signed-off-by: Nicholas Kazlauskas >> --- >> Documentation/gpu/drm-kms.rst | 7

Re: [PATCH] drm/v3d: Fix compilation error on kbuilt test robot.

2018-10-26 Thread Alex Deucher
On Fri, Oct 26, 2018 at 10:43 AM Andrey Grodzovsky wrote: > > Signed-off-by: Andrey Grodzovsky Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/v3d/v3d_sched.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sc

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-26 Thread Ville Syrjälä
On Fri, Oct 26, 2018 at 02:49:31PM +, Kazlauskas, Nicholas wrote: > On 10/26/18 7:37 AM, Pekka Paalanen wrote: > > On Thu, 11 Oct 2018 12:39:41 -0400 > > Nicholas Kazlauskas wrote: > > > >> These include the drm_connector 'vrr_capable' and the drm_crtc > >> 'vrr_enabled' properties. > >> > >>

Re: [PATCH] drm/amdgpu: Fix compute ring 1.0.0 failure after reset

2018-10-26 Thread Grodzovsky, Andrey
On 10/26/2018 04:05 AM, Christian König wrote: > Am 25.10.18 um 22:16 schrieb Andrey Grodzovsky: >> Problem: After GPU reset on dGPUs with gfx8 compute ring >> 1.0.0 fails to pass the ring test. Ring registers inspection >> shows that it's active and no hang is observed (rptr == wptr) >> No signi

Re: [PATCH] RFC: Make igts for cross-driver stuff mandatory?

2018-10-26 Thread Alex Deucher
On Fri, Oct 19, 2018 at 4:51 AM Daniel Vetter wrote: > > Hi all, > > This is just to collect feedback on this idea, and see whether the > overall dri-devel community stands on all this. I think the past few > cross-vendor uapi extensions all came with igts attached, and > personally I think there'

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-26 Thread Kazlauskas, Nicholas
On 10/26/18 10:53 AM, Ville Syrjälä wrote: > On Fri, Oct 26, 2018 at 02:49:31PM +, Kazlauskas, Nicholas wrote: >> On 10/26/18 7:37 AM, Pekka Paalanen wrote: >>> On Thu, 11 Oct 2018 12:39:41 -0400 >>> Nicholas Kazlauskas wrote: >>> These include the drm_connector 'vrr_capable' and the drm_

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-26 Thread Ville Syrjälä
On Fri, Oct 26, 2018 at 05:34:15PM +, Kazlauskas, Nicholas wrote: > On 10/26/18 10:53 AM, Ville Syrjälä wrote: > > On Fri, Oct 26, 2018 at 02:49:31PM +, Kazlauskas, Nicholas wrote: > >> On 10/26/18 7:37 AM, Pekka Paalanen wrote: > >>> On Thu, 11 Oct 2018 12:39:41 -0400 > >>> Nicholas Kazlau

Re: [PATCH] drm/v3d: Fix compilation error on kbuilt test robot.

2018-10-26 Thread Christian König
Am 26.10.18 um 16:43 schrieb Andrey Grodzovsky: Signed-off-by: Andrey Grodzovsky Reviewed-by: Christian König --- drivers/gpu/drm/v3d/v3d_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/v3d/v3d_sched.c b/drivers/gpu/drm/v3d/v3d_sched.c index 27

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-26 Thread Manasi Navare
On Fri, Oct 26, 2018 at 05:34:15PM +, Kazlauskas, Nicholas wrote: > On 10/26/18 10:53 AM, Ville Syrjälä wrote: > > On Fri, Oct 26, 2018 at 02:49:31PM +, Kazlauskas, Nicholas wrote: > >> On 10/26/18 7:37 AM, Pekka Paalanen wrote: > >>> On Thu, 11 Oct 2018 12:39:41 -0400 > >>> Nicholas Kazlau

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-26 Thread Kazlauskas, Nicholas
On 10/26/18 3:13 PM, Manasi Navare wrote: > On Fri, Oct 26, 2018 at 05:34:15PM +, Kazlauskas, Nicholas wrote: >> On 10/26/18 10:53 AM, Ville Syrjälä wrote: >>> On Fri, Oct 26, 2018 at 02:49:31PM +, Kazlauskas, Nicholas wrote: On 10/26/18 7:37 AM, Pekka Paalanen wrote: > On Thu, 11

Re: [PATCH v4 3/4] drm: Document variable refresh properties

2018-10-26 Thread Manasi Navare
On Fri, Oct 26, 2018 at 08:06:11PM +, Kazlauskas, Nicholas wrote: > On 10/26/18 3:13 PM, Manasi Navare wrote: > > On Fri, Oct 26, 2018 at 05:34:15PM +, Kazlauskas, Nicholas wrote: > >> On 10/26/18 10:53 AM, Ville Syrjälä wrote: > >>> On Fri, Oct 26, 2018 at 02:49:31PM +, Kazlauskas, Nic