[PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-12 Thread Nathan Chancellor
Clang warns if there are missing braces around a subobject initializer. drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:41: warning: suggest braces around initialization of subobject [-Wmissing-braces] struct amdgpu_task_info task_info = { 0 };

Re: [PATCH 6/9] drm/amdgpu: add freesync ioctl

2018-09-12 Thread Christian König
Am 11.09.2018 um 21:17 schrieb Alex Deucher: On Tue, Sep 11, 2018 at 1:59 PM Kazlauskas, Nicholas wrote: On 09/11/2018 01:51 PM, Christian König wrote: Am 11.09.2018 um 18:13 schrieb Nicholas Kazlauskas: From: Harry Wentland Add the ioctl to enable/disable freesync. Why do we still need th

Re: [PATCH] drm/amdgpu: use HMM mirror callback to replace mmu notifier

2018-09-12 Thread Christian König
Am 11.09.2018 um 21:31 schrieb Philip Yang: Replace our MMU notifier with hmm_mirror_ops.sync_cpu_device_pagetables callback if kernel configured HMM. Kenel configured without HMM still uses our own MMU notifier. Please drop that and always use the HMM path. When a kernel doesn't support HM

Re: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-12 Thread Christian König
Ping? Have you seen my comments here? Looks like you haven't addressed any of them in your last mail. Christian. Am 06.09.2018 um 09:25 schrieb Christian König: Am 06.09.2018 um 08:25 schrieb Chunming Zhou: VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has

Re: [PATCH xf86-video-amdgpu 0/6] xf86-video-amdgpu integration for DRM variable refresh rate API

2018-09-12 Thread Michel Dänzer
Hi Nicholas, thanks for the patches. On 2018-09-11 6:18 p.m., Nicholas Kazlauskas wrote: > These patches are part of a proposed new interface for supporting variable > refresh rate via DRM properties. > > https://patchwork.freedesktop.org/series/49486/ > > When notified of a window that is

[PATCH 3/8] drm/amdgpu: use dfs iterator to free PDs/PTs

2018-09-12 Thread Christian König
Allows us to free all PDs/PTs without recursion. Signed-off-by: Christian König Reviewed-by: Felix Kuehling Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 62 -- 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/drivers/gpu/

[PATCH 5/8] drm/amdgpu: use leaf iterator for filling PTs

2018-09-12 Thread Christian König
Less overhead and is the starting point for further cleanups and improvements. Signed-off-by: Christian König Reviewed-by: Felix Kuehling Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 62 -- 1 file changed, 15 insertions(+), 47 deletions

[PATCH 6/8] drm/amdgpu: meld together VM fragment and huge page handling

2018-09-12 Thread Christian König
This optimizes the generating of PTEs by walking the hierarchy only once for a range and making changes as necessary. It allows for both huge (2MB) as well giant (1GB) pages to be used on Vega and Raven. Signed-off-by: Christian König Reviewed-by: Felix Kuehling Acked-by: Junwei Zhang --- dri

[PATCH 1/8] drm/amdgpu: add some VM PD/PT iterators v2

2018-09-12 Thread Christian König
Both a leaf as well as dfs iterator to walk over all the PDs/PTs. v2: update comments and fix for_each_amdgpu_vm_pt_dfs_safe Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 224 + 1 file changed, 224 insertions(+) diff --git a/drivers

[PATCH 8/8] drm/amdgpu: allow fragment processing for invalid PTEs

2018-09-12 Thread Christian König
That should improve the PRT performance on Vega quite a bit. Signed-off-by: Christian König Reviewed-by: Felix Kuehling Acked-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c

[PATCH 2/8] drm/amdgpu: use leaf iterator for allocating PD/PT

2018-09-12 Thread Christian König
Less code and allows for easier error handling. Signed-off-by: Christian König Reviewed-by: Felix Kuehling Reviewed-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 156 - 1 file changed, 55 insertions(+), 101 deletions(-) diff --git a/drivers/gpu/

[PATCH 7/8] drm/amdgpu: use the maximum possible fragment size on Vega/Raven

2018-09-12 Thread Christian König
The fragment size controls only the L1 on Vega/Raven and we now don't have any extra overhead any more because of larger fragments. Signed-off-by: Christian König Acked-by: Junwei Zhang --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) d

[PATCH 4/8] drm/amdgpu: use the DFS iterator in amdgpu_vm_invalidate_pds v2

2018-09-12 Thread Christian König
Less code and easier to maintain. v2: rename the function as well Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 32 1 file changed, 8 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu

[PATCH 1/2] drm/amdgpu: remove amdgpu_bo_list_entry.robj

2018-09-12 Thread Christian König
We can get that just by casting tv.bo. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 42 - drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.h | 1 - drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 58 - drivers/gpu/drm/am

[PATCH 2/2] drm/amdgpu: use a single linked list for amdgpu_vm_bo_base

2018-09-12 Thread Christian König
Instead of the double linked list. Gets the size of amdgpu_vm_pt down to 64 bytes again. We could even reduce it down to 32 bytes, but that would require some rather extreme hacks. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_object.c | 2 +- drivers/gpu/drm/amd/amdgpu/

Re: [PATCH 1/2] drm/amdgpu: Moved fault hash table to amdgpu vm

2018-09-12 Thread Christian König
Am 07.09.2018 um 05:28 schrieb Oak Zeng: In stead of share one fault hash table per device, make it per vm. This can avoid inter-process lock issue when fault hash table is full. Change-Id: I5d1281b7c41eddc8e26113e010516557588d3708 Signed-off-by: Oak Zeng Suggested-by: Christian Konig Suggeste

[PATCH 1/9] drm: fix syncobj null_fence_enable_signaling

2018-09-12 Thread Chunming Zhou
That is certainly totally nonsense. dma_fence_enable_sw_signaling() is the function who is calling this callback. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand Reviewed-by: Christian König Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_syncobj.c | 1 - 1 file changed, 1 deletion(-) diff -

[PATCH 2/9] drm: rename null fence to stub fence in syncobj v2

2018-09-12 Thread Chunming Zhou
moved to front of file. stub fence will be used by timeline syncobj as well. Signed-off-by: Chunming Zhou Cc: Jason Ekstrand Reviewed-by: Christian König --- drivers/gpu/drm/drm_syncobj.c | 53 +++ 1 file changed, 29 insertions(+), 24 deletions(-) diff --git a/

[PATCH 7/9] drm: add timeline syncobj payload query ioctl

2018-09-12 Thread Chunming Zhou
user mode can query timeline payload. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 ++ drivers/gpu/drm/drm_ioctl.c| 2 ++ drivers/gpu/drm/drm_syncobj.c | 53 ++ include/uapi/drm/drm.h | 11 +++ 4 files changed, 68 insertio

[PATCH 4/9] drm: expand replace_fence to support timeline point v2

2018-09-12 Thread Chunming Zhou
we can place a fence to a timeline point after expanded. v2: change func parameter order Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 14 -- drivers/gpu/drm/i915/i915_ge

[PATCH 8/9] drm/amdgpu: add timeline support in amdgpu CS

2018-09-12 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 8 +- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 111 +++-- include/uapi/drm/amdgpu_drm.h | 9 ++ 3 files changed, 100 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/a

[PATCH 9/9] drm/amdgpu: move cs dependencies front a bit

2018-09-12 Thread Chunming Zhou
cs dependencies handling doesn't need in vm resv Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/am

[PATCH 6/9] drm: add support of syncobj timeline point wait v2

2018-09-12 Thread Chunming Zhou
points array is one-to-one match with syncobjs array. v2: add seperate ioctl for timeline point wait, otherwise break uapi. Signed-off-by: Chunming Zhou --- drivers/gpu/drm/drm_internal.h | 2 + drivers/gpu/drm/drm_ioctl.c| 2 + drivers/gpu/drm/drm_syncobj.c | 87 +

[PATCH 5/9] [RFC]drm: add syncobj timeline support v4

2018-09-12 Thread Chunming Zhou
VK_KHR_timeline_semaphore: This extension introduces a new type of semaphore that has an integer payload identifying a point in a timeline. Such timeline semaphores support the following operations: * CPU query - A host operation that allows querying the payload of the timeline semaphore.

[PATCH 3/9] drm: expand drm_syncobj_find_fence to support timeline point v2

2018-09-12 Thread Chunming Zhou
we can fetch timeline point fence after expanded. v2: The parameter fence is the result of the function and should come last. Signed-off-by: Chunming Zhou Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +- drivers/gpu/drm/drm_syncobj.c | 5 +++-- drivers/gp

[PATCH libdrm 1/5] [libdrm] sync drm.h for syncobj part

2018-09-12 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm/drm.h | 24 1 file changed, 24 insertions(+) diff --git a/include/drm/drm.h b/include/drm/drm.h index f0bd91de..d1688269 100644 --- a/include/drm/drm.h +++ b/include/drm/drm.h @@ -695,6 +695,7 @@ struct drm_prime_handle { str

[PATCH libdrm 3/5] [libdrm]: add timeline wait/query ioctl

2018-09-12 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- xf86drm.c | 44 xf86drm.h | 6 ++ 2 files changed, 50 insertions(+) diff --git a/xf86drm.c b/xf86drm.c index b2388194..0cd1cb75 100644 --- a/xf86drm.c +++ b/xf86drm.c @@ -4249,3 +4249,47 @@ int drmSyncobjSignal(in

[PATCH libdrm 2/5] [libdrm] addr cs chunk for syncobj timeline

2018-09-12 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- include/drm/amdgpu_drm.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index c363b67f..04663a13 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_drm.h @@ -482,6 +482,8 @@ struct drm_a

[PATCH libdrm 4/5] [libdrm]: wrap syncobj timeline query and wait for amdgpu

2018-09-12 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- amdgpu/amdgpu-symbol-check | 2 ++ amdgpu/amdgpu.h| 39 ++ amdgpu/amdgpu_cs.c | 24 +++ 3 files changed, 65 insertions(+) diff --git a/amdgpu/amdgpu-symbol-check b/amdgpu/amdgpu-symbol-c

[PATCH libdrm 5/5] [libdrm] add syncobj timeline tests

2018-09-12 Thread Chunming Zhou
Signed-off-by: Chunming Zhou --- tests/amdgpu/Makefile.am | 3 +- tests/amdgpu/amdgpu_test.c | 12 ++ tests/amdgpu/amdgpu_test.h | 21 +++ tests/amdgpu/meson.build | 2 +- tests/amdgpu/syncobj_tests.c | 258 +++ 5 files changed, 294 insertions(+),

Re: [PATCH libdrm 4/5] [libdrm]: wrap syncobj timeline query and wait for amdgpu

2018-09-12 Thread Michel Dänzer
On 2018-09-12 11:50 a.m., Chunming Zhou wrote: > Signed-off-by: Chunming Zhou > --- > amdgpu/amdgpu-symbol-check | 2 ++ > amdgpu/amdgpu.h| 39 ++ > amdgpu/amdgpu_cs.c | 24 +++ > 3 files changed, 65 insertions(+) > > d

Re: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-12 Thread zhoucm1
On 2018年09月12日 15:22, Christian König wrote: Ping? Have you seen my comments here? Sorry, I didn't see this reply.  inline... Looks like you haven't addressed any of them in your last mail. Christian. Am 06.09.2018 um 09:25 schrieb Christian König: Am 06.09.2018 um 08:25 schrieb Chunming

Re: [PATCH 1/2] drm/amdgpu: remove amdgpu_bo_list_entry.robj

2018-09-12 Thread zhoucm1
Reviewed-by: Chunming Zhou On 2018年09月12日 16:55, Christian König wrote: We can get that just by casting tv.bo. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.c | 42 - drivers/gpu/drm/amd/amdgpu/amdgpu_bo_list.h | 1 - drivers/gpu/drm/am

Re: [PATCH 2/2] drm/amdgpu: use a single linked list for amdgpu_vm_bo_base

2018-09-12 Thread zhoucm1
Reviewed-by: Chunming Zhou On 2018年09月12日 16:55, Christian König wrote: Instead of the double linked list. Gets the size of amdgpu_vm_pt down to 64 bytes again. We could even reduce it down to 32 bytes, but that would require some rather extreme hacks. Signed-off-by: Christian König --- d

Re: [PATCH 1/3] [RFC]drm: add syncobj timeline support v4

2018-09-12 Thread Christian König
Am 12.09.2018 um 12:20 schrieb zhoucm1: [SNIP] Drop the term semaphore here, better use syncobj. This is from VK_KHR_timeline_semaphore extension describe, not my invention, I just quote it. In kernel side, we call syncobj, in UMD, they still call semaphore. Yeah, but we don't care about clo

RE: [PATCH 2/5] drm/amdgpu: always enable shadow BOs

2018-09-12 Thread Deng, Emily
Acked-by: Emily Deng >-Original Message- >From: amd-gfx On Behalf Of >Christian König >Sent: Tuesday, September 11, 2018 9:22 PM >To: Michel Dänzer >Cc: amd-gfx@lists.freedesktop.org >Subject: Re: [PATCH 2/5] drm/amdgpu: always enable shadow BOs > >Am 11.09.2018 um 14:29 schrieb Michel

Re: [PATCH xf86-video-amdgpu 0/6] xf86-video-amdgpu integration for DRM variable refresh rate API

2018-09-12 Thread Kazlauskas, Nicholas
On 09/12/2018 04:13 AM, Michel Dänzer wrote: Hi Nicholas, thanks for the patches. On 2018-09-11 6:18 p.m., Nicholas Kazlauskas wrote: These patches are part of a proposed new interface for supporting variable refresh rate via DRM properties. https://patchwork.freedesktop.org/series/49486/

[PATCH v2 0/3] Add DMCU fw loading on raven

2018-09-12 Thread David Francis
v2: measure intv offset in bytes instead of words David Francis (3): drm/amd: Add ucode DMCU support drm/amd: Add PSP DMCU support drm/amd: Add DM DMCU support drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 21 - drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 10 ++ drivers/gpu/drm/a

[PATCH v2 1/3] drm/amd: Add ucode DMCU support

2018-09-12 Thread David Francis
DMCU (Display Microcontroller Unit) is a GPU chip involved in eDP features like Adaptive Backlight Modulation and Panel Self Refresh. DMCU has two pieces of firmware: the ERAM and the interrupt vectors, which must be loaded seperately. To this end, the DMCU firmware has a custom header and parsin

[PATCH v2 2/3] drm/amd: Add PSP DMCU support

2018-09-12 Thread David Francis
DMCU (Display Microcontroller Unit) is a GPU chip involved in eDP features like Adaptive Backlight Modulation and Panel Self Refresh. PSP is already equipped to handle DMCU firmware loading, all that is needed is to translate between the new DMCU ucode ID and the equivalent psp_gfx_fw_type. Signe

[PATCH v2 3/3] drm/amd: Add DM DMCU support

2018-09-12 Thread David Francis
DMCU (Display Microcontroller Unit) is a GPU chip involved in eDP features like Adaptive Backlight Modulation and Panel Self Refresh. DC is already fully equipped to initialize DMCU as long as the firmware is loaded. At the moment only the raven firmware is available. A single .bin file is loade

Re: [PATCH] drm/amdgpu: use HMM mirror callback to replace mmu notifier

2018-09-12 Thread Philip Yang
On 2018-09-12 03:15 AM, Christian König wrote: Am 11.09.2018 um 21:31 schrieb Philip Yang: Replace our MMU notifier with hmm_mirror_ops.sync_cpu_device_pagetables callback if kernel configured HMM. Kenel configured without HMM still uses our own MMU notifier. Please drop that and always use

Re: [PATCH] drm/amdgpu: use HMM mirror callback to replace mmu notifier

2018-09-12 Thread Christian König
Am 12.09.2018 um 16:56 schrieb Philip Yang: On 2018-09-12 03:15 AM, Christian König wrote: Am 11.09.2018 um 21:31 schrieb Philip Yang: Replace our MMU notifier with hmm_mirror_ops.sync_cpu_device_pagetables callback if kernel configured HMM. Kenel configured without HMM still uses our own MM

[PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Arnd Bergmann
The .ioctl and .compat_ioctl file operations have the same prototype so they can both point to the same function, which works great almost all the time when all the commands are compatible. One exception is the s390 architecture, where a compat pointer is only 31 bit wide, and converting it into a

Re: [PATCH 1/2] drm/amdgpu: Moved fault hash table to amdgpu vm

2018-09-12 Thread Felix Kuehling
On 2018-09-12 02:56 AM, Christian König wrote: > Am 12.09.2018 um 00:00 schrieb Felix Kuehling: >> On 2018-09-11 03:19 AM, Christian König wrote: >>> Hi Felix, >>> >>> let me try to explain the problem on an example: >>> >>> 1. We have a running job which needs recoverable page faults for >>> acces

[pull] amdgpu drm-fixes-4.19

2018-09-12 Thread Alex Deucher
Hi Dave, A few fixes for 4.19: - Fix a small memory leak - SR-IOV reset fix - Fix locking in MMU-notifier error path - Updated SDMA golden settings to fix a PRT hang The following changes since commit 67c6ed7cf9ebe53815f15bfdeb49ad91801c2235: Merge tag 'drm-intel-fixes-2018-09-05' of git://an

Re: [PATCH v2 0/3] Add DMCU fw loading on raven

2018-09-12 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of David Francis Sent: Wednesday, September 12, 2018 10:34:42 AM To: amd-gfx@lists.freedesktop.org Cc: Francis, David Subject: [PATCH v2 0/3] Add DMCU fw loading on raven v2: measure intv offset in

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Daniel Vetter
On Wed, Sep 12, 2018 at 5:08 PM, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architecture, wher

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Jason Gunthorpe
On Wed, Sep 12, 2018 at 05:08:52PM +0200, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architect

Re: [PATCH 1/2] drm/amdgpu: Moved fault hash table to amdgpu vm

2018-09-12 Thread Christian König
Am 12.09.2018 um 17:29 schrieb Felix Kuehling: On 2018-09-12 02:56 AM, Christian König wrote: Am 12.09.2018 um 00:00 schrieb Felix Kuehling: On 2018-09-11 03:19 AM, Christian König wrote: Hi Felix, let me try to explain the problem on an example: 1. We have a running job which needs recovera

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Mauro Carvalho Chehab
Em Wed, 12 Sep 2018 17:08:52 +0200 Arnd Bergmann escreveu: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architectur

[PATCH] drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole

2018-09-12 Thread Michel Dänzer
From: Michel Dänzer The entries were only initialized once in amdgpu_sa_bo_new. If a fence wasn't signalled yet in the first amdgpu_sa_bo_next_hole call, but then got signalled before a later amdgpu_sa_bo_next_hole call, it could destroy the fence but leave its pointer in the array, resulting in

Re: [PATCH] drm/amdgpu: Initialize fences array entries in amdgpu_sa_bo_next_hole

2018-09-12 Thread Christian König
Am 12.09.2018 um 18:10 schrieb Michel Dänzer: From: Michel Dänzer The entries were only initialized once in amdgpu_sa_bo_new. If a fence wasn't signalled yet in the first amdgpu_sa_bo_next_hole call, but then got signalled before a later amdgpu_sa_bo_next_hole call, it could destroy the fence b

Re: [PATCH xf86-video-amdgpu 0/6] xf86-video-amdgpu integration for DRM variable refresh rate API

2018-09-12 Thread Michel Dänzer
On 2018-09-12 2:48 p.m., Kazlauskas, Nicholas wrote: > On 09/12/2018 04:13 AM, Michel Dänzer wrote: >> On 2018-09-11 6:18 p.m., Nicholas Kazlauskas wrote: >>> These patches are part of a proposed new interface for supporting >>> variable refresh rate via DRM properties. >>> >>> https://patchwork.fr

Re: [PATCH xf86-video-amdgpu 0/6] xf86-video-amdgpu integration for DRM variable refresh rate API

2018-09-12 Thread Kazlauskas, Nicholas
On 09/12/2018 12:22 PM, Michel Dänzer wrote: On 2018-09-12 2:48 p.m., Kazlauskas, Nicholas wrote: On 09/12/2018 04:13 AM, Michel Dänzer wrote: On 2018-09-11 6:18 p.m., Nicholas Kazlauskas wrote: These patches are part of a proposed new interface for supporting variable refresh rate via DRM pro

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-12 Thread Greg Kroah-Hartman
On Wed, Sep 12, 2018 at 05:08:52PM +0200, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architect

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-12 Thread Nick Desaulniers
On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor wrote: > > Clang warns if there are missing braces around a subobject > initializer. > > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:41: warning: suggest braces > around initialization of subobject [-Wmissing-braces] > struct amdgpu_

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-12 Thread Nathan Chancellor
On Wed, Sep 12, 2018 at 10:38:30AM -0700, Nick Desaulniers wrote: > On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor > wrote: > > > > Clang warns if there are missing braces around a subobject > > initializer. > > > > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1447:41: warning: suggest braces > > arou

Re: [PATCH] drm/amdgpu: Add braces to initialize task_info subojects

2018-09-12 Thread Alex Deucher
On Wed, Sep 12, 2018 at 2:40 PM Nathan Chancellor wrote: > > On Wed, Sep 12, 2018 at 10:38:30AM -0700, Nick Desaulniers wrote: > > On Tue, Sep 11, 2018 at 5:26 PM Nathan Chancellor > > wrote: > > > > > > Clang warns if there are missing braces around a subobject > > > initializer. > > > > > > dri

[PATCH 07/21] drm/amdgpu: add picasso ucode loading method

2018-09-12 Thread Alex Deucher
From: Likun Gao Same as raven. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm

[PATCH 02/21] drm/amdgpu: add soc15 support for picasso

2018-09-12 Thread Alex Deucher
From: Likun Gao Add the IP blocks, clock and powergating flags, and common clockgating support. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 ++- drivers/gpu/drm/amd/amdgpu/soc15

[PATCH 05/21] drm/amdgpu: Add support of powerplay for picasso

2018-09-12 Thread Alex Deucher
From: Likun Gao add powerplay support for picasso, treat it the same as raven now. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 1 + drivers/gpu/drm/amd/powerplay/hwmgr/proce

[PATCH 04/21] drm/amd/display/dm: add picasso support

2018-09-12 Thread Alex Deucher
From: Likun Gao Add support for picasso to the display manager. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 1 + drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++--

[PATCH 00/21] Add Picasso support

2018-09-12 Thread Alex Deucher
This patch set adds support for Picasso. Picasso is a new APU similar to raven. Alex Deucher (1): drm/amdgpu: use IP presence to free uvd and vce handles Huang Rui (2): drm/amdgpu: add ip blocks for picasso (v2) drm/amdgpu: add new raven series device Kenneth Feng (5): drm/amdgpu: Add p

[PATCH 01/21] drm/amdgpu: add picasso to asic_type enum

2018-09-12 Thread Alex Deucher
From: Likun Gao Add picasso to amd_asic_type enum and amdgpu_asic_name[]. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 + include/drm/amd_asic_type.h| 1 + 2 files cha

[PATCH 09/21] drm/amdgpu: add clockgating support for picasso

2018-09-12 Thread Alex Deucher
From: Likun Gao Treat it the same as raven for now. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/d

[PATCH 06/21] drm/amdgpu: initilize picasso psp firmwares support

2018-09-12 Thread Alex Deucher
From: Likun Gao Same as raven for now. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 1 + drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 4 2 files changed, 5 insertions(+) diff --git a/dr

[PATCH 10/21] drm/amdgpu: add picasso support for gmc

2018-09-12 Thread Alex Deucher
From: Likun Gao Same as raven. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c b/drivers/gpu/drm/amd

[PATCH 03/21] drm/amdgpu: add picasso support for vm

2018-09-12 Thread Alex Deucher
From: Likun Gao Add vm support for picasso. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amd

[PATCH 08/21] drm/amdgpu: add picasso support for vcn

2018-09-12 Thread Alex Deucher
From: Likun Gao Add vcn support for picasso. Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c b/

[PATCH 12/21] drm/amdgpu: add picasso support for sdma_v4

2018-09-12 Thread Alex Deucher
From: Likun Gao Add sdma support to picasso Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdg

[PATCH 19/21] drm/amdgpu: add new raven series device

2018-09-12 Thread Alex Deucher
From: Huang Rui This patch is to add new pci device for raven series. Signed-off-by: Huang Rui Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd

[PATCH 16/21] drm/amdgpu: enable mmhub power gating

2018-09-12 Thread Alex Deucher
From: Kenneth Feng Remove some functions due to the design change. All the mmhub power gating sequence is moved to smu fw.Driver sends the message to enable mmhub powergating.We can also skip the fw version check since the old fw version is in a very early stage and we don't use that fw for relea

[PATCH 20/21] drm/amdgpu: enable gfxoff in non-sriov and stutter mode by default

2018-09-12 Thread Alex Deucher
From: Kenneth Feng enable gfxoff in non-sriov and stutter mode by default Signed-off-by: Kenneth Feng Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c| 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff

[PATCH 18/21] drm/amdgpu: add ip blocks for picasso (v2)

2018-09-12 Thread Alex Deucher
From: Huang Rui Add PCO IPs. V2: enable VCN as well Signed-off-by: Huang Rui Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/amd/amd

[PATCH 11/21] drm/amdgpu: add picasso support for gfx_v9_0

2018-09-12 Thread Alex Deucher
From: Likun Gao Add gfx support to picasso Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/driv

[PATCH 14/21] drm/amdgpu: Add pg support for gfxoff for PCO

2018-09-12 Thread Alex Deucher
From: Kenneth Feng Add pg support for gfxoff. Signed-off-by: Kenneth Feng Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/am

[PATCH 13/21] drm/amdgpu: add picasso for amdgpu kms

2018-09-12 Thread Alex Deucher
From: Likun Gao Add picasso for amdgpu kms Signed-off-by: Likun Gao Reviewed-by: Alex Deucher Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH 21/21] drm/amdgpu: use IP presence to free uvd and vce handles

2018-09-12 Thread Alex Deucher
Rather than checking the asic type, check whether the UVD or VCE IP blocks exist. This way we don't have to update the check with new asics that use VCN. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 15/21] drm/amdgpu: Enable SDMA power gating for PCO

2018-09-12 Thread Alex Deucher
From: Kenneth Feng Enable SDMA power gating Signed-off-by: Kenneth Feng Acked-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c index

[PATCH 17/21] drm/amdgpu: enable vcn powergating for PCO

2018-09-12 Thread Alex Deucher
From: Kenneth Feng enable vcn pg Signed-off-by: Kenneth Feng Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c index 53159f1d7a39..7

Re: [PATCH] drm/amdgpu: use HMM mirror callback to replace mmu notifier

2018-09-12 Thread Felix Kuehling
Should we add HMM as a dependency in the Kconfig? At least for KFD functionality we depend on userptrs. Regards,   Felix On 2018-09-12 03:15 AM, Christian König wrote: > Am 11.09.2018 um 21:31 schrieb Philip Yang: >> Replace our MMU notifier with hmm_mirror_ops.sync_cpu_device_pagetables >> call

Re: [PATCH] drm/amdgpu: use HMM mirror callback to replace mmu notifier

2018-09-12 Thread Christian König
Yes, at least Jeromes original patch for amdgpu already did this. Christian. Am 12.09.2018 um 20:58 schrieb Felix Kuehling: Should we add HMM as a dependency in the Kconfig? At least for KFD functionality we depend on userptrs. Regards,   Felix On 2018-09-12 03:15 AM, Christian König wrote:

[PATCH] drm/ttm: once more fix ttm_bo_bulk_move_lru_tail

2018-09-12 Thread Christian König
While cutting the lists we sometimes accidentally added a list_head from the stack to the LRUs, effectively corrupting the list. Remove the list cutting and use explicit list manipulation instead. Signed-off-by: Christian König --- drivers/gpu/drm/ttm/ttm_bo.c | 51 ++---

[PATCH 00/16] Add support for Raven2

2018-09-12 Thread Alex Deucher
Raven2 is a new Raven APU. Alex Deucher (1): drm/amdgpu: set external rev id for raven2 Bhawanpreet Lakha (2): drm/amd/display: Add Raven2 definitions in dc drm/amd/display: Add DC config flag for Raven2 (v2) Evan Quan (3): drm/amd/powerplay: update smu10_verify_smc_interface() to be rav

[PATCH 08/16] drm/amdgpu/gfx9: add support for raven2 gfx firmware

2018-09-12 Thread Alex Deucher
From: Feifei Xu use raven2 gfx firmware. Signed-off-by: Feifei Xu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/

[PATCH 12/16] drm/amd/display: Add DC config flag for Raven2 (v2)

2018-09-12 Thread Alex Deucher
From: Bhawanpreet Lakha Add DRM_AMD_DC_DCN1_01 config flag for Raven2 v2: Make DC select DRM_AMD_DC_DCN1_01 (Alex) Signed-off-by: Bhawanpreet Lakha Reviewed-by: Harry Wentland Reviewed-by: Huang Rui Acked-by: Alex Deucher --- drivers/gpu/drm/amd/display/Kconfig | 6 ++ 1 file changed,

[PATCH 09/16] drm/amdgpu/gfx9: add raven2 golden setting

2018-09-12 Thread Alex Deucher
From: Feifei Xu Golden register settings from the hw team. Signed-off-by: Feifei Xu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 40 ++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/drivers/

[PATCH 02/16] drm/amdgpu: set external rev id for raven2

2018-09-12 Thread Alex Deucher
It's different from raven1. Signed-off-by: Huang Rui Reviewed-by: Feifei Xu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c index

[PATCH 04/16] drm/amdgpu: add raven2 vcn firmware support

2018-09-12 Thread Alex Deucher
From: Feifei Xu Specify raven2 vcn firmware on amdgpu_vce_sw_init. Signed-off-by: Feifei Xu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/a

[PATCH 06/16] drm/amdgpu/sdma4: specify raven2 firmware.

2018-09-12 Thread Alex Deucher
From: Feifei Xu use raven2 sdma firmware. Signed-off-by: Feifei Xu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/d

[PATCH 03/16] drm/amdgpu: add raven2 to gpu_info firmware

2018-09-12 Thread Alex Deucher
From: Feifei Xu Add gpu_info firmware for raven2. Signed-off-by: Feifei Xu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 05/16] drm/amdgpu: add psp support for raven2

2018-09-12 Thread Alex Deucher
From: Likun Gao Modified for using raven2_asd.bin to replace raven_asd.bin for raven2 Signed-off-by: Likun Gao Reviewed-by: Huang Rui Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/psp_v10_0.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/dr

[PATCH 01/16] drm/amdgpu: move get_rev_id at first before load gpu_info firmware

2018-09-12 Thread Alex Deucher
From: Huang Rui Rev id is used for identifying Raven2 series of chips. So we would better to initialize it at first. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/soc15.c | 13 +++-- 1 file

[PATCH 07/16] drm/amdgpu/sdma4: Add raven2 golden setting

2018-09-12 Thread Alex Deucher
From: Feifei Xu Golden register settings from the hw team. Signed-off-by: Feifei Xu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/

[PATCH 13/16] drm/amd/powerplay: update smu10_verify_smc_interface() to be raven2 compatible

2018-09-12 Thread Alex Deucher
From: Evan Quan Check the raven2 version number as well. Signed-off-by: Evan Quan Reviewed-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH 14/16] drm/amd/powerplay: round up the Mhz convertion (v2)

2018-09-12 Thread Alex Deucher
From: Evan Quan Since the clock value there may be like 2 10Khz. v2: rebase (Alex) Signed-off-by: Evan Quan Reviewed-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 10 -- 1 file changed, 8 insertions(+

[PATCH 11/16] drm/amd/display: Add Raven2 definitions in dc

2018-09-12 Thread Alex Deucher
From: Bhawanpreet Lakha Add Raven2 definitions in the dc code Signed-off-by: Bhawanpreet Lakha Reviewed-by: Harry Wentland Reviewed-by: Huang Rui Acked-by: Alex Deucher --- .../amd/display/dc/bios/command_table_helper2.c| 5 +++ drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 7 +

[PATCH 15/16] drm/amd/powerplay: disable raven2 force dpm level support (v2)

2018-09-12 Thread Alex Deucher
From: Evan Quan It's not supported yet. v2: rebase (Alex) Signed-off-by: Evan Quan Reviewed-by: Rex Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu10_hwmgr

[PATCH 10/16] drm/amdgpu: fix the VM fault while write at the top of the invisible vram

2018-09-12 Thread Alex Deucher
From: Huang Rui Raven2 has a HW issue that it is unable to use the vram which is out of MC_VM_SYSTEM_APERTURE_HIGH_ADDR. So here is the workaround that increase system aperture high address to get rid of the VM fault and hardware hang. Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Reviewe

  1   2   >