Hi
Is there an updated series? These no longer apply for me
Thanks
Mike
On Wed, 22 Aug 2018 at 09:42 Huang Rui wrote:
> On Wed, Aug 22, 2018 at 04:24:02PM +0800, Christian König wrote:
> > Please commit patches #1, #2 and #3, doesn't make much sense to send
> > them out even more often.
> >
>
On Fri, Aug 31, 2018 at 10:07:42AM +0100, Chris Wilson wrote:
[...]
> Ahah, someone is looking at remove_conflicting_framebuffers(). May I
> interest you in a use-after-free?
> [ 378.423513] stack segment: [#1] PREEMPT SMP PTI
> [ 378.423530] CPU: 1 PID: 4338 Comm: pm_rpm Tainted: G U
Signed-off-by: Michał Mirosław
Acked-by: Alex Deucher
Acked-by: Daniel Vetter
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 24 +---
1 file changed, 1 insertion(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv
This series cleans up duplicated code for replacing firmware FB
driver with proper DRI driver and adds handover support to
Tegra driver.
This is a sligtly updated version of a series sent on 24 Nov 2017.
---
v2:
- rebased on current drm-next
- dropped staging/sm750fb changes
- added kernel doc
Signed-off-by: Michał Mirosław
Acked-by: Bartlomiej Zolnierkiewicz
Acked-by: Daniel Vetter
---
drivers/video/fbdev/core/fbmem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index f741ba8df01b..30a18d4
Signed-off-by: Michał Mirosław
Acked-by: Daniel Vetter
---
drivers/gpu/drm/bochs/bochs_drv.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/bochs/bochs_drv.c
b/drivers/gpu/drm/bochs/bochs_drv.c
index 7b20318483e4..c61b40c72b62 100644
--- a
Signed-off-by: Michał Mirosław
Acked-by: Daniel Vetter
---
drivers/gpu/drm/cirrus/cirrus_drv.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/cirrus/cirrus_drv.c
b/drivers/gpu/drm/cirrus/cirrus_drv.c
index 69c4e352dd78..85ed8657c862 1
Use remove_conflicting_framebuffers(NULL) instead of duplicating it.
Signed-off-by: Michał Mirosław
Acked-by: Maxime Ripard
Acked-by: Daniel Vetter
---
drivers/gpu/drm/sun4i/sun4i_drv.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/sun4i
Interpret (otherwise-invalid) NULL apertures argument to mean all-memory
range. This will allow to remove several duplicates of this code
from drivers in following patches.
Signed-off-by: Michał Mirosław
Acked-by: Bartlomiej Zolnierkiewicz
---
v2: added kerneldoc to corresponding DRM helper
v3:
Signed-off-by: Michał Mirosław
Acked-by: Daniel Vetter
---
drivers/gpu/drm/virtio/virtgpu_drm_bus.c | 24 +++-
1 file changed, 3 insertions(+), 21 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_drm_bus.c
b/drivers/gpu/drm/virtio/virtgpu_drm_bus.c
index 7df8d0c9026
Kick out firmware fb when loading Tegra driver.
Signed-off-by: Michał Mirosław
Acked-by: Daniel Vetter
---
drivers/gpu/drm/tegra/drm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/tegra/drm.c b/drivers/gpu/drm/tegra/drm.c
index 7afe2f635f74..b51ec138fed2 100644
--- a/
Remove duplicated call, while at it.
Signed-off-by: Michał Mirosław
Acked-by: Daniel Vetter
---
drivers/gpu/drm/mgag200/mgag200_drv.c | 21 +
drivers/gpu/drm/mgag200/mgag200_main.c | 9 -
2 files changed, 1 insertion(+), 29 deletions(-)
diff --git a/drivers/gpu/dr
Signed-off-by: Michał Mirosław
Acked-by: Alex Deucher
Acked-by: Daniel Vetter
---
drivers/gpu/drm/radeon/radeon_drv.c | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_drv.c
b/drivers/gpu/drm/radeon/radeon_drv.c
index b282
Use remove_conflicting_framebuffers(NULL) instead of open-coding it.
Signed-off-by: Michał Mirosław
Acked-by: Eric Anholt
Acked-by: Daniel Vetter
---
drivers/gpu/drm/vc4/vc4_drv.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/drivers/gpu/drm/vc4/vc4_d
Almost all PCI drivers using remove_conflicting_framebuffers() wrap it
with the same code.
---
v2: add kerneldoc for DRM helper
v3: propagate remove_conflicting_framebuffers() return value
+ move kerneldoc to where function is implemented
Signed-off-by: Michał Mirosław
---
drivers/video/fbdev
Document remove_conflicting_framebuffers() behaviour.
Signed-off-by: Michał Mirosław
---
drivers/video/fbdev/core/fbmem.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index 0df148eb4699..2de93b5014e3 100644
--
On Fri, Aug 31, 2018 at 11:32 AM Christian König
wrote:
>
> Am 31.08.2018 um 17:27 schrieb Emil Velikov:
> > On 31 August 2018 at 15:38, Michel Dänzer wrote:
> >> [ Adding the amd-gfx list ]
> >>
> >> On 2018-08-31 3:05 p.m., Thomas Hellstrom wrote:
> >>> On 08/31/2018 02:30 PM, Emil Velikov wrot
On Fri, Aug 31, 2018 at 4:20 AM Christian König
wrote:
>
> Am 30.08.2018 um 16:53 schrieb Alex Deucher:
> > No functional change, just rework it in order to adjust the
> > behavior on a per asic level. The problem is that on vega10,
> > something corrupts the lower 8 MB of vram on the second
> >
On Fri, Aug 31, 2018 at 6:45 AM Michel Dänzer wrote:
>
> From: Michel Dänzer
>
> The crtc->gamma_lut values aren't initialized yet at this point, and
> the property values are pushed again from drmmode_setup_colormap
> anyway.
>
> Fixes intermittent flicker due to random gamma LUT values during s
That one is already committed to amd-staging-drm-next.
But I've fixed a few bugs with that just yesterday, not sure if the public copy
of amd-staging-drm-next is already up to date.
Christian.
Am 02.09.2018 10:12 schrieb Mike Lothian :
Hi
Is there an updated series? These no longer apply for m
On 09/01/2018 04:58 PM, Deng, Emily wrote:
Ok, then just ignore this patch. But seems didn't saw the patch on branch
amd-staging-hybrid-master20180315.
Thanks to take care of this as well.
I'm waiting some verification, and now push the patch to internal staging branch
mainline will be pushed
On 08/31/2018 09:10 PM, Christian König wrote:
First step to fix the LRU corruption, we accidentially tried to move things
on the LRU after dropping the lock.
Signed-off-by: Christian König
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 5 ++---
1 file changed, 2
On 08/31/2018 09:10 PM, Christian König wrote:
Staring at the function for six hours, just to essentially move one line
of code.
Signed-off-by: Christian König
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/ttm/ttm_bo.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
On 09/02/2018 02:05 AM, Christian König wrote:
Allows us to avoid taking the spinlock in more places.
Signed-off-by: Christian König
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 67 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 7 +
On 08/31/2018 09:27 PM, Christian König wrote:
amdgpu_vm_bo_* functions should come much later.
Signed-off-by: Christian König
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 90 +-
1 file changed, 45 insertions(+), 45 deletions(-)
On 09/02/2018 02:05 AM, Christian König wrote:
Since we have a lot of FAQ on the VM state machine try to improve the
documentation by adding functions for each state move.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 139 +
1 fil
On 09/02/2018 02:05 AM, Christian König wrote:
amdgpu_vm_bo_* functions should come much later.
Signed-off-by: Christian König
Reviewed-by: Junwei Zhang
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 90 +-
1 file changed, 45 insertions(+), 45 deletions(-)
在 2018/8/30 19:32, Christian König 写道:
[SNIP]
+
+struct drm_syncobj_wait_pt {
+ struct drm_syncobj_stub_fence base;
+ u64 value;
+ struct rb_node node;
+};
+struct drm_syncobj_signal_pt {
+ struct drm_syncobj_stub_fence base;
+ struct dma_fence *signal_fence;
+ struct
For Pro OGL be able to work with upstream libdrm.
Signed-off-by: Qiang Yu
Reviewed-by: Christian König
---
amdgpu/amdgpu-symbol-check | 1 +
amdgpu/amdgpu.h| 15 ++-
amdgpu/amdgpu_bo.c | 6 ++
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/a
29 matches
Mail list logo
