Re: [PATCH 3/3] drm/amdgpu: move cache window setup after power and clock resume

Looks like the patches should be reordered, e.g. patch #2 should be the last. Apart from that Reviewed-by: Christian König . Regards, Christian. Am 09.07.2018 um 18:54 schrieb Deucher, Alexander: Series is: Reviewed-by: Alex Deucher

Re: [PATCH 01/54] Revert "drm/amd/display: Don't return ddc result and read_bytes in same return value"

On 2018-07-10 02:36 AM, Harry Wentland wrote: > This reverts commit 8a61bc085ffab3071c59efcbeff4044c034e7490. A revert commit needs a rationale (why did the commit need to be reverted?) in the commit log. Since this same change went into 4.17 as commit 018d82e5f02ef3583411bcaa4e00c69786f46f19, p

答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

Hi Takashi, I am not expert in audio driver, so I just update some test result, please help triage the issue. With audio runtime pm: 1. ubuntu audio setting use pactl to query audio card/output sink. Attachment is pactl output with audio runtime pm. 2. cat /proc/asound/card0/eld* can get nothi

答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

Sorry, correct the typo. IMO, the issue should be: Current operations like HDMI hotplug in/out, pactl command, they do not access audio HW, so the audio could not resume back at this period. Therefore, upper software could not get HDMI ELD info, it can not select an available card/output sink.

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

On Tue, 10 Jul 2018 09:44:42 +0200, Qu, Jim wrote: > > Hi Takashi, > > I am not expert in audio driver, so I just update some test result, please > help triage the issue. > > With audio runtime pm: What does this mean? Is it the stock 4.17.x (or 4.18-rc)? Please clarify your test environment

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

On 2018年07月10日 16:01, Takashi Iwai wrote: On Tue, 10 Jul 2018 09:44:42 +0200, Qu, Jim wrote: Hi Takashi, I am not expert in audio driver, so I just update some test result, please help triage the issue. With audio runtime pm: What does this mean? Is it the stock 4.17.x (or 4.18-rc)? Pleas

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

On Tue, 10 Jul 2018 11:13:27 +0200, jimqu wrote: > > > > On 2018年07月10日 16:01, Takashi Iwai wrote: > > On Tue, 10 Jul 2018 09:44:42 +0200, > > Qu, Jim wrote: > >> Hi Takashi, > >> > >> I am not expert in audio driver, so I just update some test result, please > >> help triage the issue. > >> >

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

On 2018年07月10日 17:50, Takashi Iwai wrote: On Tue, 10 Jul 2018 11:13:27 +0200, jimqu wrote: On 2018年07月10日 16:01, Takashi Iwai wrote: On Tue, 10 Jul 2018 09:44:42 +0200, Qu, Jim wrote: Hi Takashi, I am not expert in audio driver, so I just update some test result, please help triage the i

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

On Tue, 10 Jul 2018 13:11:20 +0200, jimqu wrote: > > > > On 2018年07月10日 17:50, Takashi Iwai wrote: > > On Tue, 10 Jul 2018 11:13:27 +0200, > > jimqu wrote: > >> > >> > >> On 2018年07月10日 16:01, Takashi Iwai wrote: > >>> On Tue, 10 Jul 2018 09:44:42 +0200, > >>> Qu, Jim wrote: > Hi Takashi, >

Re: [PATCH 38/54] drm/amd/display: Expose bunch of functions from dcn10_hw_sequencer

On 2018-07-10 12:56 AM, Dave Airlie wrote: > This has some whitespace changes that don't seem to be related, please > get people to be a bit more careful. > > (though I do realise this could be magic ifdef stuff that got ripped out :-) > It's the latter. I'm running "unifdef -B" which should com

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > This is the v2 of RFC based on the feedback I've received so far. The > > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly > > because I have no idea how. > > >

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > This is the v2 of RFC based on the feedback I've received so far. The > > > code even compiles as a bonus ;) I haven't runtime tes

[PATCH v2] Revert "drm/amd/display: Don't return ddc result and read_bytes in same return value"

This reverts commit 8a61bc085ffab3071c59efcbeff4044c034e7490. Need to revert "make dm_dp_aux_transfer return payload bytes instead of size", which this commit is based on. That commit was problematic on other OSes. The real solution is to leave all the error checking to DRM and don't do it in DC,

[PATCH v2] Revert "drm/amd/display: make dm_dp_aux_transfer return payload bytes instead of size"

This reverts commit cc195141133ac3e767d930bedd8294ceebf1f10b. This commit was problematic on other OSes. The real solution is to leave all the error checking to DRM and don't do it in DC, which is addressed by "Return aux replies directly to DRM" later in this patchset. v2: Add reason for revert.

[PATCH v2] drm/amd/display: Expose bunch of functions from dcn10_hw_sequencer

From: Eric Bernstein v2: Remove spurious newline changes Signed-off-by: Eric Bernstein Reviewed-by: Dmytro Laktyushkin Acked-by: Harry Wentland --- .../amd/display/dc/dcn10/dcn10_hw_sequencer.c | 59 +++ .../amd/display/dc/dcn10/dcn10_hw_sequencer.h | 7 +++ .../gpu/drm/amd/

[PATCH v2] drm/amd/display: dp debugfs allow link rate lane count greater than dp rx reported caps

From: Hersen Wu [Why] when hw team does phy parameters tuning, there is need to force dp link rate or lane count grater than the values from dp receiver to check dp tx. current debufs limit link rate, lane count no more than rx caps. [How] remove force settings less than rx caps check v2: Fix t

[PATCH xf86-video-ati] Swap pixmap privates in radeon_dri2_exchange_buffers

From: Michel Dänzer Instead of only the BOs. This matches what amdgpu does, and fixes issues with DRI2 page flipping. Signed-off-by: Michel Dänzer --- src/radeon_dri2.c | 42 +++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/src/radeon_

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > > This is the v2 of RFC based on the feedback I've received so

[PATCH xf86-video-amdgpu 3/3] Move flush from radeon_scanout_do_update to its callers

From: Michel Dänzer No functional change intended. Reviewed-by: Alex Deucher (Ported from radeon commit 90b94d40449f665f2d12874598062a5e5e5b64cd) Signed-off-by: Michel Dänzer --- src/amdgpu_kms.c | 8 +--- src/drmmode_display.c | 1 + 2 files changed, 6 insertions(+), 3 deletions(-)

[PATCH xf86-video-amdgpu 2/3] glamor: Bail CreatePixmap on unsupported pixmap depth

From: Michel Dänzer Fixes crash in that case. Bugzilla: https://bugs.freedesktop.org/106293 (Ported from radeon commit 65c9dfea4e841b7d6f795c7489fede58c5e9631f) Signed-off-by: Michel Dänzer --- src/amdgpu_glamor.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amdgpu_glamor.c b/sr

[PATCH xf86-video-amdgpu 1/3] Bail from dri2_create_buffer2 if we can't get a pixmap

From: Michel Dänzer We would store the NULL pointer and continue, which would lead to a crash down the road. Bugzilla: https://bugs.freedesktop.org/106293 (Ported from radeon commit 3dcfce8d0f495d09d7836caf98ef30d625b78a13) Signed-off-by: Michel Dänzer --- src/amdgpu_dri2.c | 26 -

[PATCH] drm/amd/pp: fix semicolon.cocci warnings

From: kbuild test robot drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c:1209:17-18: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: ea870e44415a ("drm/amd/pp: Export notify_smu_enable_pwe to display") CC: Rex Zhu Signed-off

Re: [PATCH xf86-video-ati] Swap pixmap privates in radeon_dri2_exchange_buffers

On Tue, Jul 10, 2018 at 11:24 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Instead of only the BOs. > > This matches what amdgpu does, and fixes issues with DRI2 page flipping. > > Signed-off-by: Michel Dänzer Reviewed-by: Alex Deucher > --- > src/radeon_dri2.c | 42 +++

Re: [PATCH xf86-video-amdgpu 3/3] Move flush from radeon_scanout_do_update to its callers

On Tue, Jul 10, 2018 at 12:34 PM, Michel Dänzer wrote: > From: Michel Dänzer > > No functional change intended. > > Reviewed-by: Alex Deucher > (Ported from radeon commit 90b94d40449f665f2d12874598062a5e5e5b64cd) Series is: Reviewed-by: Alex Deucher > > Signed-off-by: Michel Dänzer > --- >

Re: [PATCH 02/10] drm/amdgpu: init CSIB regardless of rlc version and pg status

On Sun, Jul 8, 2018 at 11:56 PM, Quan, Evan wrote: > Ping.. > >> -Original Message- >> From: Evan Quan [mailto:evan.q...@amd.com] >> Sent: Thursday, July 05, 2018 5:09 PM >> To: amd-gfx@lists.freedesktop.org >> Cc: Quan, Evan >> Subject: [PATCH 02/10] drm/amdgpu: init CSIB regardless of r

Re: [PATCH 06/10] drm/amdgpu: no touch for the reserved bit of RLC_CGTT_MGCG_OVERRIDE

On Mon, Jul 9, 2018 at 12:06 AM, Quan, Evan wrote: > Ping.. > >> -Original Message- >> From: Evan Quan [mailto:evan.q...@amd.com] >> Sent: Thursday, July 05, 2018 5:10 PM >> To: amd-gfx@lists.freedesktop.org >> Cc: Quan, Evan >> Subject: [PATCH 06/10] drm/amdgpu: no touch for the reserved

Re: [PATCH 07/10] drm/amdgpu: reduce the idle period that RLC has to wait before request CGCG

On Mon, Jul 9, 2018 at 12:06 AM, Quan, Evan wrote: > Ping.. > >> -Original Message- >> From: Evan Quan [mailto:evan.q...@amd.com] >> Sent: Thursday, July 05, 2018 5:10 PM >> To: amd-gfx@lists.freedesktop.org >> Cc: Quan, Evan >> Subject: [PATCH 07/10] drm/amdgpu: reduce the idle period th

Re: [PATCH 08/10] drm/amdgpu: use the accessible target rlc safe mode Apis directly

On Mon, Jul 9, 2018 at 12:08 AM, Quan, Evan wrote: > Ping.. > >> -Original Message- >> From: Evan Quan [mailto:evan.q...@amd.com] >> Sent: Thursday, July 05, 2018 5:10 PM >> To: amd-gfx@lists.freedesktop.org >> Cc: Quan, Evan >> Subject: [PATCH 08/10] drm/amdgpu: use the accessible target

Re: [PATCH 10/10] drm/amd/powerplay: no need to mask workable gfxoff feature for vega12

On Mon, Jul 9, 2018 at 12:36 AM, Quan, Evan wrote: > Ping.. > >> -Original Message- >> From: Evan Quan [mailto:evan.q...@amd.com] >> Sent: Thursday, July 05, 2018 5:10 PM >> To: amd-gfx@lists.freedesktop.org >> Cc: Quan, Evan >> Subject: [PATCH 10/10] drm/amd/powerplay: no need to mask wo

[PATCH] Revert "drm/amd/display: Don't return ddc result and read_bytes in same return value"

This reverts commit 018d82e5f02ef3583411bcaa4e00c69786f46f19. This breaks DDC in certain cases. Revert for 4.18 and previous kernels. For 4.19, this is fixed with the following more extensive patches: drm/amd/display: Serialize is_dp_sink_present drm/amd/display: Break out function to simply read

Re: [PATCH] drm/amd/pp: fix semicolon.cocci warnings

On Tue, Jul 10, 2018 at 1:11 PM, kbuild test robot wrote: > From: kbuild test robot > > drivers/gpu/drm/amd/amdgpu/../powerplay/amd_powerplay.c:1209:17-18: Unneeded > semicolon > > > Remove unneeded semicolon. > > Generated by: scripts/coccinelle/misc/semicolon.cocci > > Fixes: ea870e44415a ("d

Re: [PATCH] Revert "drm/amd/display: Don't return ddc result and read_bytes in same return value"

On 2018-07-10 02:06 PM, Alex Deucher wrote: > This reverts commit 018d82e5f02ef3583411bcaa4e00c69786f46f19. > > This breaks DDC in certain cases. Revert for 4.18 and previous kernels. > For 4.19, this is fixed with the following more extensive patches: > drm/amd/display: Serialize is_dp_sink_pres

Re: BUG: *ERROR* No EDID read

On Fri, Jul 6, 2018 at 12:44 PM, Daniel Andersson wrote: > Alright, I redid the bisect and this time ended up on > 018d82e5f02ef3583411bcaa4e00c69786f46f19 . If I revert it, it fixes my > issue. Reverting it on 4.18-rc2 also works. I've gone ahead and reverted the patch. Thanks, Alex > > // Da

[PATCH] drm/amdgpu/vi: fix mixed up state in smu clockgating setup

Use the PP_STATE_SUPPORT_* rather than AMD_CG_SUPPORT_* when communicating with the SMU. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/vi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/v

Re: Regression with kernel 4.18 - AMD RX 550 fails IB ring test on power-up

Hi, Issue remains in kernel 4.18-rc4 using SAPPHIRE RX 550 4GB. Logs follow attached. Regards, Luis On Tue, Jun 26, 2018 at 10:08 AM, Luís Mendes wrote: > Hi, > > I've tried kernel 4.18-rc2 on a system with a NVIDIA GTX 1050 Ti and an > AMD RX 550 4GB and the RX 550 card is failing the IB rin

Re: GPU hang trying to run OpenCL kernels on x86_64

Hi, Issue remains in kernel 4.17.5, tested with SAPPHIRE RX 550 4GB running same OpenCL kernel. [ 227.443025] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring sdma0 timeout, last signaled seq=22, last emitted seq=25 [ 227.443112] [drm:amdgpu_job_timedout [amdgpu]] *ERROR* ring sdma1 timeout, las

答复: Regression with kernel 4.18 - AMD RX 550 fails IB ring test on power-up

Hi Luis, 1. May you also test earlier kernel? v4.17 or v4.16. 2. May you test the issue only with amdgpu? Thanks JimQu 发件人: amd-gfx 代表 Luís Mendes 发送时间: 2018年7月11日 6:04:00 收件人: Michel Dänzer; Koenig, Christian; amd-gfx list 主题: Re: Regression with kern

RE: [PATCH 08/10] drm/amdgpu: use the accessible target rlc safe mode Apis directly

Ok, I will drop this patch. Regards, Evan > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Wednesday, July 11, 2018 1:24 AM > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 08/10] drm/amdgpu: use the accessible target rlc safe > mo

RE: [PATCH 07/10] drm/amdgpu: reduce the idle period that RLC has to wait before request CGCG

Yes, Rv gfxoff is not affected. Regards, Evan > -Original Message- > From: Alex Deucher [mailto:alexdeuc...@gmail.com] > Sent: Wednesday, July 11, 2018 1:20 AM > To: Quan, Evan > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 07/10] drm/amdgpu: reduce the idle period that RLC has