[PATCH 1/2] drm/amd/pp: Fix function parameter not correct

2018-03-13 Thread Rex Zhu
caused by "commit dcefb7668e5b4fb56099b16d1790cd3056322b03" Change-Id: I6ed04a5a5ddfedc64a143f12d6ef6a7b9f7f9760 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/smumgr/smu10_smumgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/sm

[PATCH 2/2] drm/amdgpu: Fix suspend hang on RV

2018-03-13 Thread Rex Zhu
1. ip_block's index should not compared to type. 2. Add null function point check Change-Id: Idbef9e5c69beef631e1e18cbc6f8c40cfe44862c Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/a

RE: [PATCH 2/2] drm/amdgpu: Fix suspend hang on RV

2018-03-13 Thread Quan, Evan
Reviewed-by: Evan Quan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Tuesday, March 13, 2018 3:01 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 2/2] drm/amdgpu: Fix suspend hang on RV 1. ip_block's index s

RE: [PATCH 1/2] drm/amd/pp: Fix function parameter not correct

2018-03-13 Thread Quan, Evan
Reviewed-by: Evan Quan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Tuesday, March 13, 2018 3:01 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 1/2] drm/amd/pp: Fix function parameter not correct caused by

Re: [PATCH] drm/amdgpu: Plus NULL function pointer check

2018-03-13 Thread Christian König
Am 13.03.2018 um 06:07 schrieb Rex Zhu: Change-Id: Ifd6553646e7468bc935504075816074373e1d58d Signed-off-by: Rex Zhu Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu

[PATCH 1/5] drm/amd/pp: Delete dead code on cz_clockpowergating.c

2018-03-13 Thread Rex Zhu
Change-Id: Ia4a121435c4860b1703d3647ef7220ee97f52d03 Signed-off-by: Rex Zhu --- .../drm/amd/powerplay/hwmgr/cz_clockpowergating.c | 78 -- .../drm/amd/powerplay/hwmgr/cz_clockpowergating.h | 3 - 2 files changed, 81 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/h

[PATCH 2/5] drm/amd/pp: Remove dead header file pp_asicblocks.h

2018-03-13 Thread Rex Zhu
Change-Id: If3d78436df312a7d2f0da629f9ea4a8d3ba462c7 Signed-off-by: Rex Zhu --- .../amd/powerplay/hwmgr/smu7_clockpowergating.h| 1 - drivers/gpu/drm/amd/powerplay/inc/pp_asicblocks.h | 47 -- 2 files changed, 48 deletions(-) delete mode 100644 drivers/gpu/drm/amd/power

[PATCH 4/5] drm/amd/pp: Remove unneeded void * casts in cz_hwmgr.c/cz_smumgr.c

2018-03-13 Thread Rex Zhu
Removes unneeded void * casts for the following pointers: hwmgr->backend hwmgr->smu_backend Change-Id: I6d56858625c58433cd5a35fc03e3aa6003a6e449 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 86 drivers/gpu/drm/amd/powerplay/smumgr/cz_smum

[PATCH 3/5] drm/amd/pp: Mv cz uvd/vce pg/dpm functions to cz_hwmgr.c

2018-03-13 Thread Rex Zhu
1. delete cz_clockpowergating.c/.h files 2. make uvd/vce dpm/pg functions static Change-Id: I605e0121823a3dd10f9e970ebc90ac26b7fddae7 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/Makefile | 2 +- .../drm/amd/powerplay/hwmgr/cz_clockpowergating.c | 131 ---

Re: [PATCH] drm/amd/display: Check msg->size before starting aux transfer

2018-03-13 Thread Harry Wentland
On 2018-03-13 02:28 AM, Shirish S wrote: > This patch adds an essential check related to the size of the > payload to be transferred via aux channel. > > Without this check dal_ddc_service_read_dpcd_data() is fed with > inappropriate payload size leading to deadlocks. > > Signed-off-by: Shirish S

[PATCH][next] drm/amd/pp: remove redundant pointer internal_buf

2018-03-13 Thread Colin King
From: Colin Ian King The pointer internal_buf is assigned a value but the pointer is never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/gpu/drm/amd/amdgpu/../powerplay/smumgr/smu7_smumgr.c:630:2: warning: Value stored to 'internal_buf' is never read Signed-of

Re: [PATCH 2/2] drm/amdgpu: Fix suspend hang on RV

2018-03-13 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Quan, Evan Sent: Tuesday, March 13, 2018 3:30:26 AM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: RE: [PATCH 2/2] drm/amdgpu: Fix suspend hang on RV Reviewed-by: Evan Quan -

Re: [PATCH] drm/amdgpu: Plus NULL function pointer check

2018-03-13 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Tuesday, March 13, 2018 1:07:29 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH] drm/amdgpu: Plus NULL function pointer check Change-Id: Ifd6553646e7468bc935504075816074373e1d

Re: [PATCH 1/5] drm/amd/pp: Delete dead code on cz_clockpowergating.c

2018-03-13 Thread Deucher, Alexander
Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Tuesday, March 13, 2018 6:01 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 1/5] drm/amd/pp: Delete dead code on cz_clockpowergating.c Change-Id: Ia4a121435c4860b17

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-13 Thread Daniel Vetter
On Mon, Mar 12, 2018 at 08:13:15PM +0100, Christian K??nig wrote: > Am 12.03.2018 um 18:07 schrieb Daniel Vetter: > > On Fri, Mar 09, 2018 at 08:11:41PM +0100, Christian K??nig wrote: > > > [SNIP] > > > +/** > > > + * dma_buf_invalidate_mappings - invalidate all mappings of this dma_buf > > > + * >

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-13 Thread Christian König
Am 13.03.2018 um 16:17 schrieb Daniel Vetter: [SNIP] I think a helper which both unmaps _and_ waits for all the fences to clear would be best, with some guarantees that it'll either fail or all the mappings _will_ be gone. The locking for that one will be hilarious, since we need to figure out d

Re: [PATCH 1/4] drm/amd/pp: Move helper functions to smu_help.c

2018-03-13 Thread Alex Deucher
On Mon, Mar 12, 2018 at 8:34 AM, Rex Zhu wrote: > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH 4/4] drm/amdgpu: Call amdgpu_ucode_fini_bo in amd_powerplay.c

2018-03-13 Thread Alex Deucher
On Mon, Mar 12, 2018 at 8:34 AM, Rex Zhu wrote: > make it symmetric with the init bo in amd_powerplay.c > > refine the "commit b22558bb4ff8fc9fe925222f90297d7a03a5fb20" > > Change-Id: I0bca00fa2a376cf6539b046eefff2ca3d30c3cae > Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher > --- > drivers

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-13 Thread Daniel Vetter
On Tue, Mar 13, 2018 at 04:52:02PM +0100, Christian König wrote: > Am 13.03.2018 um 16:17 schrieb Daniel Vetter: > > [SNIP] > > > > I think a helper which both unmaps _and_ waits for all the fences to > > > > clear > > > > would be best, with some guarantees that it'll either fail or all the > > >

Re: [PATCH 3/4] drm/amdgpu: Remove wrapper layer of amdgpu_powerplay

2018-03-13 Thread Alex Deucher
On Mon, Mar 12, 2018 at 8:34 AM, Rex Zhu wrote: > delete struct pp_instance, > make struct hwmgr as the smu hw context. > > Change-Id: I444aabe20477fc2fc1288542d45bf887d45bf0cd > Signed-off-by: Rex Zhu > --- > drivers/gpu/drm/amd/amdgpu/Makefile | 3 +- > drivers/gpu/drm/amd/amdgpu

Re: [PATCH 1/4] dma-buf: add optional invalidate_mappings callback

2018-03-13 Thread Christian König
Am 13.03.2018 um 17:00 schrieb Daniel Vetter: On Tue, Mar 13, 2018 at 04:52:02PM +0100, Christian König wrote: Am 13.03.2018 um 16:17 schrieb Daniel Vetter: [SNIP] Ok, so plan is to support fully pipeline moves and everything, with the old sg tables lazily cleaned up. I was thinking more about

[PATCH] drm/amd/display: Fix DCN build breakage

2018-03-13 Thread Harry Wentland
Fixes: 680acc64120c (drm/amd/display: Set disp clk in a safe way to avoid over high dpp clk.) Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c b/drivers/gpu/drm

Re: [PATCH] drm/amd/display: Fix DCN build breakage

2018-03-13 Thread Deucher, Alexander
Reviewed-by: Alex Deucher From: amd-gfx on behalf of Harry Wentland Sent: Tuesday, March 13, 2018 3:31:40 PM To: amd-gfx@lists.freedesktop.org Cc: Wentland, Harry Subject: [PATCH] drm/amd/display: Fix DCN build breakage Fixes: 680acc64120c (drm/amd/display: Se

Re: [PATCH] drm/amd/display: Fix DCN build breakage

2018-03-13 Thread Mike Lothian
On Tue, 13 Mar 2018 at 19:32 Harry Wentland wrote: > Fixes: 680acc64120c (drm/amd/display: Set disp clk in a safe way to avoid > over high dpp clk.) > > Signed-off-by: Harry Wentland > --- > drivers/gpu/drm/amd/display/dc/dce/dce_clocks.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[PATCH 3/3] drm/amdgpu/sdma4: Remove unused header file from sdma_v4_0.c

2018-03-13 Thread Alex Deucher
From: Feifei Xu Remove mmhub header files inclusion which not used. Signed-off-by: Feifei Xu Reviewed-by: Christian König Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd

[PATCH 2/3] drm/amdgpu/sdma4: use num_instances for clock/powergating config

2018-03-13 Thread Alex Deucher
Rather then relying on the asic type for the second instance. Makes it more consistent with the rest of the code. Signed-off-by: Alex Deucher Reviewed-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu

[PATCH 1/3] drm/amdgpu: remove trailing whitespace from soc15ip.h

2018-03-13 Thread Alex Deucher
no intended functional change. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/vega10_ip_offset.h | 286 - 1 file changed, 143 insertions(+), 143 deletions(-) diff --git a/drivers/gpu/drm/amd/include/vega10_ip_offset.h b/drivers/gpu/drm/amd/include/vega10_ip

[PATCH] drm/amdgpu/powerplay/vega10: fix memory leak in error path

2018-03-13 Thread Alex Deucher
Free the backend structure if we fail to allocate device memory. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/vega10_smumgr.c b/drivers/gpu/drm/

RE: [PATCH 4/5] drm/amd/pp: Remove unneeded void * casts in cz_hwmgr.c/cz_smumgr.c

2018-03-13 Thread Quan, Evan
Is there any compile warning with the casting stripped? There is similar casting in other files. Should I expect more similar patches? Other patches in the serial are Reviewed-by: Evan Quan Regards, Evan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On B

RE: [PATCH] drm/amdgpu/powerplay/vega10: fix memory leak in error path

2018-03-13 Thread Quan, Evan
Reviewed-by: Evan Quan -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Wednesday, March 14, 2018 9:46 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powerplay/vega10: fix memory leak

[amd-staging-drm-next] - commit 'Set disp clk in a safe way to avoid over high dpp clk.' makes 'CONFIG_DRM_AMD_DC_DCN1_0=y' mandatory, again

2018-03-13 Thread Dieter Nützel
Hello, commit # 680acc64120cd7fe4fb21d816a0fc0854018fe59 drm/amd/display: Set disp clk in a safe way to avoid over high dpp clk. makes CONFIG_DRM_AMD_DC_DCN1_0=y mandatory, again. I think it was not intentional? Without it I get: Kernel: arch/x86/boot/bzImage is ready (#1) ERROR: "dcn_find_dc

Re: [amd-staging-drm-next] - commit 'Set disp clk in a safe way to avoid over high dpp clk.' makes 'CONFIG_DRM_AMD_DC_DCN1_0=y' mandatory, again

2018-03-13 Thread Alex Deucher
On Wed, Mar 14, 2018 at 2:15 AM, Dieter Nützel wrote: > Hello, > > commit # 680acc64120cd7fe4fb21d816a0fc0854018fe59 > drm/amd/display: Set disp clk in a safe way to avoid over high dpp clk. > > makes CONFIG_DRM_AMD_DC_DCN1_0=y mandatory, again. > I think it was not intentional? Fixed in: https:/