Re: [PATCH] drm/amdkfd: Use ARRAY_SIZE macro in kfd_build_sysfs_node_entry

2018-01-21 Thread Gustavo A. R. Silva
Quoting Felix Kuehling : Looks good. This change is Reviewed-by: Felix Kuehling Thanks Felix. -- Gustavo ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH] drm/amdgpu: Avoid leaking PM domain on driver unbind

2018-01-21 Thread Lukas Wunner
amdgpu_device_init() calls vga_switcheroo_init_domain_pm_ops() either if the device has the PowerXpress flag set or if the user has set the "runpm" module param to 1. However amdgpu_device_fini() calls vga_switcheroo_fini_domain_pm_ops() only under the first of those two conditions. (Note this is

Re: [RFC] Per file OOM badness

2018-01-21 Thread Eric Anholt
Michel Dänzer writes: > On 2018-01-19 11:02 AM, Michel Dänzer wrote: >> On 2018-01-19 10:58 AM, Christian König wrote: >>> Am 19.01.2018 um 10:32 schrieb Michel Dänzer: On 2018-01-19 09:39 AM, Christian König wrote: > Am 19.01.2018 um 09:20 schrieb Michal Hocko: >> OK, in that case I

答复: [PATCH v2 5/7] drm/amd/pp: Implement edit_dpm_table on smu7

2018-01-21 Thread Quan, Evan
+ for (i=0; idpm_table.sclk_table.count; i++) { + if (odn_table->odn_core_clock_dpm_levels.entries[i].clock != + data->dpm_table.sclk_table.dpm_levels[i].value) { + data->need_update_smu7_dpm_table |= DPMTABLE_OD_UPDA

[PATCH 3/4] exa: Accelerate ARGB2101010 pictures

2018-01-21 Thread Mario Kleiner
From: Fredrik Höglund Tested by Mario on a Radeon HD 4000 series for the r600 exa path, and on Radeon HD 5770 for the evergreen exa path. Signed-off-by: Fredrik Höglund Reviewed-and-Tested-by: Mario Kleiner --- src/evergreen_exa.c | 18 ++ src/r600_exa.c | 18

答复: [PATCH v2 6/7] drm/amd/pp: Update smu7 dpm table with OD clock/voltage

2018-01-21 Thread Quan, Evan
@@ -4887,21 +4811,25 @@ static void smu7_check_dpm_table_updated(struct pp_hwmgr *hwmgr) dep_table = table_info->vdd_dep_on_mclk; odn_dep_table = (struct phm_ppt_v1_clock_voltage_dependency_table *)&(odn_table->vdd_dependency_on_mclk); - for (i=0; icount; i++) { + f

Depth 30 enablement for ati-ddx + exa. Rev 3

2018-01-21 Thread Mario Kleiner
Ok, 3rd revision, now with per-x-screen drmmode_crtc_funcs rec and set_gamma = NULL in the depth 30 case. Also back to Fredrik's original exa 10 bit patch, just with his signed-off tacked on. Tested with single and dual x-screen, depth 24, depth 30 and mixed 24 and 30 on separate x-screens. Also t

答复: [PATCH v2 7/7] drm/amd/pp: Add update_avfs call when set_power_state

2018-01-21 Thread Quan, Evan
Do we need to reset need_update_smu7_dpm_table flag as 0 in smu7_set_power_state_tasks? Regards, Evan 发件人: amd-gfx 代表 Rex Zhu 发送时间: 2018年1月19日 16:10:11 收件人: amd-gfx@lists.freedesktop.org 抄送: Zhu, Rex 主题: [PATCH v2 7/7] drm/amd/pp: Add update_avfs call when s

[PATCH 2/4] Skip xf86HandleColormaps() at color depth 30. (v2)

2018-01-21 Thread Mario Kleiner
The hardware gamma luts get bypassed at color depth 30 anyway, so skip their setup. v2: Also don't hook up drmmode_crtc_gamma_set() to .gamma_set for a screen with depth 30, so the server can spare itself the effort of updating and setting unused cluts. Suggested by Michel. Signed

[PATCH 4/4] Support exa screen color depth 30 on Linux 3.16 and later. (v2)

2018-01-21 Thread Mario Kleiner
Linux 3.16's radeon-kms introduced 10 bpc fb support. Currently, as of X-Server 1.19, this works with exa accel, but not yet when using glamor acceleration. v2: Style fixes, check for glamor first, as suggested by Michel. Signed-off-by: Mario Kleiner --- man/radeon.man | 3 ++- src/radeo

Re: lock/unlock mismatch in ttm_bo.c

2018-01-21 Thread Chunming Zhou
On 2018年01月20日 02:23, Tom St Denis wrote: On 19/01/18 01:14 PM, Tom St Denis wrote: Hi all, In the function ttm_bo_cleanup_refs() it seems possible to get to line 551 without entering the block on 516 which means you'll be unlocking a mutex that wasn't locked. Now it might be that in the

Re: [PATCH 01/21] drm/amdgpu: wire up emit_wreg for gfx v6

2018-01-21 Thread Chunming Zhou
patch#1~18 are Acked-by: Chunming Zhou patch#19~21 are Reviewed-by: Chunming Zhou On 2018年01月19日 19:48, Christian König wrote: Needed for vm_flush unification. v2: handle compute rings as well. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 14 ++

RE: [PATCH] drm/amdgpu: Temparary disable the sdma use pollmem feature for sriov.

2018-01-21 Thread Deng, Emily
Hi Christian, Thanks your comment, please ignore this patch. Will find out the root cause about why the pollmem doesn't work. Best Wishes, Emily Deng > -Original Message- > From: Christian König [mailto:ckoenig.leichtzumer...@gmail.com] > Sent: Friday, January 19, 2018 6:22 PM > T

RE: [PATCH] drm/amdgpu/powerplay/vega10: fix compute profile name

2018-01-21 Thread Zhu, Rex
Thanks, Alex. Reviewed-by: Rex Zhu Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Alex Deucher Sent: Saturday, January 20, 2018 1:14 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: [PATCH] drm/amdgpu/powe

[PATCH 1/4] Define per x-screen individual drmmode_crtc_funcs

2018-01-21 Thread Mario Kleiner
This allows to en-/disable some functions depending on individual screen settings. Prep work for more efficient depth 30 support. Suggested-by: Michel Dänzer Signed-off-by: Mario Kleiner --- src/drmmode_display.c | 14 ++ src/radeon.h | 2 ++ 2 files changed, 12 insertion