Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

Am 04.01.2018 um 23:43 schrieb Alex Deucher: On Thu, Jan 4, 2018 at 5:26 PM, Samuel Li wrote: +uint32_t amdgpu_framebuffer_domains(struct amdgpu_device *adev) Please rename this amdgpu_display_framebuffer_domains() for consistency. Currently all the functions in this file are named without _d

Re: [PATCH 1/5] drm/amdgpu: add new asic callbacks for HDP flush/invalidation

Am 05.01.2018 um 05:19 schrieb Alex Deucher: Needed to properly flush the HDP cache with the CPU from rather than the GPU. Signed-off-by: Alex Deucher Signed-off-by: Samuel Li Whole series is Reviewed-by: Christian König . Regards, Christian. --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 6

Re: [PATCH 1/4] drm/amdgpu/gmc6: use amdgpu_asic_flush_hdp for gart tlb invalidations

Am 05.01.2018 um 05:30 schrieb Alex Deucher: Use the callback rather than open coding it. Signed-off-by: Alex Deucher I would rather prefer if the caller of flush_gpu_tlb calls amdgpu_asic_flush_hdp(). IIRC we have exactly one which calls this and the other one actually wants to call amdg

Re: [PATCH 2/3] drm: export gem dmabuf_ops for drivers to reuse

Am 04.01.2018 um 22:12 schrieb Samuel Li: Change-Id: I03c22a890d2305f3243d88019d1a28bddd4ddda7 Signed-off-by: Samuel Li Reviewed-by: Christian König --- drivers/gpu/drm/drm_prime.c | 53 ++--- include/drm/drm_prime.h | 22 +++

Re: [PATCH 3/3] drm/amdgpu: Move to gtt before cpu accesses dma buf.

Am 04.01.2018 um 22:12 schrieb Samuel Li: To improve cpu read performance. This is implemented for APUs currently. v2: Adapt to change https://lists.freedesktop.org/archives/amd-gfx/2017-October/015174.html v3: Adapt to change "forward begin_cpu_access callback to drivers" v4: Instead of v3, re

Re: [PATCH 1/3] drm/radeon: Add dpm quirk for Jet PRO (v2)

Am 04.01.2018 um 23:03 schrieb Alex Deucher: Fixes stability issues. v2: clamp sclk to 600 Mhz Bug: https://bugs.freedesktop.org/show_bug.cgi?id=103370 Signed-off-by: Alex Deucher Acked-by: Christian König for the series. --- drivers/gpu/drm/radeon/si_dpm.c | 5 + 1 file changed, 5

[PATCH 2/2] drm/amd/pp: Add stable Pstate clk display support in debugfs

The additional output are: PSTATE_SCLK and PSTATE_MCLK value in MHz as: 300 MHz (PSTATE_SCLK) 300 MHz (PSTATE_MCLK) Change-Id: I08645d518635f81bc566d242712b6906ee5413fb Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 2 ++ drivers/gpu/drm/amd/include/kgd_pp_interface

[PATCH 1/2] drm/amd/pp: Store stable Pstate clocks

User can use to calculate profiling ratios when set UMD Pstate. Signed-off-by: Rex Zhu Change-Id: I3c6b82ebface57eb969d474c57149e8658ab7014 --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 2 ++ drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 3 +++ drivers/gpu/drm/amd/powerplay/

[PATCH umr] change printout of PDE/BASE names for AI platforms to match hardware documentation

Signed-off-by: Tom St Denis --- src/lib/read_vram.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/lib/read_vram.c b/src/lib/read_vram.c index 80f8e056258f..51ca02ef289a 100644 --- a/src/lib/read_vram.c +++ b/src/lib/read_vram.c @@ -472,8 +472,7 @@ static int umr_acc

Re: [PATCH 1/2] drm/amd/pp: Store stable Pstate clocks

Reviewed-by: Alex Deucher From: amd-gfx on behalf of Rex Zhu Sent: Friday, January 5, 2018 6:38 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 1/2] drm/amd/pp: Store stable Pstate clocks User can use to calculate profiling ratios when set UM

Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display support in debugfs

From: amd-gfx on behalf of Rex Zhu Sent: Friday, January 5, 2018 6:38 AM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display support in debugfs The additional output are: PSTATE_SCLK and PSTATE_MCLK val

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

On 2018-01-04 04:11 PM, Samuel Li wrote: > From: Christian König > > On CZ and newer APUs we can pin the fb into GART as well as VRAM. > > v2: Don't enable gpu_vm_support for Raven yet since it leads to > a black screen. Need to debug this further before enabling. I can't find the part to e

[PATCH 2/2] drm/amdgpu: drop extra tlb invalidation in gpuvm

We only need to flush the HDP here, not invalidate the TLB. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c index 2d5c1aa7322a..7b1dae663bd

[PATCH 1/2] drm/amdgpu: adjust HDP write queue flushing for tlb invalidation

Separate tlb invalidation and hdp flushing and move the HDP flush to the caller. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 ++ drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c| 2 -- drivers/gpu/drm/amd/amdgpu/gmc_v7_0.

Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display support in debugfs

Ok. Thanks. I will query twice.one for pstate sclk and one for mclk. Best Regards Rex From: Deucher, Alexander Sent: Friday, January 5, 2018 11:44:00 PM To: Zhu, Rex; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amd/pp: Add stable Pstate clk display s

RE: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

I think Andrey approved your patch last December? If you mean the driver actually set up fb in gart memory, that is not included in this series. I can do that in another patch. Regards, Samuel Li > -Original Message- > From: Wentland, Harry > Sent: Friday, January 05, 2018 10:50 AM > To

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

On 2018-01-05 10:54 AM, Li, Samuel wrote: > I think Andrey approved your patch last December? > If you mean the driver actually set up fb in gart memory, that is not > included in this series. I can do that in another patch. > Sounds good. Harry > Regards, > Samuel Li > > >> -Original Me

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

> to make all the files use consistent naming going forward to make the code > more > readable. OK. Will do. Sam On 2018-01-04 05:43 PM, Alex Deucher wrote: > On Thu, Jan 4, 2018 at 5:26 PM, Samuel Li wrote: +uint32_t amdgpu_framebuffer_domains(struct amdgpu_device *adev) >>> >>> Please r

Re: [PATCH 1/3] drm/amdgpu: allow framebuffer in GART memory as well

On 2018-01-04 04:11 PM, Samuel Li wrote: > From: Christian König > > On CZ and newer APUs we can pin the fb into GART as well as VRAM. > > v2: Don't enable gpu_vm_support for Raven yet since it leads to > a black screen. Need to debug this further before enabling. > > Change-Id: Id0f8af3110

Re: [pull] amdgpu and ttm drm-next-4.16

On Sat, Dec 30, 2017 at 10:37 PM, Alex Deucher wrote: > Hi Dave, > > Last few updates for 4.16: > - Misc fixes for amdgpu > - Enable swapout for reserved BOs during allocation for ttm > - Misc cleanups for ttm Ping? Just want to make sure this didn't get missed. Thanks, Alex > > The following

Re: [PATCH 1/2] drm/amdgpu: adjust HDP write queue flushing for tlb invalidation

Am 05.01.2018 um 16:58 schrieb Alex Deucher: Separate tlb invalidation and hdp flushing and move the HDP flush to the caller. Signed-off-by: Alex Deucher Reviewed-by: Christian König for the series. --- drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_v

Re: [PATCH libdrm 1/3] amdgpu: Clean up amdgpu_parse_asic_ids error handling

On Fri, Dec 1, 2017 at 5:56 PM, Michel Dänzer wrote: > From: Michel Dänzer > > * Move error message printing into amdgpu_parse_asic_ids and make it > return void > * Print only "Invalid format" error message if parse_one_line returns > -EINVAL > * Use strerror instead of printing the (negativ