[PATCH 1/3] drm/amd/pp: Add sysfs entry to get voltage control type

Change-Id: Ie54af5a8056dba16aa9849190441377c5958b385 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 27 ++ drivers/gpu/drm/amd/include/kgd_pp_interface.h | 8 2 files changed, 35 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/

[PATCH 2/3] drm/amd/pp: Update avfs when reset power state on VI

when Over-driver engine clock and voltage were set, need to recalculate AVFS voltage Change-Id: Ib97f0424e35ea52e5ce0ed7d7765e207c753f744 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 78 ++ drivers/gpu/drm/amd/powerplay/smumgr/smu7_smumgr.h

[PATCH] drm/radeon: fix sparse warning: Should it be static?

Impact: make symbol static. Fix this sparse warning: drivers/gpu/drm/radeon/radeon_dp_mst.c:332:38: warning: symbol 'mst_cbs' was not declared. Should it be static? Signed-off-by: Dmitry Rozhkov --- Resend with maintainers in CC. drivers/gpu/drm/radeon/radeon_dp_mst.c | 2 +- 1 file change

[PATCH 3/3] drm/amd/pp: Refine pp_dpm_set_pp_table logic

Disable avfs control before set user defined pp table. Change-Id: I0a63aa1def82b166d3f2aa542c3a190339270236 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/amd_power

RE: [PATCH 3/3] drm/amd/pp: Refine pp_dpm_set_pp_table logic

Sorry, please ignore this patch as the new logic is wrong. Best Regards Rex -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Rex Zhu Sent: Tuesday, January 02, 2018 3:54 PM To: amd-gfx@lists.freedesktop.org Cc: Zhu, Rex Subject: [PATCH 3/3] dr

Re: Deadlocks with multiple applications on AMD RX 460 and RX 550 - Update 2

Hi Luis, well first of all that isn't a deadlock, but just a hardware lockup. So the traces and logs you tried to attach are not really useful. What we need instead is a full dmesg and/or some kodi logs, API trace etc.. what exactly is happening when the problem occurs. Please also try Mesa

RE: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only

Original Message- From: Michel Dänzer [mailto:mic...@daenzer.net] Sent: Wednesday, December 27, 2017 4:58 PM To: He, Roger ; Koenig, Christian ; Grodzovsky, Andrey Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd/amdgpu: set gtt size according to system memory size only O

Re: [PATCH] drm/amdgpu/gfx9: only init the apertures used by KGD

Am 01.01.2018 um 22:17 schrieb Alex Deucher: Use adev->vm_manager.id_mgr[0].num_ids rather than hardcoded 16. Noticed-by: Felix Kuehling Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

[PATCH] drm/amd/display/dc: fix double free issue for dc sink

[345508.995835] == [345508.995843] BUG: KASAN: double-free or invalid-free in (null) [345508.995853] CPU: 4 PID: 18706 Comm: deqp-vk Tainted: GB 4.15.0-rc2-custom #9 [345508.995854] Hardware name: Gigabyte T

Re: Deadlocks with multiple applications on AMD RX 460 and RX 550 - Update 2

Dear Mr. David, Mr. Christian, First of all, thanks for your replies! David, I will try the same software versions on x86 to see if I am able to replicate the problem on x86, but I suspect it is ARM specific... I'll report back when I have more details. Christian, I'll collect the data you've re

Re: Deadlocks with multiple applications on AMD RX 460 and RX 550 - Update 2

when you refer to API traces, you're suggesting to strace kodi, or what do you mean? What I meant was apitrace (https://github.com/apitrace/apitrace), but when even the lightdm login screen crashes than this won't be much helpful. That strongly sounds like a ARM specific problem, maybe USWC doe

[PATCH 3/4] drm/amdgpu: update VM PDs after the PTs

Necessary for the next patch. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/am

[PATCH 4/4] drm/amdgpu: simplify huge page handling

Update the PDEs after resetting the huge flag. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 60 ++ 1 file changed, 18 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/a

[PATCH 1/4] drm/amdgpu: loosen the criteria for huge pages a bit

We can actually handle invalid huge pages perfectly fine now. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c inde

[PATCH 2/4] drm/amdgpu: minor optimize VM moved handling v2

Try to lock moved BOs if it's successful we can update the PTEs directly to the new location. v2: rebase Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgp

Re: [PATCH] drm/amd/powerplay: fix memory leakage when reload

From: amd-gfx on behalf of Yintian Tao Sent: Sunday, December 31, 2017 10:16 PM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amd/powerplay: fix memory leakage when reload add smu_free_memory when smu fini to prevent memory leakage Cha

Re: [PATCH 2/4] drm/amd/powerplay: remove unused parameter of phm_start_thermal_controller

If it's not used, feel free to remove it (feel free to add my Acked-by). I was just wondering if it would be useful to fix up the critical temperature ranges in sysfs. Alex From: Quan, Evan Sent: Monday, January 1, 2018 8:51 PM To: Deucher, Alexander; amd-gfx

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bart Van Assche wrote: > On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > > On Tue, 2 Jan 2018, Bob Peterson wrote: > > > - Original Message - > > > > - Original Message - > > > > > > > Still, the GFS2 and DLM code has a plethora of broken-up printk me

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

- Original Message - | Drop newline at the end of a message string when the printing function adds | a newline. Hi Julia, NACK. As much as it's a pain when searching the source code for output strings, this patch set goes against the accepted Linux coding style document. See: https://ww

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | - Original Message - > | | Drop newline at the end of a message string when the printing function > adds > | | a newline. > | > | Hi Julia, > | > | NACK. > | > | As much as it's a pain when searching the source c

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2 Jan 2018, Bob Peterson wrote: > - Original Message - > | Drop newline at the end of a message string when the printing function adds > | a newline. > > Hi Julia, > > NACK. > > As much as it's a pain when searching the source code for output strings, > this patch set goes agains

Re: [PATCH] drm/radeon: use raw buffer printk specifier

On Mon, 2018-01-01 at 16:12 -0500, Alex Deucher wrote: > On Thu, Dec 21, 2017 at 5:04 AM, Dmitry Rozhkov > wrote: > > printk format strings accepting a single subsequent argument > > are shorter thus easier to read. > > I'm not sure I agree it's easier to read. > IMHO, it's somewhat less > clear

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

- Original Message - | - Original Message - | | Drop newline at the end of a message string when the printing function adds | | a newline. | | Hi Julia, | | NACK. | | As much as it's a pain when searching the source code for output strings, | this patch set goes against the accep

Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline

On Tue, 2018-01-02 at 15:00 +0100, Julia Lawall wrote: > On Tue, 2 Jan 2018, Bob Peterson wrote: > > - Original Message - > > > - Original Message - > > > > > Still, the GFS2 and DLM code has a plethora of broken-up printk messages, > > and I don't like the thought of re-combining t

Re: [PATCH] drm/radeon: fix sparse warning: Should it be static?

On Tue, Jan 2, 2018 at 3:02 AM, Dmitry Rozhkov wrote: > Impact: make symbol static. > > Fix this sparse warning: > drivers/gpu/drm/radeon/radeon_dp_mst.c:332:38: warning: symbol 'mst_cbs' > was not declared. Should it be static? > > Signed-off-by: Dmitry Rozhkov Applied. Thanks! Alex > ---

[PATCH 1/2] drm/amdkfd: Fix return value 0 when execute_queues_cpsch actually fails

Signed-off-by: Yong Zhao Reviewed-by: Oak Zeng --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c index d0693f

[PATCH 2/2] drm/amdkfd: avoid calling execute_queues_cpsch() when destroying an unactive queue

Signed-off-by: Yong Zhao Reviewed-by: Oak Zeng --- drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c i

Re: [PATCH 4/4] drm/amdgpu: simplify huge page handling

[+Kent, Yong, Harish] This means updating page tables can invalidate page directories. You prepared amdgpu_cs for this. On our amd-kfd-staging branch amdgpu_amdkfd_gpuvm.c we will need an equivalent change when we pick up this patch. Currently we update page directories in vm_validate_pt_pd_bos.

[PATCH] drm/amdgpu: add high priority compute support for gfx9

We follow the same approach as gfx8. The only changes are register access macros. Tested on vega10. The execution latency results fall within the expected ranges from the polaris10 data. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 100

Re: Deadlocks with multiple applications on AMD RX 460 and RX 550 - Update 2

Ok... I've done some of the suggested tests. I still haven't tested on x86, but I'll get to that. I've recompiled the kernel to disable Power Management as much as possible at all levels, including the PCIe, I've also modified /include/drm/drm_cache.h - static inline bool drm_arch_can_wc_memory(v

Re: [PATCH 29/37] PCI: Add pci_enable_atomic_ops_to_root

On 2017-12-12 06:27 PM, Bjorn Helgaas wrote: > [+cc Ram, Michal, Ariel, Doug, Jason] > > The [29/37] in the subject makes it look like this is part of a larger > series, but I can't find the rest of it on linux-pci or linux-kernel. > > I don't want to merge a new interface unless there's an in-tree

Re: Deadlocks with multiple applications on AMD RX 460 and RX 550 - Update 2

Just a small update, regarding to what I have posted... I've made additional tests with mesa-17.4 at commit "radv: Implement binning on GFX9" - 6a36bfc64d2096aa338958c4605f5fc6372c07b8 and I was able to gather a smaller apitrace of kodi playing a video with about 1GB that hangs the GPU, almost alw

RE: [PATCH] drm/amd/powerplay: fix memory leakage when reload

Add Alex -Original Message- From: Yintian Tao [mailto:yt...@amd.com] Sent: Monday, January 01, 2018 11:16 AM To: amd-gfx@lists.freedesktop.org Cc: Tao, Yintian Subject: [PATCH] drm/amd/powerplay: fix memory leakage when reload add smu_free_memory when smu fini to prevent memory leakage

[PATCH 7/7] drm/amd/powerplay: export the thermal ranges of Carrizo

Change-Id: I861e3e6d4ec553171cbf369eca4ac9d834478290 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr

[PATCH 3/7] drm/amd/powerplay: new hw manager interface for retrieving device specific thermal range

Change-Id: Icae6e15c7494d12bf8a194b9f1a352e0dcdef4ed Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/inc/hwmgr.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/powerplay/inc/hwmgr.h index bd2889f..384a4cb 100644 --

[PATCH 4/7] drm/amd/powerplay: export thermal range through temp sysfs

Change-Id: I903ebb4d75ec0628e9720b6fee915c907e594613 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c b/drivers/gpu/drm/amd/powe

[PATCH 2/7] drm/amd/powerplay: new cgs interface setting dpm thermal range

Change-Id: Ib4156edff8e3daaead720956142d8540df3254d8 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 13 + drivers/gpu/drm/amd/include/cgs_common.h | 7 +++ 2 files changed, 20 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c b/drivers/

[PATCH 5/7] drm/amd/powerplay: export vega10 specific thermal ranges

Change-Id: If240a45dd2538e93185802b1fce54fd83de89de0 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr

[PATCH] drm/amd/pp: Supply Max DGPU clock for DC validation

This patch can fix MultiGPU-Display blank out with 1 IGPU-4k display and 2 DGPU-two 4K displays. Change-Id: I41208feb6b275d9e8b45e9ef129e19c9739107a4 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --gi

[PATCH 1/7] drm/amd/powerplay: correct PP_TemperatureRange member type since negative values are part of the valid range

Change-Id: I68bb53691fb2edca66c09391ab5e60357496283c Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c | 4 ++-- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 4 ++-- drivers/gpu/drm/amd/powerplay/inc/power_state.h | 4 ++-- 3 files changed, 6 inserti

[PATCH 6/7] drm/amd/powerplay: export the thermal ranges of VI asics

Change-Id: I569179443c73c793153d5c499dd2f203f89e3ca2 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 26 1 file changed, 26 insertions(+) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/

[PATCH] drm/amd/powerplay: use ffs/fls instead of implementing our own

Change-Id: I2683296f7b08cc637ed54b0b4b7db03b8818e658 Signed-off-by: Evan Quan --- drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 27 -- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/am

Re: [PATCH] drm/amd/display/dc: fix double free issue for dc sink

The quick patch doesn't fix the problem, I encounter it again, please don't review. Hi Harry, Could you take a look it? You're familiar with dc code, or it's a known issue? Thanks, David Zhou On 2018年01月02日 18:11, Chunming Zhou wrote: [345508.995835] ===

Re: [PATCH 1/4] drm/amdgpu: loosen the criteria for huge pages a bit

On 2018年01月02日 22:47, Christian König wrote: We can actually handle invalid huge pages perfectly fine now. It seems be a bug fix for those valid no-huge-page ptes. Reviewed-by: Chunming Zhou Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 7 ++- 1 file c