RE: [PATCH] drm/amdgpu: Add gpu_recovery parameter

2017-12-18 Thread Liu, Monk
You can add my RB But to be honest, the current bare-metal GPU recover approach still look not good enough especially that soft_rest checking parts: 1) not all engine/IP on all version are implemented for this, and it's very very time cost to imple them all 2) like I said before, it only shows

[PATCH 04/45] gpu: drm: remove duplicate includes

2017-12-18 Thread Pravin Shedge
These duplicate includes have been found with scripts/checkincludes.pl but they have been removed manually to avoid removing false positives. Signed-off-by: Pravin Shedge --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 1 - drivers/gpu/drm/amd/amdgpu/mxgpu_vi.c

Topaz mistakenly reported as

2017-12-18 Thread José Pekkarinen
Hi, I hit an issue that seems to be a topaz discrete vga reporting it's a virtual function when my laptop is running on the battery. I received the following bactrace: Dec 17 11:17:28 bee kernel: [ 31.976810] kernel BUG at drivers/gpu/drm/amd/ amdgpu/mxgpu_vi.c:310! Dec 17 11:

[trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Joe Perches
Some functions definitions have either the initial open brace and/or the closing brace outside of column 1. Move those braces to column 1. This allows various function analyzers like gnu complexity to work properly for these modified functions. Miscellanea: o Remove extra trailing ; and blank l

[PATCH] Drivers: gpu: drm: amdgpu: fixed coding style issues

2017-12-18 Thread Bouke Haarsma
From e243a807fe45b8ac4dc9c5e54956ccdd3bd806a1 Mon Sep 17 00:00:00 2001 From: Bouke Haarsma Date: Sun, 17 Dec 2017 14:17:09 +0100 Subject: [PATCH] Drivers: gpu: drm: amdgpu: fixed coding style issues Fixed coding style issues. --- drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c | 3 +- drivers/

Re: [PATCH] Revert "drm/amd/amdgpu: set gtt size according to system memory size only"

2017-12-18 Thread Christian König
Reviewed-by: Christian König Am 18.12.2017 um 03:53 schrieb He, Roger: Reviewed-by: Roger He Thanks Roger(Hongbo.He) -Original Message- From: Andrey Grodzovsky [mailto:andrey.grodzov...@amd.com] Sent: Saturday, December 16, 2017 3:10 AM To: amd-gfx@lists.freedesktop.org Cc: Koenig, Ch

Re: [PATCH] drm/amdgpu: Fix a bug that vm size is wrong on Raven

2017-12-18 Thread Christian König
The problem was a merge conflict. No idea what exactly went wrong, but Yong ended up with a branch where the vm_size was always overwritten with the value 64. So we can completely drop this patch and yes when an user overrides the vm_size value he/she should know what the consequences are.

[PATCH 4/5] drm/amd/pp: export more smu message on Rv

2017-12-18 Thread Rex Zhu
Change-Id: Ib89948c2a2ba8cede4a62875befde48c7bedba69 Reviewed-by: Alex Deucher Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/powerplay/inc/rv_ppsmc.h b/drivers/gpu/drm/amd/pow

[PATCH 1/5] drm/amd/pp: delete dead code of arbiter overdriver clk

2017-12-18 Thread Rex Zhu
for sclk/mclk, we can adjust through sysfs. for uvd/vce clk, we will adjust case by case when requested. Change-Id: I093bd295df0dfbcf4fc1049a7f87b108d099e5c9 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 29 +++- drivers/gpu/drm/amd/powerplay/hwmgr/r

[PATCH 2/5] drm/amd/pp: implement phm_reset_power_profile_state

2017-12-18 Thread Rex Zhu
mv related code out of force_dpm_level to phm_reset_power_profile_state Change-Id: Ib304afb6c623a5638f5c633d76b8306c174a5677 Signed-off-by: Rex Zhu --- .../gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 33 -- drivers/gpu/drm/amd/powerplay/hwmgr/pp_psm.c | 1 + .../g

[PATCH 5/5] drm/amd/pp: implement force_dpm_level on rv

2017-12-18 Thread Rex Zhu
user can change engine/mclk/soc/vcn clocks on Rv v3: add smu version check v2: fix no return statement Change-Id: I4cba759701ab031085a687102de6566771f4494f Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c | 127 + drivers/gpu/drm/amd/powerplay/hw

[PATCH 3/5] drm/amd/pp: delete repeated call of force_dpm_level

2017-12-18 Thread Rex Zhu
Change-Id: I0661b84ff55aceb88aaef8b09ceab2a29f335600 Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 10 +- drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 1 + drivers/gpu/drm/amd/powerplay/hwmgr/pp_psm.c | 5 - 3 files changed, 6 insertions(+), 10 delet

[PATCH libdrm 3/3] amdgpu: use the high VA range if possible

2017-12-18 Thread Christian König
Retire the 32bit range and the low range on Vega10. AFAIK THe 32bit range was never used by any open source component and this frees up everything below 0x8000 for HMM. Signed-off-by: Christian König --- amdgpu/amdgpu_device.c | 21 ++--- 1 file changed, 14 insertions

[PATCH libdrm 1/3] amdgpu: fix 32bit VA manager max address

2017-12-18 Thread Christian König
The range is exclusive not inclusive. Signed-off-by: Christian König --- amdgpu/amdgpu_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/amdgpu/amdgpu_device.c b/amdgpu/amdgpu_device.c index eb4b2745..d7077184 100644 --- a/amdgpu/amdgpu_device.c +++ b/amdgpu/amdgpu_dev

[PATCH libdrm 2/3] headers: sync up amdgpu_drm.h with drm-next

2017-12-18 Thread Christian König
Sync up amdgpu changes from drm-next. Signed-off-by: Christian König --- include/drm/amdgpu_drm.h | 4 1 file changed, 4 insertions(+) diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h index 919248fb..a023b476 100644 --- a/include/drm/amdgpu_drm.h +++ b/include/drm/amdgpu_dr

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Andy Shevchenko
On Mon, Dec 18, 2017 at 2:28 AM, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for these modifie

Re: [PATCH] drm/amdgpu: Add gpu_recovery parameter

2017-12-18 Thread Deucher, Alexander
We should start with full asic reset and then work back to enable soft resets for the IPs. Alex From: amd-gfx on behalf of Liu, Monk Sent: Monday, December 18, 2017 3:58:13 AM To: Grodzovsky, Andrey; Koenig, Christian; amd-gfx@lists.freedesktop.org Cc: mar...

Re: [PATCH] drm/amdgpu: Fix a bug that vm size is wrong on Raven

2017-12-18 Thread Zhao, Yong
Felix, we ended up with this fix. http://git.amd.com:8080/#/c/122202/ I explored the option to override the VM size only for KFD VMs, but it was not easy as amdgpu_check_vm_size() and amdgpu_vm_adjust_size() come in during loading amdgpu, i. e. before KFD VMs are created. So to fix the proble

Re: [PATCH 5/5] drm/amd/pp: implement force_dpm_level on rv

2017-12-18 Thread Alex Deucher
On Mon, Dec 18, 2017 at 6:50 AM, Rex Zhu wrote: > user can change engine/mclk/soc/vcn clocks on Rv > > v3: add smu version check > v2: fix no return statement > > Change-Id: I4cba759701ab031085a687102de6566771f4494f > Signed-off-by: Rex Zhu Patches 1-4: Reviewed-by: Alex Deucher > --- > drive

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Rafael J. Wysocki
On Monday, December 18, 2017 1:28:44 AM CET Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for t

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Paul Moore
On Sun, Dec 17, 2017 at 7:28 PM, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for these modifie

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Alex Deucher
On Sun, Dec 17, 2017 at 7:28 PM, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for these modifie

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Dave Chinner
On Sun, Dec 17, 2017 at 04:28:44PM -0800, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for the

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Alexandre Belloni
On 17/12/2017 at 16:28:44 -0800, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for these modifi

[PATCH 1/3] Fix xf86HandleColormaps() crash at color depth 30.

2017-12-18 Thread Mario Kleiner
The size of the X-Server pScreenPriv->PreAllocIndices array allocated within xf86HandleColormaps() is given by the given maxColors argument, but the range of indices by which the PreAllocIndices array is indexed in routines like CMapReinstallMap() seems to be up to 1023 on a 10 bpc / depth 30 scree

[PATCH 2/3] exa: Accelerate ARGB2101010 pictures

2017-12-18 Thread Mario Kleiner
From: Fredrik Höglund Tested by Mario on a Radeon HD 4000 series for the r600 exa path, and on Radeon HD 5770 for the evergreen exa path. Reviewed-and-Tested-by: Mario Kleiner Cc: Fredrik Höglund --- src/evergreen_exa.c | 18 ++ src/r600_exa.c | 18 ++ 2 f

Depth 30 enablement for ati-ddx + exa.

2017-12-18 Thread Mario Kleiner
Hi, this is the patch series for ati-ddx to enable depth 30 color display under exa, which i used for testing the corresponding mesa 30 bit rendering patches. Works well, and photometer measurements confirmed we get 10 bpc per color channel. 1/3 fixes a server crash if x-screen depth 30 is select

[PATCH 3/3] Support exa screen color depth 30 on Linux 3.16 and later.

2017-12-18 Thread Mario Kleiner
Linux 3.16's radeon-kms introduced 10 bpc fb support. Currently, as of X-Server 1.19, this works with exa accel, but not yet when using glamor acceleration. Signed-off-by: Mario Kleiner --- man/radeon.man | 3 ++- src/radeon_kms.c | 17 + 2 files changed, 19 insertions(+), 1 d

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Darrick J. Wong
On Sun, Dec 17, 2017 at 04:28:44PM -0800, Joe Perches wrote: > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for the

Re: [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Martin K. Petersen
Joe, > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. SCSI bits look OK. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering

Re: [alsa-devel] [trivial PATCH] treewide: Align function definition open/close braces

2017-12-18 Thread Takashi Iwai
On Mon, 18 Dec 2017 01:28:44 +0100, Joe Perches wrote: > > Some functions definitions have either the initial open brace and/or > the closing brace outside of column 1. > > Move those braces to column 1. > > This allows various function analyzers like gnu complexity to work > properly for these

RE: Topaz mistakenly reported as vf

2017-12-18 Thread Yu, Xiangliang
Topaz doesn't support SRIOV. > -Original Message- > From: José Pekkarinen [mailto:jose.pekkari...@canonical.com] > Sent: Tuesday, December 19, 2017 3:12 PM > To: Yu, Xiangliang > Cc: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Koenig, Christian > > Subject: Re: Topaz mistakenl