Re: [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

2017-11-23 Thread Christian König
Am 22.11.2017 um 18:27 schrieb Boris Ostrovsky: On 11/22/2017 11:54 AM, Christian König wrote: Am 22.11.2017 um 17:24 schrieb Boris Ostrovsky: On 11/22/2017 05:09 AM, Christian König wrote: Am 21.11.2017 um 23:26 schrieb Boris Ostrovsky: On 11/21/2017 08:34 AM, Christian König wrote: Hi Bori

Re: Kernel crash/Null pointer dereference on vblank

2017-11-23 Thread Johannes Hirte
On 2017 Nov 23, Chunming Zhou wrote: > Which driver are you using? > > I guess your driver is a bit old, the issue should be fixed before. > This was with git master from Linus. But even with the latest changes from agd5f/drm-next-4.15 both use-after-free still persist. If there are fixes for th

Re: Updated CP firmware for polaris

2017-11-23 Thread Ben Hutchings
On Fri, 2017-11-03 at 14:30 -0400, Alex Deucher wrote: > Hi Kyle, > > Updated CP firmware for polaris GPUs. Please apply! Applied, thanks. Ben. -- Ben Hutchings When in doubt, use brute force. - Ken Thompson signature.asc Description: This is a digitally signed message part ___

Re: [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

2017-11-23 Thread Boris Ostrovsky
On 11/22/2017 05:09 AM, Christian König wrote: > Am 21.11.2017 um 23:26 schrieb Boris Ostrovsky: >> On 11/21/2017 08:34 AM, Christian König wrote: >>> Hi Boris, >>> >>> attached are two patches. >>> >>> The first one is a trivial fix for the infinite loop issue, it now >>> correctly aborts the fixu

Re: [PATCH v9 4/5] x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors v5

2017-11-23 Thread Boris Ostrovsky
On 11/22/2017 11:54 AM, Christian König wrote: > Am 22.11.2017 um 17:24 schrieb Boris Ostrovsky: >> On 11/22/2017 05:09 AM, Christian König wrote: >>> Am 21.11.2017 um 23:26 schrieb Boris Ostrovsky: On 11/21/2017 08:34 AM, Christian König wrote: > Hi Boris, > > attached are two pat

[PATCH] drm/amd/display: fix memory leaks on error exit return

2017-11-23 Thread Colin King
From: Colin Ian King Currently in the case where some of the allocations fail for dce110_tgv, dce110_xfmv, dce110_miv or dce110_oppv then the exit return path ends up leaking allocated objects. Fix this by kfree'ing them before returning. Also re-work the comparison of the null pointers to use th

Re: Kernel crash/Null pointer dereference on vblank

2017-11-23 Thread Chunming Zhou
See the attached email, they fixed same issue, each of them is ok to fix your issue, your calltrace is  same as the second. We should already push the first patch in early time, could you check if the first patch is in your branch? Regards, David Zhou On 2017年11月23日 16:31, Johannes Hirte w

[PATCH v2 xf86-video-amdgpu] Add amdgpu_dirty_src_drawable helper

2017-11-23 Thread Michel Dänzer
From: Michel Dänzer Allows tidying up amdgpu_dirty_src_equals and redisplay_dirty slightly. v2: * Different approach for amdgpu_dirty_master Signed-off-by: Michel Dänzer --- src/amdgpu_drv.h | 18 +- src/amdgpu_kms.c | 7 ++- 2 files changed, 11 insertions(+), 14 deletion

[PATCH] drm/amd/display: Don't call dm_log_to_buffer directly in dc_conn_log

2017-11-23 Thread Michel Dänzer
From: Michel Dänzer dm_log_to_buffer logs unconditionally, so calling it directly resulted in the main message being logged even when the event type isn't enabled in the event mask. To fix this, remove the trailing newline from the format string and call dm_logger_append instead. Fixes spurious

Re: Kernel crash/Null pointer dereference on vblank

2017-11-23 Thread Johannes Hirte
On 2017 Nov 23, Chunming Zhou wrote: > See the attached email, they fixed same issue, each of them is ok to fix > your issue, your calltrace is  same as the second. > > We should already push the first patch in early time, could you check if > the first patch is in your branch? > This patch (se

[PATCH] drm: Adding amdgpu_cs_create_syncobj2 to be able to create sync object as signaled initially

2017-11-23 Thread Mao, David
Signed-off-by: David Mao --- amdgpu/amdgpu.h| 15 +++ amdgpu/amdgpu_cs.c | 10 ++ 2 files changed, 25 insertions(+) diff --git a/amdgpu/amdgpu.h b/amdgpu/amdgpu.h index 78fbd1e..47bdb3a 100644 --- a/amdgpu/amdgpu.h +++ b/amdgpu/amdgpu.h @@ -1727,6 +1727,21 @@ const char

Re: Kernel crash/Null pointer dereference on vblank

2017-11-23 Thread Leo Li
Hi Johannes, The s3 resume issue looks to be a problem with amdgpu/display. Could you give the attached patch a try? Thanks, Leo On 2017-11-23 07:27 AM, Johannes Hirte wrote: On 2017 Nov 23, Chunming Zhou wrote: See the attached email, they fixed same issue, each of them is ok to fix your i

Re: [PATCH] drm/amd/display: Don't call dm_log_to_buffer directly in dc_conn_log

2017-11-23 Thread Harry Wentland
On 2017-11-23 06:51 AM, Michel Dänzer wrote: > From: Michel Dänzer > > dm_log_to_buffer logs unconditionally, so calling it directly resulted > in the main message being logged even when the event type isn't enabled > in the event mask. > > To fix this, remove the trailing newline from the forma

Re: Kernel crash/Null pointer dereference on vblank

2017-11-23 Thread Johannes Hirte
On 2017 Nov 23, Leo Li wrote: > Hi Johannes, > > The s3 resume issue looks to be a problem with amdgpu/display. Could you > give the attached patch a try? > > Thanks, > Leo > > On 2017-11-23 07:27 AM, Johannes Hirte wrote: > > On 2017 Nov 23, Chunming Zhou wrote: > >> See the attached email, th

[PATCH 1/2] drm/amd/display: Add dm_logger_append_va API

2017-11-23 Thread Michel Dänzer
From: Michel Dänzer Same as dm_logger_append, except it takes a va_list instead of a variable number of arguments. dm_logger_append is now a minimal wrapper around dm_logger_append_va. Signed-off-by: Michel Dänzer --- drivers/gpu/drm/amd/display/dc/basics/logger.c | 17

[PATCH v2 2/2] drm/amd/display: Don't call dm_log_to_buffer directly in dc_conn_log

2017-11-23 Thread Michel Dänzer
From: Michel Dänzer dm_log_to_buffer logs unconditionally, so calling it directly resulted in the main message being logged even when the event type isn't enabled in the event mask. To fix this, use the new dm_logger_append_va API. Fixes spurious messages like [drm] {1920x1200, 2080x1235@1540

[PATCH umr] add bits option for ring decoder to bitfield decode register writes

2017-11-23 Thread Tom St Denis
Signed-off-by: Tom St Denis --- src/lib/find_reg.c| 14 ++ src/lib/ring_decode.c | 39 ++- src/umr.h | 1 + 3 files changed, 45 insertions(+), 9 deletions(-) diff --git a/src/lib/find_reg.c b/src/lib/find_reg.c index ecd7f132c9c9..

[PATCH 04/43] drm/amd/display: dal 3.1.21

2017-11-23 Thread Harry Wentland
From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index c99ed85ba9a2

[PATCH 05/43] drm/amd/display: Integrating MPC pseudocode

2017-11-23 Thread Harry Wentland
From: Eric Bernstein Integrating MPC pseudocode to support new blending cases with secondary MPCC list. This includes a design change to MPC data structures and interfaces. Signed-off-by: Eric Bernstein Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc_hw

[PATCH 14/43] drm/amd/display: Fix potential mem leak in DC construct

2017-11-23 Thread Harry Wentland
Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:506 construct() warn: possible memory leak of 'dc_ctx' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:506 construct() warn: possible memory leak of 'dc_vbios' drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:506 construct() w

[PATCH 03/43] drm/amd/display: try to find matching audio inst for enc inst first

2017-11-23 Thread Harry Wentland
From: Charlene Liu [Description] in eDP+ HDMI/DP clone or extended configuration, audio inst changed from inst 1 to inst0. No failure related this though, just playback device endpoint inst changed. Also remove one addition register read. Signed-off-by: Charlene Liu Reviewed-by: Tony Cheng A

[PATCH 00/43] DC Patches Nov 23, 2017

2017-11-23 Thread Harry Wentland
* Bunch of Raven work, in particular get MPC into better shape * Bunch of fixes for problems caught by the smatch static analyzer * Couple changes from Andrey and Leo to get DC in line with latest DRM atomic stuff * Some more HW object that's been going on for a few weeks Andrew Jiang (3):

[PATCH 08/43] drm/amd/display: Bunch of smatch error and warning fixes in DC

2017-11-23 Thread Harry Wentland
drivers/gpu/drm/amd/amdgpu/../display/dc/basics/log_helpers.c:79 dc_conn_log() error: buffer overflow 'signal_type_info_tbl' 10 <= 10 drivers/gpu/drm/amd/amdgpu/../display/dc/bios/bios_parser.c:266 bios_parser_get_dst_obj() error: uninitialized symbol 'id'. drivers/gpu/drm/amd/amdgpu/../display/dc/

[PATCH 06/43] drm/amd/display: Remove PSR functions in Linux

2017-11-23 Thread Harry Wentland
NULL check issue found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link.c:1976 dc_link_setup_psr() warn: variable dereferenced before check 'link' (see line 1970) We don't use these functions so might as well remove them. Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Ack

[PATCH 26/43] drm/amd/display: Fix access of wrong array element TF format conversion

2017-11-23 Thread Harry Wentland
Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:357 convert_to_custom_float() error: buffer overflow 'arr_points' 2 <= 2 drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:358 convert_to_custom_float() warn: buffer overflow 'arr_points' 2 <=

[PATCH 15/43] drm/amd/display: Fix couple more inconsistent NULL checks in dc_resource

2017-11-23 Thread Harry Wentland
Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1001 acquire_free_pipe_for_stream() error: we previously assumed 'head_pipe' could be null (see line 998) drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_resource.c:1808 dc_validate_global_state() error: we previously ass

[PATCH 20/43] drm/amd/display: Add optimized_required flag

2017-11-23 Thread Harry Wentland
Signed-off-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 2 ++ drivers/gpu/drm/amd/display/dc/dc.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c index 98eff80acffa..19d96aeaa113

[PATCH 07/43] drm/amd/display: Fix amdgpu_dm bugs found by smatch

2017-11-23 Thread Harry Wentland
drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:2760 create_eml_sink() warn: variable dereferenced before check 'aconnector->base.edid_blob_ptr' (see line 2758) drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:4270 amdgpu_dm_atomic_commit_tail() warn: variable dereferenced be

[PATCH 24/43] drm/amd/display: fix gamma setting

2017-11-23 Thread Harry Wentland
From: Roman Li Adding gamma changed check as condition for affected plane. We ignored adding plane as affected if modeset was not required. But for color management change we still need it. Signed-off-by: Roman Li Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/displ

[PATCH 16/43] drm/amd/display: Fixed read wrong reg to get bot_sel.

2017-11-23 Thread Harry Wentland
From: Yongqiang Sun Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_mpc.c b/drivers/gpu/drm/amd/di

[PATCH 17/43] drm/amd/display: MPC updates

2017-11-23 Thread Harry Wentland
From: Eric Bernstein Fix update_mpcc logic to only call assert_mpcc_idle_before_connect if mpcc is not already being used (and required removal). Update set_out_rate_control to include optional flow control parameter. In init_mpcc_from_hw check for case where bot_sel is same as mpcc_id. Signed-o

[PATCH 18/43] drm/amd/display: Do not put drm_atomic_state on resume

2017-11-23 Thread Harry Wentland
From: "Leo (Sunpeng) Li" drm_atomic_helper_resume now puts it for us. See relevant patch here: https://lists.freedesktop.org/archives/dri-devel/2017-October/154268.html Signed-off-by: Leo (Sunpeng) Li Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 - 1 f

[PATCH 35/43] drm/amd/display: USB-C / thunderbolt dock specific workaround

2017-11-23 Thread Harry Wentland
From: Hersen Wu reading dpcd 0x600 cause link loss for a particular USB-C dock with thurderbolt. workaround by avoiding dcpd 0x600 read unless it's necessary. Signed-off-by: Hersen Wu Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 85

[PATCH 23/43] drm/amd/display: Add dcc_change surface update flag

2017-11-23 Thread Harry Wentland
From: Andrew Jiang Program the DCC registers when dcc_change is true. Signed-off-by: Andrew Jiang Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 5 + drivers/gpu/drm/amd/display/dc/dc.h | 1 + drivers

[PATCH 11/43] drm/amd/display: Fix use before NULL check in validate_timing

2017-11-23 Thread Harry Wentland
Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_timing_generator.c:1124 dce110_timing_generator_validate_timing() warn: variable dereferenced before check 'timing' (see line 1116) Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers

[PATCH 28/43] drm/amd/display: Switch to drm_atomic_helper_wait_for_flip_done

2017-11-23 Thread Harry Wentland
From: Andrey Grodzovsky This new helper function is advised to be used for drviers that use the nonblocking commit tracking support instead of drm_atomic_helper_wait_for_vblanks. Signed-off-by: Andrey Grodzovsky Reviewed-by: Harry Wentland --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[PATCH 21/43] drm/amd/display: Change optimized_required logic

2017-11-23 Thread Harry Wentland
From: Andrew Jiang Rather than setting it every time there's a full update with surface count > 0, set it when we need to do plane_atomic_disconnect. Also make sure that we unset the flag in plane_atomic_disable, so that in the event we run through a sequence where we do disconnect followed by an

[PATCH 09/43] drm/amd/display: Remove plane_res.mi check in dce110_apply_ctx_for_surface

2017-11-23 Thread Harry Wentland
plane_res.mi (memory interface) can never be NULL for DCE110 Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2881 dce110_apply_ctx_for_surface() error: we previously assumed 'pipe_ctx->plane_res.mi' could be null (see line 2873) Signed-off-by: Harry Wentland

[PATCH 12/43] drm/amd/display: Fix hubp check in set_cursor_position

2017-11-23 Thread Harry Wentland
Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_stream.c:298 dc_stream_set_cursor_position() error: we previously assumed 'hubp' could be null (see line 294) Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core

[PATCH 29/43] drm/amd/display: dal 3.1.23

2017-11-23 Thread Harry Wentland
From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 96559925bea7

[PATCH 22/43] drm/amd/display: Implement work around for optc underflow.

2017-11-23 Thread Harry Wentland
From: Yongqiang Sun Work around for a hw bug causing optc underflow if blank data double buffer disable and remove mpcc. Checking optc status after otg unlock, after wait mpcc idle check status again, if optc underflow just happens after wait mpcc idle, clear underflow status and enable blank dat

[PATCH 01/43] drm/amd/display: Remove unnecessary wait mpcc idle.

2017-11-23 Thread Harry Wentland
From: Yongqiang Sun Before power gate plane, mpcc idle wait is processed, no need to wait another time. Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/

[PATCH 25/43] drm/amd/display: dal 3.1.22

2017-11-23 Thread Harry Wentland
From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 597bd8b4cb1e

[PATCH 27/43] drm/amd/display: Clean up os_types.h a bit

2017-11-23 Thread Harry Wentland
Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/os_types.h | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h b/drivers/gpu/drm/amd/display/dc/os_types.h index a

[PATCH 34/43] drm/amd/display: OPP DPG test pattern

2017-11-23 Thread Harry Wentland
From: Eric Bernstein Create opp_set_test_pattern function with similar interface and implementation as timing generator test pattern. Signed-off-by: Eric Bernstein Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/inc/hw/hw_shared.h | 37 +++

[PATCH 13/43] drm/amd/display: Fix potential NULL and mem leak in create_links

2017-11-23 Thread Harry Wentland
Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc.c:148 create_links() error: potential null dereference 'link->link_enc'. (kzalloc returns null) Signed-off-by: Harry Wentland Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 14 ++

[PATCH 37/43] drm/amd/display: Fix overlow issue

2017-11-23 Thread Harry Wentland
From: Vitaly Prosyak Signed-off-by: Vitaly Prosyak Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c b/drivers/g

[PATCH 40/43] drm/amd/display: Cache cursor position.

2017-11-23 Thread Harry Wentland
From: Yongqiang Sun When programming cursor position after front end programmed, if position is already set previously, it doesn't make sense to program position with all 0. Cache position and use the parameter after front end programming. Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng A

[PATCH 30/43] drm/amd/display: Disable plane right after disconnected

2017-11-23 Thread Harry Wentland
From: Yongqiang Sun HDR display playing video underflow is observed when switching to full screen due to program a lower watermark right after unlock otg. Instead of disable plane in next flip coming, if there is a plane disconnected, after otg unlock wait for mpcc idle and disable the plane, th

[PATCH 02/43] drm/amd/display: fix seq issue: turn on clock before programming afmt.

2017-11-23 Thread Harry Wentland
From: Charlene Liu Signed-off-by: Charlene Liu Reviewed-by: Krunoslav Kovac Acked-by: Harry Wentland --- .../drm/amd/display/dc/dce/dce_stream_encoder.c| 5 + .../amd/display/dc/dce110/dce110_hw_sequencer.c| 22 ++ 2 files changed, 15 insertions(+), 12 deletio

[PATCH 33/43] drm/amd/display: Build unity lut for shaper

2017-11-23 Thread Harry Wentland
From: Vitaly Prosyak Add color module to diagnostic compilation Signed-off-by: Vitaly Prosyak Reviewed-by: Charlene Liu Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c | 12 + drivers/gpu/drm/amd/display/dc/dc.h| 3 +- .../gpu/drm/amd/displa

[PATCH 32/43] drm/amd/display: Reset MPCC muxes during init

2017-11-23 Thread Harry Wentland
From: Eric Bernstein During HW initialization, instead of assuming or detecting the existing MPCC mux configuration and then removing existing planes, reset all the MPCC muxes. Signed-off-by: Eric Bernstein Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- .../drm/amd/display/dc/dcn10/dcn

[PATCH 31/43] drm/amd/display: CNVC pseudocode review follow up

2017-11-23 Thread Harry Wentland
From: Yue Hin Lau Signed-off-by: Yue Hin Lau Reviewed-by: Eric Bernstein Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 2 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.c | 3 +- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_dpp.h | 484 +++---

[PATCH 42/43] drm/amd/display: Set mpcc_disconnect_pending during MPC reset

2017-11-23 Thread Harry Wentland
From: Tony Cheng This prevents an issue where the MPCC will not go to idle due to us not waiting for it to become idle during disable plane. Signed-off-by: Andrew Jiang Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_

[PATCH 19/43] drm/amd/display: Use same wait mpcc idle function.

2017-11-23 Thread Harry Wentland
From: Yongqiang Sun There is already wait mpcc idle function. It is better to use the same function for all wait mpcc idle. Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- .../drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 27 ++ 1 file

[PATCH 43/43] drm/amd/display: dal 3.1.24

2017-11-23 Thread Harry Wentland
From: Tony Cheng Signed-off-by: Tony Cheng Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index 269d5634e6ee

[PATCH 38/43] drm/amd/display: fix recout_skip calculation when rotating 180 or 270

2017-11-23 Thread Harry Wentland
From: Yongqiang Sun Fixed fliped landscape and fliped portrait hard hang. Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 94 +++ 1 file changed, 60 insertions(+), 34 deletions(-) diff

[PATCH 39/43] drm/amd/display: Program cursor regs after context swapped.

2017-11-23 Thread Harry Wentland
From: Yongqiang Sun Cursor is abnormal after pipe_ctx is changed in context. Cause: cursor attributes is programmed right after front end programming, but it use old pipe_ctx to program which is not updated yet. Solution: Program cursor regs after context swapped. Signed-off-by: Yongqiang Sun R

[PATCH 41/43] drm/amd/display: Refine update flags usage in update_dchubp_dpp

2017-11-23 Thread Harry Wentland
From: Andrew Jiang - Only update DPP clock if it's a full update. - Program viewport on position change. This caused SLS regressions. Signed-off-by: Andrew Jiang Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 5 +++-- 1 file c

Re: [PATCH 17/25] drm/amd/display: Do DC mode-change check when adding CRTCs

2017-11-23 Thread Leo Li
On 2017-11-17 11:46 PM, Andrey Grodzovsky wrote: On 2017-11-16 10:32 AM, Harry Wentland wrote: From: "Leo (Sunpeng) Li" Within atomic check, dm_update_crtcs_state is called twice. First to remove from the dc_state, and subsequently to add to it. In both calls, a secondary mode-change chec

[PATCH 10/43] drm/amd/display: Remove redundant checks in set_default_colors

2017-11-23 Thread Harry Wentland
pipe_ctx->stream and pipe_ctx->plane_state are never NULL Found by smatch: drivers/gpu/drm/amd/amdgpu/../display/dc/dce110/dce110_hw_sequencer.c:2111 set_default_colors() error: we previously assumed 'pipe_ctx->stream' could be null (see line 2101) Signed-off-by: Harry Wentland Reviewed-by: Tony

Re: [PATCH 1/4] drm/ttm: add page order in page pool

2017-11-23 Thread kbuild test robot
Hi Roger, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on next-20171122] [cannot apply to v4.14] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0d

[PATCH 36/43] drm/amd/display: Add is_tiling_rotated flag to plane_state

2017-11-23 Thread Harry Wentland
From: Eric Murphy-Zaremba Signed-off-by: Eric Murphy-Zaremba Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index ee8af9fa66f8

Re: [PATCH 1/5] drm/ttm: add page order in page pool

2017-11-23 Thread kbuild test robot
Hi Roger, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm/drm-next] [also build test WARNING on next-20171122] [cannot apply to v4.14] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://githu

Re: [PATCH 1/4] drm/ttm: add page order in page pool

2017-11-23 Thread kbuild test robot
Hi Roger, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on next-20171122] [cannot apply to v4.14] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0d

[PATCH] Revert "drm/amdgpu: fix rmmod KCQ disable failed error"

2017-11-23 Thread Monk Liu
This reverts commit ff8a0428d1b0e55db6b6e0462e2dc51c4d6724a8. this patch is incorrrect, amdgpu_ucode_bo_fini always called after gfx_hw_fini Change-Id: I7246ea0d2c7c843c14e9923c4d2efde4d90a9ef5 --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay

[AMDGPU DC CIK testing] [drm:construct [amdgpu]] *ERROR* construct: Invalid Connector ObjectID from Adapter Service for connector index:1!

2017-11-23 Thread Shawn Starr
I wonder if this is same issue I encountered with my mobile CIK on AMDGPU non-DC reporting a bogus TV connector? What debugging options would you like me to turn on? Thanks, Shawn Output below cmdline options: amdgpu.cik_support=1 drm_kms_helper.poll=0 amdgpu.dc=1 * I use drm_kms_helper.p

Re: [AMDGPU DC CIK testing] [drm:construct [amdgpu]] *ERROR* construct: Invalid Connector ObjectID from Adapter Service for connector index:1!

2017-11-23 Thread Shawn Starr
Hello, Some further info: Fedora kernel: 4.15.0-0.rc0.git7.2.fc28.x86_64 Connectors in use: VGA, LVDS (laptop display) lid is closed during boot up. Contains a DP connector but not used. Thanks, Shawn On 11/24/2017 01:15 AM, Shawn Starr wrote: I wonder if this is same issue I encountered

[PATCH 00/16] Cleanup vega10 header files.

2017-11-23 Thread Feifei Xu
To avoid duplication of header files,amd/include/asic_reg/vega10 will be removed. Header files under this folder will be moved to corresponding ip folders within asic_reg/. Also removed some unused header files of vega10. https://lists.freedesktop.org/archives/amd-gfx/2017-November/016191.html In

[PATCH 03/16] drm/amd/include:cleanup vega10 mp header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/MP folder, remove mp_9_0_default.h Change-Id: Id53e6ab7a8bc78ff61457836b1b3ce499b158610 Signed-off-by: Feifei Xu Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c |4 +- drivers/gpu/drm/amd/amdgpu/soc15.c |4 +- .

[PATCH 07/16] drm/amd/include:cleanup vega10 dce header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/DC folder.Remove dce_12_0_default.h. Change-Id: I845e6551c6af8c01bf7964641cf89e8aa1658c11 Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c |4 +- .../amd/display/dc/dce120/dce120_hw_sequencer.c|4 +- .../drm/amd/display/dc/dce120

[PATCH 10/16] drm/amd/include:cleanup vega10 gc header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/GC folder. Signed-off-by: Feifei Xu Change-Id: I10b2a9a5a91748bae1973dbd266dfd2e6e429727 --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/gfxhub_v1_0.c| 6 +++--- drivers/gpu/drm/amd/

[PATCH 11/16] drm/amd/include:cleanup vega10 mmhub header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/MMHUB folder. Change-Id: I889fbb4893d4c682f32e0551004fb090dd9311da Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/mmhub_v1_0.c | 6 +++--- drivers/gpu/drm/amd/

[PATCH 15/16] drm/amd/include:cleanup vega10 osssys header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/OSSSYS folder. Change-Id: Ie794e8fc42b9b4451fc9016e4bbe9a9421a8097e Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/vega10_ih.c | 4 +- .../{vega10/OSSSYS => oss}/osssys_4_0_offset.h | 0 .../{vega10/OSSSYS => oss}/osssys_4_0_sh_mask.h| 0

[PATCH 13/16] drm/amd/include:cleanup vega10 nbif header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/NBIF folder. Change-Id: Iafd95103840eed8bcf0f2a7312fcbe85f4f99cd5 Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c |2 +- .../{vega10/NBIF => nbif}/nbif_6_1_offset.h|0 .../{vega10/NBIF => nbif}/nbif_6_1_sh_mask.h |

[PATCH 14/16] drm/amd/include:cleanup vega10 smuio header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/SMUIO folder. Change-Id: Iec10ed4cf8e967e1d12b8bfb15594abd9ecb309f Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/soc15.c | 4 +- .../{vega10/SMUIO => smuio}/smuio_9_0_offset.h | 0 .../{vega10/SMUIO => smuio}/smuio_9_0_sh_mask.h| 0

[PATCH 16/16] drm/amd/include:cleanup vega10 header files.

2017-11-23 Thread Feifei Xu
Remove asic_reg/vega10 folder. Change-Id: Ic8d6c3d8aab278fe7050147b3d8d097a45c0ef4b Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 +- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c| 4 ++-- drivers/gpu/drm/amd/amdgpu/gfxhub_v

[PATCH 02/16] drm/amd/include:cleanup vega10 hdp header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/HDP folder, remove hdp_4_0_default.h Change-Id: Ia7cd2e660ceb89a1096c195c6a67677714ccbd69 Signed-off-by: Feifei Xu Reviewed-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/gmc_v9_0

[PATCH 05/16] drm/amd/include:cleanup vega10 thm header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/THM folder. Change-Id: Ic4dcd42d5aaf9da38b936467bd340cd67b0235c6 Signed-off-by: Feifei Xu --- .../drm/amd/include/asic_reg/{vega10/THM => thm}/thm_9_0_default.h | 0 .../drm/amd/include/asic_reg/{vega10/THM => thm}/thm_9_0_offset.h | 0 .../drm/amd/include/asic_reg/{ve

[PATCH 06/16] drm/amd/include: cleanup vega10 umc header files.

2017-11-23 Thread Feifei Xu
Remove asic/vega10/UMC folder. Change-Id: Ic99f95e957c24cac3d5cb8768fa63452c8d1e505 Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +- .../gpu/drm/amd/include/asic_reg/{vega10/UMC => umc}/umc_6_0_default.h | 0 .../gpu/drm/amd/include/as

[PATCH 08/16] drm/amd/include:cleanup vega10 uvd header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/UVD folder,remove unused uvd_7_0_default.h. Change-Id: I859427f9dbf9fe96b36cd730b5cfa3b2224b5aab Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/soc15.c | 2 +- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 4 +- .../asic_reg/{vega10/UVD

[PATCH 09/16] drm/amd/include:cleanup vega10 vce header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/VCE folder. Change-Id: I60d71f93eecf4ecb3957d8ac18305641fe66b7f1 Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/uvd_v7_0.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/vce_v4_0.c | 6 +++--- .../drm/amd/includ

[PATCH 12/16] drm/amd/include:cleanup vega10 nbio header files.

2017-11-23 Thread Feifei Xu
Cleanup asic_reg/vega10/NBIO folder. Change-Id: I0c05dca48dbf027e0f3b57df58c4f764ee835c8d Signed-off-by: Feifei Xu --- drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/nbio_v6_1.c | 6 +++--- drivers/gpu/drm/amd

[PATCH] Revert "drm/amdgpu: fix rmmod KCQ disable failed error"

2017-11-23 Thread Monk Liu
This reverts commit ff8a0428d1b0e55db6b6e0462e2dc51c4d6724a8. this patch is incorrrect, amdgpu_ucode_bo_fini always called after gfx_hw_fini Change-Id: I7246ea0d2c7c843c14e9923c4d2efde4d90a9ef5 --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 3 --- drivers/gpu/drm/amd/amdgpu/amdgpu_powerplay