Re: [PATCH v4] drm/amd/powerplay: Remove unnecessary cast on void pointer

2017-10-22 Thread kbuild test robot
Hi Harsha, [auto build test ERROR on v4.14-rc3] [cannot apply to drm/drm-next next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Harsha-Sharma/drm-amd-powerplay-Remove-unnecessary-cas

Re: [pull] amdgpu dc drm-next-4.15-dc

2017-10-22 Thread Dieter Nützel
Am 21.10.2017 23:22, schrieb Alex Deucher: Hi Dave, Last batch of new stuff for DC. Highlights: - Fix some memory leaks - S3 fixes - Hotplug fixes - Fix some CX multi-display issues - MST fixes - DML updates from the hw team - Various code cleanups - Misc bug fixes Now this tree has the same f

Re: [amd-staging-drm-next] compilation error with latest commit #1b006d838f78

2017-10-22 Thread Dieter Nützel
Am 17.10.2017 16:59, schrieb Michel Dänzer: On 17/10/17 04:53 PM, Harry Wentland wrote: On 2017-10-17 10:47 AM, Michel Dänzer wrote: On 13/10/17 09:22 PM, Harry Wentland wrote: On 2017-10-12 08:22 PM, Dieter Nützel wrote: next (regression) compilation error: drivers/gpu/drm/amd/amdgpu/../di

Re: [pull] amdgpu dc drm-next-4.15-dc

2017-10-22 Thread Dieter Nützel
Am 22.10.2017 23:48, schrieb Dieter Nützel: Am 21.10.2017 23:22, schrieb Alex Deucher: Hi Dave, Last batch of new stuff for DC. Highlights: - Fix some memory leaks - S3 fixes - Hotplug fixes - Fix some CX multi-display issues - MST fixes - DML updates from the hw team - Various code cleanups -

[PATCH] drm/ttm:fix memory leak due to individualize

2017-10-22 Thread Monk Liu
Change-Id: I6d06b81b8b894775e55e495e96f3c999b83cf2be Signed-off-by: Monk Liu --- drivers/gpu/drm/ttm/ttm_bo.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index 97125cb..3c9c0d9 100644 --- a/drivers/gpu/drm/ttm

RE: [PATCH 3/3] drm/amdgpu: Fix deadlock during GPU reset.

2017-10-22 Thread Liu, Monk
Why not use a more simple way ? Like moving ttm_eu_fence_buffer_objects() to before amd_sched_entity_push_job() ? That could solve the deadlock from your description And the push order is already guaranteed by context->mutex (which is also a patch from you) BR Monk -Original Message

RE: [PATCH 2/3] drm/amdgpu: Add SPSC queue to scheduler.

2017-10-22 Thread Liu, Monk
If the deadlock issue could be solved I don't see why we give up kfifo and switch to SPSC .. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Andrey Grodzovsky Sent: 2017年10月20日 21:32 To: amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey

RE: [PATCH 3/5] drm/amdgpu:implement guilty pointer

2017-10-22 Thread Liu, Monk
Don't set this directly, make it a parameter of amd_sched_entity_init(). And please split up the patches differently. First all changes to the scheduler, including the guilty marking. Then the changes to amdgpu. [ML] that way the first patch will break kernel from compiling because you change

[PATCH 3/5] drm/amd/scheduler:introduce guilty pointer member

2017-10-22 Thread Monk Liu
this member will be used later, it will points to the real var inside of context and CS_SUBMIT & gpu schdduler can decide if skip a job depends on context->guilty or *entity->guilty Change-Id: I411e117a01c54286db0765fd2f6bf9d3bda01a3b Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 5/5] drm/amdgpu:skip job for guilty ctx in parser_init

2017-10-22 Thread Monk Liu
Change-Id: I44019f6475b1eaaba55633cf5f8bb84284f19a2c Signed-off-by: Monk Liu Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index f7

[PATCH 1/5] drm/amdgpu:cleanup job reset routine

2017-10-22 Thread Monk Liu
merge the setting guilty on context into this function to avoid implement extra routine. Change-Id: I7a0063464fdc85d5ac9080046380e745565ff540 Signed-off-by: Monk Liu Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c| 4 ++-- drivers/gpu/drm/amd/scheduler/gpu_sched

[PATCH 2/5] drm/amdgpu:add hang_limit for sched(v2)

2017-10-22 Thread Monk Liu
since gpu_scheduler source domain cannot access amdgpu variable so need create the hang_limit membewr for sched, and it can refer it for the upcoming GPU RESET patches v2: make hang_limit a parameter of sched_init() Change-Id: I977ae2717e55a8b87c59e58a288bffc3b458b653 Signed-off-by: Monk Liu Rev

[PATCH 4/5] drm/amdgpu:pass ctx->guilty address to entity init

2017-10-22 Thread Monk Liu
this way the real interested guilty is connected to entity->guilty pointer, and we can use entity->pointer later in gpu recovery procedure Change-Id: I09b392ebfc59254795e4fbd5816abd3d94a95853 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/am

RE: [PATCH 1/5] drm/amdgpu:cleanup job reset routine

2017-10-22 Thread Liu, Monk
Sorry, this patch is invalide, please ignore this one, will send out v2 for review -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Monk Liu Sent: 2017年10月23日 13:34 To: amd-gfx@lists.freedesktop.org Cc: Liu, Monk Subject: [PATCH 1/5] drm/amdgp

[PATCH] drm/amdgpu/psp: fix compile warnings on buffer address print

2017-10-22 Thread Evan Quan
drivers/gpu/drm/amd/amdgpu//psp_v3_1.c:389:13: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 4 has type ‘struct psp_gfx_rb_frame *’ [-Wformat=] DRM_ERROR("ring_buffer_start = %x; ring_buffer_end = %x; write_frame = %x\n", ^ ./include/drm/drmP.h:178:36: n

[PATCH 2/5] drm/amd/scheduler:introduce guilty pointer member

2017-10-22 Thread Monk Liu
this member will be used later, it will points to the real var inside of context and CS_SUBMIT & gpu schdduler can decide if skip a job depends on context->guilty or *entity->guilty Change-Id: I411e117a01c54286db0765fd2f6bf9d3bda01a3b Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu

[PATCH 5/5] drm/amdgpu:cleanup job reset routine(v2)

2017-10-22 Thread Monk Liu
merge the setting guilty on context into this function to avoid implement extra routine. v2: go through entity list and compare the fence_ctx before operate on the entity, otherwise the entity may be just a wild pointer Change-Id: I7a0063464fdc85d5ac9080046380e745565ff540 Signed-off-by: Monk Liu

[PATCH 3/5] drm/amdgpu:pass ctx->guilty address to entity init

2017-10-22 Thread Monk Liu
this way the real interested guilty is connected to entity->guilty pointer, and we can use entity->pointer later in gpu recovery procedure Change-Id: I09b392ebfc59254795e4fbd5816abd3d94a95853 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 + drivers/gpu/drm/amd/amdgpu/am

[PATCH 1/5] drm/amdgpu:add hang_limit for sched(v2)

2017-10-22 Thread Monk Liu
since gpu_scheduler source domain cannot access amdgpu variable so need create the hang_limit membewr for sched, and it can refer it for the upcoming GPU RESET patches v2: make hang_limit a parameter of sched_init() Change-Id: I977ae2717e55a8b87c59e58a288bffc3b458b653 Signed-off-by: Monk Liu Rev

[PATCH 4/5] drm/amdgpu:skip job for guilty ctx in parser_init

2017-10-22 Thread Monk Liu
Change-Id: I44019f6475b1eaaba55633cf5f8bb84284f19a2c Signed-off-by: Monk Liu Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index a7

[PATCH] drm/amd/scheduler:fix duplicate operation in entity fini

2017-10-22 Thread Monk Liu
no need to manually cleanup job and fence after sched_fence_finish(), they are auto handled by the callback Change-Id: I9da26064c9e73c178949663bed1e490539e95e41 Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff