Am 18.10.2017 um 02:56 schrieb Pixel Ding:
From: pding
Register accessing is performed when IRQ is disabled. Never sleep in
this function.
Known issue: dead sleep in many use cases of index/data registers.
v2: wrap polling fence functions. don't trigger IRQ for polling in
case of wrongly fenc
Thanks Christian:) will change the return value as you suggested.
—
Sincerely Yours,
Pixel
On 18/10/2017, 3:05 PM, "Koenig, Christian" wrote:
>Am 18.10.2017 um 02:56 schrieb Pixel Ding:
>> From: pding
>>
>> Register accessing is performed when IRQ is disabled. Never sleep in
>> this fun
Yeah, we already stumbled over that internally as well.
The patch is incorrect, the problem is that we forgot to keep an extra
reference on the s_fence to avoid freeing it to early.
The correct fix should be on Alex public branch by the end of today.
Regards,
Christian.
Am 17.10.2017 um 20:4
Hi Christian,
Would you please take a look at this change? It’s to unify the VBIOS post
checking.
—
Sincerely Yours,
Pixel
On 18/10/2017, 10:25 AM, "Ding, Pixel" wrote:
>Hi all,
>
>Could someone review this patch?
>
>—
>Sincerely Yours,
>Pixel
>
>
>
>
>
>
>
>On 17/10/2017, 4:06 PM, "
I've already did, but honestly have no idea what you do here.
ASIC post is not something I've every worked on.
It looks odd that you add/remove some static keyword here, but I can't
judge the technical correctness.
Monk, Alex what do you think of this?
Sorry,
Christian.
Am 18.10.2017 um 09:
with current WB usage we only use 57 slots, so 512
is extreamly sufficient, and reduce to 512 can
make WB fit into one page.
Change-Id: I4261630731f132b9bec91b0037e914030b5c031f
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
previously a path moves ucode_init_bo to amdgpu_device_init
but this cause regression:
the regression that MEC enabling will fail after gpu reset,
the reason is after gpu reset (at least from VF FLR) the firmware
buf that MEC use is somehow changed by PSP hw, so without calling
this ucode_init_bo
otherwise after VF FLR the KIQ cannot work
Change-Id: Icb18e794b5e4dccfd70c811c138c7102df874203
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdg
it should not work on non-SR-IOV case
Change-Id: Icf34f88a0642e4b04c857a07b72df3bb772075d6
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_vf_error.c | 7 ++-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git
Change-Id: Iafe294aea66ae0c140af062ec78321c22a74e615
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index fec60bc9..ee3846c 10064
Change-Id: I7a29e1533fb3deb476bc0f3dba0f8b2e25baf8c1
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
b/drivers/gpu/drm/a
Change-Id: I6d50cc769ee29bf13524c83105d5004b0a2d85e3
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index ee3846
Am 18.10.2017 um 10:48 schrieb Monk Liu:
with current WB usage we only use 57 slots, so 512
is extreamly sufficient, and reduce to 512 can
make WB fit into one page.
Change-Id: I4261630731f132b9bec91b0037e914030b5c031f
Signed-off-by: Monk Liu
Reviewed-by: Christian König
---
drivers/gpu/
Am 18.10.2017 um 10:48 schrieb Monk Liu:
Change-Id: I7a29e1533fb3deb476bc0f3dba0f8b2e25baf8c1
Signed-off-by: Monk Liu
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 1 -
drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 2 +-
2 files changed, 1 insertion(+), 2 deleti
Am 18.10.2017 um 10:48 schrieb Monk Liu:
Change-Id: Iafe294aea66ae0c140af062ec78321c22a74e615
Signed-off-by: Monk Liu
#1 and #4 in this series have my rb.
Can't say much about the rest, but feel free to add my Acked-by to them.
Regards,
Christian.
---
drivers/gpu/drm/amd/amdgpu/amdgpu_de
yeah, this patch is correct
From: Koenig, Christian
Sent: Wednesday, October 18, 2017 3:23:04 PM
To: Ding, Pixel; Liu, Monk; amd-gfx@lists.freedesktop.org
Cc: Sun, Gary; Li, Bingley
Subject: Re: [PATCH 1/3] drm/amdgpu: always consider virualised device for
checkin
Sorry for the confusion, while I still believe this is the right way to go.
amdgpu_need_post and amdgpu_vpost_needed both try to check the VBIOS posting,
amdgpu_need_post doesn’t consider VF/PT devices. They were both in use.
This patch is to unify these 2 functions to single one and always cons
fw ucode is corrupted after vf flr by PSP so ucode_init() is
a must in psp_hw_init othewise KIQ/KCQ enabling will fail
Revert "drm/amdgpu: refine code delete duplicated error handling"
This reverts commit e57b87ff828f95efe992468e6d18c2c059b27aa9.
Revert "drm/amdgpu: move amdgpu_ucode_init_bo to am
yeah, that way another of my fix patch is not neede
Reviewed-by: Monk Liu
BR Monk
From: amd-gfx on behalf of Rex Zhu
Sent: Wednesday, October 18, 2017 5:29:39 PM
To: amd-gfx@lists.freedesktop.org
Cc: Zhu, Rex
Subject: [PATCH] drm/amdgpu: fix regresstion on
Change-Id: I9e72043ea619a86b2bcf14ce9d6386fee107bd19
Signed-off-by: Rex Zhu
---
drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
b/drivers/gpu/drm/amd/powerplay/hwmgr/ve
it should not work on non-SR-IOV case
Change-Id: Icf34f88a0642e4b04c857a07b72df3bb772075d6
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++
drivers/gpu/drm/amd/amdgpu/amdgpu_vf_error.c | 7 ++-
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git
otherwise after VF FLR the KIQ cannot work
Change-Id: Icb18e794b5e4dccfd70c811c138c7102df874203
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdg
Change-Id: I6d50cc769ee29bf13524c83105d5004b0a2d85e3
Signed-off-by: Monk Liu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index c43f8d
can you help review those three patches ?
1/3 now must reinit psp
2/3 fix vf_error_put
3/3 fix wb_clear
the first two are only SRIOV affected, at least some one give me an ACK-by
From: amd-gfx on behalf of Monk Liu
Sent: Wednesday, October 18, 2017 5:59:1
Hi everyone,
This is the ninth and hopefully last incarnation of this set of patches. It
enables device drivers to resize and most likely also relocate the PCI BAR of
devices they manage to allow the CPU to access all of the device local memory
at once.
This is very useful for GFX device drivers
From: Christian König
Most BIOS don't enable this because of compatibility reasons.
Manually enable a 64bit BAR of 64GB size so that we have
enough room for PCI devices.
v2: style cleanups, increase size, add resource name, set correct flags,
print message that windows was added
v3: add def
From: Christian König
Just the defines and helper functions to read the possible sizes of a BAR and
update it's size.
See
https://pcisig.com/sites/default/files/specification_documents/ECN_Resizable-BAR_24Apr2008.pdf
and PCIe r3.1, sec 7.22.
This is useful for hardware with large local storage
From: Christian König
Try to resize BAR0 to let CPU access all of VRAM.
v2: rebased, style cleanups, disable mem decode before resize,
handle gmc_v9 as well, round size up to power of two.
v3: handle gmc_v6 as well, release and reassign all BARs in the driver.
v4: rename new function to amdg
From: Christian König
This allows device drivers to request resizing their BARs.
The function only tries to reprogram the windows of the bridge directly above
the requesting device and only the BAR of the same type (usually mem, 64bit,
prefetchable). This is done to make sure not to disturb othe
From: Christian König
We use this mask multiple times in the bus setup.
v2: fix some style nit picks
Signed-off-by: Christian König
Reviewed-by: Andy Shevchenko
---
drivers/pci/pci.h | 3 +++
drivers/pci/setup-bus.c | 12 +++-
2 files changed, 6 insertions(+), 9 deletions(-)
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Rex Zhu
> Sent: Wednesday, October 18, 2017 2:36 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Zhu, Rex
> Subject: [PATCH] drm/amd/pp: thermal control not enabled on vega10.
>
> regresstion is
> Thanks Felix.
> I'll add it to the next tree instead of the one from the patch-set.
>
> Oded
I based this patch on your current amdkfd-next. Do you have another "next tree"?
Regards,
Felix
-Original Message-
From: Oded Gabbay [mailto:oded.gab...@gmail.com]
Sent: Wednesday, October
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Christian König
> Sent: Wednesday, October 18, 2017 3:23 AM
> To: Ding, Pixel; Liu, Monk; amd-gfx@lists.freedesktop.org
> Cc: Sun, Gary; Li, Bingley
> Subject: Re: [PATCH 1/3] drm/amdgpu: alwa
Hi Dave, Mark,
This branch against Linus' 4.14-rc4 contains the 3 pre-requisite patches
for Stoney ACP audio. Mark needs these patches to apply the rest of the
Stoney ACP patch set on the audio side. I'll resend the stony audio patches
shortly, but there are no differences from the last version
On 13/10/17 10:19 AM, Christian König wrote:
> Am 13.10.2017 um 09:41 schrieb Michel Dänzer:
>> On 12/10/17 07:49 PM, Alex Deucher wrote:
>>> On Thu, Oct 12, 2017 at 1:02 PM, Christian König
>>> wrote:
Am 12.10.2017 um 18:20 schrieb Michel Dänzer:
> On 12/10/17 05:58 PM, Alex Deucher wrot
From: Akshu Agrawal
The driver is used for AMD board using rt5650 codec.
Reviewed-by: Alex Deucher
Signed-off-by: Akshu Agrawal
Signed-off-by: Alex Deucher
Signed-off-by: Dylan Reid
---
v2: Change ACPI ID to AMDI1002
v3: add R-b, resend
v4: Fix audio jack issue (Dylan Reid)
Fix Kconfig
From: Vijendar Mukunda
Added DMA driver changes for Stoney platform.
Below are the key differences between Stoney and CZ
In Stoney, Memory Gating is disabled.SRAM Banks won't
be turned off.No Of SRAM Banks reduced to 6.
DAGB Garlic Interface used and 16 bit resolution is supported.
SRAM bank 1 &
From: Vijendar Mukunda
For Stoney platform, Memory gating is disabled.i.e SRAM Banks
won't be turned off. By Default, SRAM Bank state set to ON.
Added condition checks to skip SRAM Bank state set logic for
Stoney platform.
Acked-by: Mark Brown
Reviewed-by: Alex Deucher
Signed-off-by: Vijendar
From: Vijendar Mukunda
Stoney uses 16kb SRAM memory for playback and 16Kb
for capture.Modified Max buffer size to have the
correct mapping between System Memory and SRAM.
Added snd_pcm_hardware structures for playback
and capture for Stoney.
Reviewed-by: Alex Deucher
Signed-off-by: Vijendar Mu
This patch set updates the AMD GPU and Audio CoProcessor (ACP)
audio drivers and the designware i2s driver for Stoney (ST).
ST is an APU similar to Carrizo (CZ) which already has ACP audio
support. The i2s controller and ACP audio DMA engine are part of
the GPU and both need updating so I would li
> -Original Message-
> From: Michel Dänzer [mailto:mic...@daenzer.net]
> Sent: Wednesday, October 18, 2017 12:06 PM
> To: Koenig, Christian; Alex Deucher
> Cc: Deucher, Alexander; Dave Airlie; amd-gfx list; Maling list - DRI
> developers
> Subject: Re: [pull] amdgpu drm-fixes-4.14
>
> On
Hi Dave,
Just one revert to fix a stability regression.
The following changes since commit 2de0307323fc42c6395d0eafec9879d55e042c85:
Merge tag 'exynos-drm-fixes-for-v4.14-rc5' of
git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos into drm-fixes
(2017-10-17 10:14:56 +1000)
are
On Wed, Oct 18, 2017 at 5:45 AM, Rex Zhu wrote:
> Change-Id: I9e72043ea619a86b2bcf14ce9d6386fee107bd19
> Signed-off-by: Rex Zhu
Please include a better patch description. E.g., Clear the count in
the single table setup function to avoid missing any tables.
or something like that. With that fix
On Wed, Oct 18, 2017 at 4:52 AM, Monk Liu wrote:
> Change-Id: I6d50cc769ee29bf13524c83105d5004b0a2d85e3
> Signed-off-by: Monk Liu
Please include a better patch description. Something like:
Properly shift the index when clearing so we clear the right bit.
With that fixed:
Reviewed-by: Alex Deuc
From: pding
The post checking on scratch registers isn't reliable for virtual function.
v2: only change in IGP reading bios.
Signed-off-by: pding
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 1 +
drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 2 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
Hi Alex,
This is the v2 patch as you suggested. Only fix the issue found in
amdgpu_bios.c.
Please review, thanks.
—
Sincerely Yours,
Pixel
On 19/10/2017, 9:44 AM, "amd-gfx on behalf of Pixel Ding"
wrote:
>From: pding
>
>The post checking on scratch registers isn't reliable for virt
On Wed, Oct 18, 2017 at 9:44 PM, Pixel Ding wrote:
> From: pding
>
> The post checking on scratch registers isn't reliable for virtual function.
>
> v2: only change in IGP reading bios.
Subject has "drm/amdgpu: drm/amdgpu: " drop one of them.
>
> Signed-off-by: pding
> ---
> drivers/gpu/drm
On Wed, Oct 18, 2017 at 4:48 AM, Monk Liu wrote:
> otherwise after VF FLR the KIQ cannot work
>
> Change-Id: Icb18e794b5e4dccfd70c811c138c7102df874203
> Signed-off-by: Monk Liu
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 +
> 1 file changed, 1 insertion(+)
On Wed, Oct 18, 2017 at 5:59 AM, Monk Liu wrote:
> it should not work on non-SR-IOV case
>
> Change-Id: Icf34f88a0642e4b04c857a07b72df3bb772075d6
> Signed-off-by: Monk Liu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 7 +++
> drivers/gpu/drm/amd/amdgpu/amdgpu_vf_error.c | 7 ++-
Thanks Alex. Some comments inline.
—
Sincerely Yours,
Pixel
On 19/10/2017, 10:34 AM, "Alex Deucher" wrote:
>On Wed, Oct 18, 2017 at 9:44 PM, Pixel Ding wrote:
>> From: pding
>>
>> The post checking on scratch registers isn't reliable for virtual function.
>>
>> v2: only change in IGP r
On Wed, Oct 18, 2017 at 11:09 PM, Ding, Pixel wrote:
> Thanks Alex. Some comments inline.
> —
> Sincerely Yours,
> Pixel
>
>
>
>
>
>
>
>
> On 19/10/2017, 10:34 AM, "Alex Deucher" wrote:
>
>>On Wed, Oct 18, 2017 at 9:44 PM, Pixel Ding wrote:
>>> From: pding
>>>
>>> The post checking on scratch r
Hi Alex,
This change only affect virtualization and doesn’t change any code path of
baremetal, and I have the virtualization test passed.
As we discussed in the v2 patch, merge 2 bios post checking function. Can I
have your review for the v1? Or do you like to keep the amdgpu_vpost_needed()
fu
> -Original Message-
> From: Ding, Pixel
> Sent: Wednesday, October 18, 2017 11:23 PM
> To: Deucher, Alexander; Koenig, Christian; Liu, Monk; amd-
> g...@lists.freedesktop.org
> Cc: Sun, Gary; Li, Bingley
> Subject: Re: [PATCH 1/3] drm/amdgpu: always consider virualised device for
> checkin
From: pding
v2:
- only change in IGP reading bios.
v3:
- merge functions and apply on all bios checking.
Signed-off-by: pding
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 41 +-
1 file changed, 18 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/am
54 matches
Mail list logo
