[PATCH] drm/amd/display: Don't leak dc_stream_state.

2017-09-09 Thread Darren Salt
Noticed while playing “Valley”, which was causing some 8MB of leakage per second. kmemleak listed many entries looking like this: unreferenced object 0x8802c2951800 (size 1024): comm "Xorg", pid 2982, jiffies 4297410155 (age 392.787s) hex dump (first 32 bytes): 00 50 f9

[PATCH] drm/amdkfd: check for null dev to avoid a null pointer dereference

2017-09-09 Thread Colin King
From: Colin Ian King The call to kfd_device_by_id can potentially return null, so check that dev is null and return with -EINVAL to avoid a null pointer dereference. Detected by CoverityScan CID#1454629 ("Dereference null return value") Fixes: 5d71dbc3a588 ("drm/amdkfd: Implement image tiling m

[libdrm 2.4.83, Linux 4.9.43] Test: Command submission Test (Multi-Fence) ...FAILED

2017-09-09 Thread Paul Menzel
Dear AMDGPU folks, Using Linux 4.9.43, libdrm 2.4.83, and running the libdrm tests from master, I get one failure. ``` $ git log --oneline -1 d55d0804 (HEAD -> master, origin/master, origin/HEAD) amdgpu: Do not write beyond allocated memory when parsing ids $ sudo tests/amdgpu/amdgpu_test -

[PATCH] drm/amdgpu/gfx9: implement wave VGPR reading

2017-09-09 Thread Nicolai Hähnle
From: Nicolai Hähnle This is already hooked up to the "amdgpu_gpr" debugfs file used by the umr userspace debugging tool. Signed-off-by: Nicolai Hähnle --- drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.

[PATCH umr 4/4] Fix the no-kernel case of wave SGPR reading

2017-09-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Signed-off-by: Nicolai Hähnle --- src/lib/read_gpr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/read_gpr.c b/src/lib/read_gpr.c index 669a49b..e6138a9 100644 --- a/src/lib/read_gpr.c +++ b/src/lib/read_gpr.c @@ -68,21 +68,21 @@ int umr_read_

[PATCH umr 2/4] Rename lib/read_sgpr.c to lib/read_gpr.c

2017-09-09 Thread Nicolai Hähnle
From: Nicolai Hähnle We will implement VGPR reading, hence this is a better name. Signed-off-by: Nicolai Hähnle --- src/lib/CMakeLists.txt | 2 +- src/lib/{read_sgpr.c => read_gpr.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename src/lib/{read_sgpr.c => read_gpr.c} (1

[PATCH umr 0/4] gfx9: read VGPRs of halted waves

2017-09-09 Thread Nicolai Hähnle
Hi all, it seems that reading wave VGPRs actually works now with gfx9, at least for halted waves, and that can be pretty powerful for debugging. Due to the volume of data it prints out, it's only enabled with -O bits. In order for it to work properly, you'll also need the kernel patch I just sen

[PATCH umr 1/4] Fix wave SGPR reading

2017-09-09 Thread Nicolai Hähnle
From: Nicolai Hähnle The hardware adds the alloc base already, no need to do it in the tool. Signed-off-by: Nicolai Hähnle --- src/app/print_waves.c | 8 src/lib/read_sgpr.c | 5 +++-- 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/app/print_waves.c b/src/app/pri

[PATCH umr 3/4] Read VGPRs of halted waves on gfx9

2017-09-09 Thread Nicolai Hähnle
From: Nicolai Hähnle Signed-off-by: Nicolai Hähnle --- src/app/print_waves.c | 40 +++- src/lib/read_gpr.c| 30 ++ src/umr.h | 1 + 3 files changed, 70 insertions(+), 1 deletion(-) diff --git a/src/app/print_wave

Re: [PATCH umr 0/4] gfx9: read VGPRs of halted waves

2017-09-09 Thread Tom St Denis
Hi Nicolai, Patches look good I'll give them a whirl tomorrow when I have some free time. I'll have to dig out your headless piglit instructions since I still can't bring X up on my Raven board. Also I noticed the use of "(options.bitfields)" (etc, in print_waves) which is not your bug (sin