Re: Shared semaphores for amdgpu

On 9 March 2017 at 17:38, Christian König wrote: >> I do wonder if we need the separate sem signal/wait interface, I think >> we should just add >> semaphore chunks to the CS interface. > > Yeah, that's what I've said as well from the very first beginning. > > Another question is if we should real

Re: Shared semaphores for amdgpu

Am 09.03.2017 um 09:15 schrieb Dave Airlie: On 9 March 2017 at 17:38, Christian König wrote: I do wonder if we need the separate sem signal/wait interface, I think we should just add semaphore chunks to the CS interface. Yeah, that's what I've said as well from the very first beginning. Anoth

Re: [PATCH 1/2] drm/amdgpu: validate paramaters in the gem ioctl

Am 09.03.2017 um 00:18 schrieb Alex Deucher: Reject it if there are any invalid flags or domains. Signed-off-by: Alex Deucher Reviewed-by: Christian König for both patches. --- drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 21 + 1 file changed, 21 insertions(+) diff --g

Re: [PATCH 01/23] drm/amdgpu: init aperture definitions

Am 09.03.2017 um 04:44 schrieb Alex Deucher: From: Junwei Zhang Signed-off-by: Flora Cui Reviewed-by: Jammy Zhou Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.h | 6 ++ drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 24 +

Re: [PATCH 02/23] drm/amdgpu: change wptr to 64 bits

Am 09.03.2017 um 04:44 schrieb Alex Deucher: From: Ken Wang Newer asics use 64 bit wptrs We need a better patch description. Newer asics doesn't use 64bit wptrs, but rather need them! E.g. if the wptr is now smaller than the rptr that doesn't indicate a wrap around any more. Signed-of

Re: [PATCH 05/23] drm/amdgpu: switch ih handling to two levels

Am 09.03.2017 um 04:44 schrieb Alex Deucher: Newer asics have a two levels of irq ids now: client id - the IP src id - the interrupt src within the IP Signed-off-by: Alex Deucher Signed-off-by: Ken Wang Reviewed-by: Ken Wang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [PATCH 11/23] drm/amdgpu: check function points valid before use.

Am 09.03.2017 um 04:44 schrieb Alex Deucher: From: Rex Zhu Signed-off-by: Rex Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/driv

Re: [PATCH 00/23] Prep patches for new asics

Patches #3, #4, #12, #15 - #23 are Reviewed-by: Christian König . Patch #8, #13, #14 are Acked-by: Christian König . The rest I've either send comments for or are already Reviewed by me. Regards, Christian. Am 09.03.2017 um 04:44 schrieb Alex Deucher: This set of patches updates various infr

Re: Shared semaphores for amdgpu

On 2017年03月09日 17:12, Christian König wrote: Am 09.03.2017 um 09:15 schrieb Dave Airlie: On 9 March 2017 at 17:38, Christian König wrote: I do wonder if we need the separate sem signal/wait interface, I think we should just add semaphore chunks to the CS interface. Yeah, that's what I've sa

Re: Shared semaphores for amdgpu

Am 09.03.2017 um 10:43 schrieb zhoucm1: On 2017年03月09日 17:12, Christian König wrote: Am 09.03.2017 um 09:15 schrieb Dave Airlie: On 9 March 2017 at 17:38, Christian König wrote: I do wonder if we need the separate sem signal/wait interface, I think we should just add semaphore chunks to th

Re: [PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

On Wed, Mar 08, 2017 at 03:34:47PM -0500, Alex Deucher wrote: > On Wed, Mar 8, 2017 at 12:01 AM, Lukas Wunner wrote: > > On Tue, Mar 07, 2017 at 03:30:30PM -0500, Alex Deucher wrote: > >> On Fri, Feb 24, 2017 at 2:19 PM, Lukas Wunner wrote: > >> > An external Thunderbolt GPU can neither drive the

Re: [PATCH 4/4] drm/amdgpu:enable MCBP for SR-IOV

You need a commit message here. Something like "apply the new IB flag during command submission". Am 08.03.2017 um 08:54 schrieb Monk Liu: Change-Id: I779abc6a47593be0ff5234c3e2f2cdfd25ba70ca Signed-off-by: Monk Liu --- drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 4 1 file changed, 4 inser

Re: 答复: [PATCH 4/4] drm/amdgpu:enable MCBP for SR-IOV

Sorry my spam filter completely blocked this set, not idea why. Did send out a review about a minute ago. Christian. Am 09.03.2017 um 05:19 schrieb Liu, Monk: Anyone review the 4 patches and another libdrm patch ? -邮件原件- 发件人: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] 代表

Re: [PATCH 4/5] drm/radeon: Don't register Thunderbolt eGPU with vga_switcheroo

On Thu, Mar 9, 2017 at 5:55 AM, Lukas Wunner wrote: > On Wed, Mar 08, 2017 at 03:34:47PM -0500, Alex Deucher wrote: >> On Wed, Mar 8, 2017 at 12:01 AM, Lukas Wunner wrote: >> > On Tue, Mar 07, 2017 at 03:30:30PM -0500, Alex Deucher wrote: >> >> On Fri, Feb 24, 2017 at 2:19 PM, Lukas Wunner wrote

Re: [PATCH xf86-video-amdgpu 2/2] Pass TRUE to drmmode_set_desired_modes the first time for GPU screens

On Thu, Mar 9, 2017 at 2:03 AM, Michel Dänzer wrote: > From: Michel Dänzer > > This is the only place we call drmmode_set_desired_modes for GPU screens > during server startup. Without this change, the display outputs of > secondary GPUs may stay on even while Xorg isn't using them. > > (Ported f

[PATCH umr] Clean up depth1 decoding and add depth0 decoding.

Now you can do cool things like umr -v 0@`umr -r *.*.mmUVD_LMI_RBC_RB_64BIT_BAR_LOW` 100 To read (in this case) the first 256 bytes of the UVD ring buffer. Signed-off-by: Tom St Denis --- src/lib/read_vram.c | 40 +--- 1 file changed, 29 insertions(+), 11 de

Re: [PATCH 0/5] Thunderbolt GPU fixes

On Fri, Feb 24, 2017 at 08:19:45PM +0100, Lukas Wunner wrote: > Fix Thunderbolt-related issues in apple-gmux and vga_switcheroo: > > Patch [1/5] ("Recognize Thunderbolt devices") has already been subjected > to a fair amount of scrutiny over at linux-pci@, I've submitted it 5 times > total since M

[PATCH 02/23] drm/amdgpu: change wptr to 64 bits (v2)

From: Ken Wang Newer asics need 64 bit wptrs. If the wptr is now smaller than the rptr that doesn't indicate a wrap-around anymore. v2: integrate Christian's comments. Signed-off-by: Ken Wang Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h

[PATCH 03/23] drm/amdgpu: add 64bit wb functions

From: Ken Wang Newer asics need 64 bit writeback slots. Reviewed-by: Christian König Signed-off-by: Ken Wang Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 2 ++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 39 +++

[PATCH 08/23] drm/amdgpu: add a ucode size member into firmware info

From: Huang Rui This will be used for newer asics. Acked-by: Christian König Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 7 +-- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 2 ++ 2 files changed, 7 inserti

[PATCH 11/23] drm/amdgpu: check function points valid before use. (v2)

From: Rex Zhu v2: agd: integrate Christian's comments. Signed-off-by: Rex Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c

[PATCH 10/23] drm/amdgpu: add a callback to set vm mapping flags

From: Alex Xie This lets each asic set whichever flags it supports. Signed-off-by: Alex Xie Reviewed-by: Alex Deucher Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 12 +++- d

[PATCH 06/23] drm/amdgpu/ih: store the full context id

The contextID field (formerly known as src_data) of the IH vector stores client specific information about an interrupt. It was expanded from 32 bits to 128 on newer asics. Expand the src_id field to handle this. Reviewed-by: Harry Wentland Reviewed-by: Christian König Signed-off-by: Alex Deuch

[PATCH v2 00/23] Prep patches for new asics

This set of patches updates various infrastructure in the driver to support new asics. v2: integrate comments and reviews. Alex Deucher (3): drm/amdgpu: switch ih handling to two levels (v2) drm/amdgpu/ih: store the full context id drm/amdgpu: add asic callback to get memsize register Alex

[PATCH 17/23] drm/amdgpu: move amdgpu_vce structure to vce header

From: Leo Liu Reviewed-by: Christian König Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 29 + drivers/gpu/drm/amd/amdgpu/amdgpu_vce.h | 25 + 2 files changed, 26

[PATCH 22/23] drm/amdgpu: add AMDGPU_HW_IP_UVD_ENC to info query

From: Leo Liu Reviewed-by: Christian König Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c b/drivers/gpu/drm/amd/a

[PATCH 23/23] drm/amdgpu: get cs support of AMDGPU_HW_IP_UVD_ENC

From: Leo Liu Reviewed-by: Christian König Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu

[PATCH 05/23] drm/amdgpu: switch ih handling to two levels (v2)

Newer asics have a two levels of irq ids now: client id - the IP src id - the interrupt src within the IP v2: integrated Christian's comments. Signed-off-by: Alex Deucher Signed-off-by: Ken Wang Reviewed-by: Ken Wang Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c |

[PATCH 07/23] drm/amdgpu: expand pte flags to uint64_t

From: Chunming Zhou Necessary for new asics. Signed-off-by: Chunming Zhou Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 8 drivers/gpu/drm/amd/amdgpu/amdgpu_gart.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 6 +++

[PATCH 20/23] drm/amdgpu: add uvd enc ring type and functions

From: Leo Liu Reviewed-by: Christian König Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h b/drivers/gpu/d

[PATCH 09/23] drm/amdgpu: set GART PTE asic specific flags

From: Alex Xie Set asic specific gart pte flags in the gmc IP module for each asic. Signed-off-by: Alex Xie Reviewed-by: Alex Deucher Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 4 drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 4 +

[PATCH 04/23] drm/amdgpu: add 64bit doorbell functions (v2)

From: Ken Wang Newer asics need 64 bit doorbells. v2: fix comment (Nils) Reviewed-by: Christian König Signed-off-by: Ken Wang Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 4 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 38

[PATCH 01/23] drm/amdgpu: init aperture definitions (v2)

From: Junwei Zhang v2: agd: move apertures to mc structure Signed-off-by: Flora Cui Reviewed-by: Jammy Zhou Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 5 + drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 24 +--- driver

[PATCH 18/23] drm/amdgpu: add uvd enc rings

From: Leo Liu And initialize them Reviewed-by: Christian König Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 3 ++- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-)

[PATCH 12/23] drm/amdgpu: add asic callback to get memsize register

Newer asics use different registers so abstract it. Reviewed-by: Christian König Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h| 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +- drivers/gpu/drm/amd/amdgpu/cik.c | 6 ++ drivers/gpu/drm/amd/amdg

[PATCH 16/23] drm/amdgpu: move amdgpu_uvd structure to uvd header

From: Leo Liu Reviewed-by: Christian König Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu.h | 30 +- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h | 26 ++ 2 files changed, 2

[PATCH 15/23] drm/amdgpu: add a ring func for end command

From: Leo Liu Reviewed-by: Christian König Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 3 +++ drivers/gpu/drm/amd/amdgpu/amdgpu_ring.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/gpu/drm/amd/amd

[PATCH 13/23] drm/amdgpu: add DRM MGCG header

From: Huang Rui Acked-by: Christian König Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/am

[PATCH 21/23] uapi/drm: add AMDGPU_HW_IP_UVD_ENC

From: Leo Liu Reviewed-by: Christian König Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- include/uapi/drm/amdgpu_drm.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/uapi/drm/amdgpu_drm.h b/include/uapi/drm/amdgpu_drm.h index

[PATCH 14/23] drm/amdgpu: add DF MGCG flag

From: Huang Rui Acked-by: Christian König Signed-off-by: Huang Rui Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/include/amd_shared.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/am

[PATCH 19/23] drm/amdgpu: add uvd enc run queue

From: Leo Liu Reviewed-by: Christian König Signed-off-by: Leo Liu Reviewed-by: Alex Deucher Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.h b/drivers/gpu/drm/amd/amdgpu/amdgpu

Re: [PATCH 11/23] drm/amdgpu: check function points valid before use. (v2)

Am 09.03.2017 um 16:25 schrieb Alex Deucher: From: Rex Zhu v2: agd: integrate Christian's comments. Signed-off-by: Rex Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --

Re: [PATCH v2 00/23] Prep patches for new asics

Patch #1 is Acked-by: Christian König . Patch #2 and #5 are Reviewed-by: Christian König . One more comment on patch #11 and I didn't miss anything, did I? Christian. Am 09.03.2017 um 16:25 schrieb Alex Deucher: This set of patches updates various infrastructure in the driver to support new a

Re: [PATCH 11/23] drm/amdgpu: check function points valid before use. (v2)

On Thu, Mar 9, 2017 at 10:53 AM, Christian König wrote: > Am 09.03.2017 um 16:25 schrieb Alex Deucher: >> >> From: Rex Zhu >> >> v2: agd: integrate Christian's comments. >> >> Signed-off-by: Rex Zhu >> Signed-off-by: Alex Deucher >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 26 >> ++

Re: [PATCH v2 00/23] Prep patches for new asics

On Thu, Mar 9, 2017 at 10:55 AM, Christian König wrote: > Patch #1 is Acked-by: Christian König . > > Patch #2 and #5 are Reviewed-by: Christian König . > > One more comment on patch #11 and I didn't miss anything, did I? Nope, I think that's it. Alex > > Christian. > > > Am 09.03.2017 um 16:25

Re: [PATCH 11/23] drm/amdgpu: check function points valid before use. (v2)

Am 09.03.2017 um 16:57 schrieb Alex Deucher: On Thu, Mar 9, 2017 at 10:53 AM, Christian König wrote: Am 09.03.2017 um 16:25 schrieb Alex Deucher: From: Rex Zhu v2: agd: integrate Christian's comments. Signed-off-by: Rex Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amd

Re: [PATCH 11/23] drm/amdgpu: check function points valid before use. (v2)

On Thu, Mar 9, 2017 at 11:50 AM, Christian König wrote: > Am 09.03.2017 um 16:57 schrieb Alex Deucher: >> >> On Thu, Mar 9, 2017 at 10:53 AM, Christian König >> wrote: >>> >>> Am 09.03.2017 um 16:25 schrieb Alex Deucher: From: Rex Zhu v2: agd: integrate Christian's comments.

[PATCH] drm/amdgpu: check function points valid before use. (v3)

From: Rex Zhu v2: agd: integrate Christian's comments. v3: print error message if call fails Signed-off-by: Rex Zhu Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 32 +- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/d

[PATCH] drm/amd/amdgpu: Disable GFX_PG on Carrizo until compute issues solved

Currently compute jobs will stall if GFX_PG is enabled. Until this is resolved we'll disable GFX_PG. Signed-off-by: Tom St Denis --- drivers/gpu/drm/amd/amdgpu/vi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/v

Re: [PATCH] drm/amdgpu: check function points valid before use. (v3)

Am 09.03.2017 um 18:04 schrieb Alex Deucher: From: Rex Zhu v2: agd: integrate Christian's comments. v3: print error message if call fails Signed-off-by: Rex Zhu Signed-off-by: Alex Deucher Reviewed-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 32 +++

RE: [PATCH] drm/amd/amdgpu: Disable GFX_PG on Carrizo until compute issues solved

> -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Tom St Denis > Sent: Thursday, March 09, 2017 1:22 PM > To: amd-gfx@lists.freedesktop.org > Cc: StDenis, Tom > Subject: [PATCH] drm/amd/amdgpu: Disable GFX_PG on Carrizo until > compute issues

[pull] amdgpu drm-fixes-4.11

Hi Dave, A few fixes for 4.11. The following changes since commit c1ae3cfa0e89fa1a7ecc4c99031f5e9ae99d9201: Linux 4.11-rc1 (2017-03-05 12:59:56 -0800) are available in the git repository at: git://people.freedesktop.org/~agd5f/linux drm-fixes-4.11 for you to fetch changes up to a5b11dac1f

Re: Shared semaphores for amdgpu

> Completely agree, problem here is that this isn't documented like this in > the Vulkan specification as far as I know. (I'm adding dri-devel, since I think Intel folks have looked into some of this already, and we might need to make some common functionality). "The semaphore must be signaled, o

Re: Shared semaphores for amdgpu

Am 10.03.2017 um 00:19 schrieb Dave Airlie: Completely agree, problem here is that this isn't documented like this in the Vulkan specification as far as I know. (I'm adding dri-devel, since I think Intel folks have looked into some of this already, and we might need to make some common functiona

[PATCH] drm/amdgpu: fix parser init error path to avoid crash in parser fini

From: Dave Airlie If we don't reset the chunk info in the error path, the subsequent fini path will double free. Signed-off-by: Dave Airlie --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm

[PATCH 2/5] drm/amdgpu: more ftrace formatting consistency fixes

Consistent formatting makes it easier to read the logs and apply simple awk oneliners. I missed some of these on my last patch. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gp

[PATCH 4/5] drm/amdgpu: remove useless pointers from traces

Remove pointers which provide redundant information which is already easier to deduce from other fields. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 21 + 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/am

[PATCH 1/5] drm/amd/sched: add a unique job id to amd_sched_job

A unique id is useful for debugging and tracing. Intended to replace pointers in ftrace output. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/scheduler/gpu_scheduler.c | 2 ++ drivers/gpu/drm/amd/scheduler/gpu_scheduler.h | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/g

[PATCH] More amdgpu trace patches

These are some of the extra changes Christian was requesting in the previous ftrace thread. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[PATCH 3/5] drm/amdgpu: use sched_job id instead of pointer for tracing

Pointers get reallocated and they are hard to read for humans. Use ids instead. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h b/drivers/

[PATCH 5/5] drm/amdgpu: replace fence pointer with fence data in traces

Fence data is easier to read and allows us to correlate to identify corresponding dma_fence ftrace events. Signed-off-by: Andres Rodriguez --- drivers/gpu/drm/amd/amdgpu/amdgpu_trace.h | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/am

Re: [PATCH] More amdgpu trace patches

nice patches, the set is Reviewed-by: Chunming Zhou On 2017年03月10日 10:25, Andres Rodriguez wrote: These are some of the extra changes Christian was requesting in the previous ftrace thread. ___ amd-gfx mailing list amd-gfx@lists.freedesktop.org https

Re: Shared semaphores for amdgpu

> > As far as I can see the only functionality we are missing here is: > > void sync_file_signal(struct sync_file *sync_file, struct dma_fence *fence) > { > dma_fence_put(sync_file->fence); > sync_file->fence = fence; > } > > We probably should do this atomically, but that is only a matter

Re: Shared semaphores for amdgpu

On 10 March 2017 at 13:25, Dave Airlie wrote: >> >> As far as I can see the only functionality we are missing here is: >> >> void sync_file_signal(struct sync_file *sync_file, struct dma_fence *fence) >> { >> dma_fence_put(sync_file->fence); >> sync_file->fence = fence; >> } >> >> We proba

Re: Shared semaphores for amdgpu

On 10 March 2017 at 14:27, Dave Airlie wrote: > On 10 March 2017 at 13:25, Dave Airlie wrote: >>> >>> As far as I can see the only functionality we are missing here is: >>> >>> void sync_file_signal(struct sync_file *sync_file, struct dma_fence *fence) >>> { >>> dma_fence_put(sync_file->fence