Reviewed-by: Christian König .
Am 29.01.2017 um 23:51 schrieb Edward O'Callaghan:
This series is,
Reviewed-by: Edward O'Callaghan
On 01/29/2017 06:49 AM, Grazvydas Ignotas wrote:
I've taken several patches from amdgpu-pro libdrm that look useful
to me and I think can be applied already. The o
Hi Andrey,
Unrelated suggestion:
A handy trick - to save yourself a bit of time (and "get it right")
you can use `git format-patch -vX ...' [it also works with send-email]
to have the version in the subject prefix.
Feel free to share it with the team - it seems that many people
manually edit the
From: Christian König
Somebody could try to free the bo_va between mapping and updating it.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 45 ++---
1 file changed, 14 insertions(+), 31 deletions(-)
diff --git a/drivers/gpu/drm/amd/amd
From: Christian König
We don't add any fences do the buffer, but just use it's address.
Additional to that we don't need a duplicates list here.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
Hi Andrey,
Thank you for the patch.
On Saturday 28 Jan 2017 21:26:49 Andrey Grodzovsky wrote:
> Allows using atomic flip helpers for drivers
> using ASYNC flip.
> Remove ASYNC_FLIP restriction in helpers and
> caches the page flip flags in drm_crtc_state
> to be used in the low level drivers.
>
From: Christian König
Enable/disable the handling globally for now and
print a warning when we enable it for the first time.
Signed-off-by: Junwei Zhang
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 57 +++
1 file changed, 57 insert
From: Junwei Zhang
Till GFX8 we can only enable PRT support globally, but with the next hardware
generation we can do this on a per page basis.
Keep the interface consistent by adding PRT mappings and enable
support globally on current hardware when the first mapping is made.
v2: disable PRT su
From: Christian König
For PRT support we need mappings which aren't backed by any memory.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
Hi Dave and Bas,
Hi Dave and Bas,
the following set of patches is a proposal for adding support for partial
resident textures (PRT) to the amdgpu kernel module.
The basic idea behind PRT support is that you turn of VM fault reporting and
only map parts of a texture into your virtual address sp
From: Christian König
Enable/disable the handling globally for now and
print a warning when we enable it for the first time.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c | 63 +++
1 file changed, 63 insertions(+)
diff --git a/drivers
From: Christian König
Future hardware generations can handle PRT flags on a per page basis,
but current hardware can only turn it on globally.
Add the basic handling for both, a global callback to enable/disable
triggered by setting a per mapping flag.
Signed-off-by: Christian König
---
drive
From: Christian König
Enable/disable the handling globally for now and
print a warning when we enable it for the first time.
Signed-off-by: Junwei Zhang
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 1 +
drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 57
Minor nit: the comment says v8 [😊]
The changes to the GFX6/7/8 look reasonable though only question is you read
from mmVM_PRT_CNTL and then write to mmVM_CONTEXT1_CNTL . Is that expected?
Tom
From: amd-gfx on behalf of Christian
König
Sent: Monday, Januar
The changes to the GFX6/7/8 look reasonable though only question is
you read from mmVM_PRT_CNTL and then write to mmVM_CONTEXT1_CNTL . Is
that expected?
Not at all! Looks like a copy&paste error while modifying the original
patch. Thanks for catching this.
Also the whole set is so far only co
Thanks, going to come back to that when I actually write the unit test.
But I will wait what Dave&Bas says to the interface.
Regards,
Christian.
Am 30.01.2017 um 15:15 schrieb StDenis, Tom:
Hi Christian,
I have SI,CI,VI gear in my office if you have a unit test to try it with.
Cheers,
To
On 30.01.2017 13:57, Christian König wrote:
From: Christian König
For PRT support we need mappings which aren't backed by any memory.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 20 ++--
1 file changed, 14 insertions(+), 6 deletions(-)
diff --
Hi Christian,
I have SI,CI,VI gear in my office if you have a unit test to try it with.
Cheers,
Tom
From: Christian König
Sent: Monday, January 30, 2017 09:14
To: StDenis, Tom; b...@basnieuwenhuizen.nl; airl...@gmail.com
Cc: amd-gfx@lists.freedesktop.org
Sub
[ Cc John for addrlib ]
On 30.01.2017 13:57, Christian König wrote:
An open problem with the proposal is that we don't know when or if we want to
add the userspace implementation into radeonsi.
So price question could you guys use this for radv as well? Or is it sufficient
to just write an un
On 2017-01-28 09:26 PM, Andrey Grodzovsky wrote:
> Swicth to use atomic helper.
> Start using actual user's given target_vblank value for flip
> instead of current value.
>
> v3:
> Update for movig pflip flags to crtc_state
>
> Change-Id: I25dae6d8c29de5d022a42aa99a18a32674b56cda
> Signed-off-by
On 30.01.2017 10:45, Christian König wrote:
From: Christian König
Somebody could try to free the bo_va between mapping and updating it.
Signed-off-by: Christian König
Nice catch! Both patches:
Reviewed-by: Nicolai Hähnle
---
drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 45 ++--
> -Original Message-
> From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com]
> Sent: Monday, January 30, 2017 6:05 AM
> To: Grodzovsky, Andrey
> Cc: dri-de...@lists.freedesktop.org; amd-gfx@lists.freedesktop.org;
> nouv...@lists.freedesktop.org; daniel.vet...@intel.com; dc_ups
The PCI Power Management Spec, r1.2, sec 5.6.1, requires a 10 millisecond
delay when powering on a device, i.e., transitioning from state D3hot to
D0.
Apparently some devices require more time, and d1f9809ed131 ("drm/radeon:
add quirk for d3 delay during switcheroo poweron for apple macbooks") add
Remove unnecessary save/restore of pdev->d3_delay.
The only assignments to pdev->d3_delay are in radeon_switcheroo_set_state()
and some quirks, none of which should be relevant in the
amdgpu_switcheroo_set_state() path.
Signed-off-by: Bjorn Helgaas
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
amdgpu doesn't need to touch pdev->d3_delay at all.
radeon has a d3_delay quirk for MacBook Pro, but it only affects
radeon_switcheroo_set_state(). I think it should affect wakeups done by
the PCI core as well.
---
Bjorn Helgaas (2):
drm/amdgpu: remove unnecessary save/restore of pdev->d3
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Bjorn Helgaas
> Sent: Monday, January 30, 2017 3:41 PM
> To: Deucher, Alexander; Koenig, Christian
> Cc: linux...@vger.kernel.org; linux-...@vger.kernel.org; linux-
> ker...@vger.kernel.org; a
From: Michel Dänzer
vram_size is supposed to be the total amount of VRAM that can be used by
userspace, which corresponds to the TTM VRAM manager size (which is
normally the full amount of VRAM, but can be just the visible VRAM when
DMA can't be used for BO migration for some reason).
The above
From: Michel Dänzer
The kernel driver reports correct values now.
Signed-off-by: Michel Dänzer
---
src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_winsys.c
b/src/gallium/winsys
From: Michel Dänzer
It never had any effect with glamor.
Signed-off-by: Michel Dänzer
---
src/radeon_kms.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/src/radeon_kms.c b/src/radeon_kms.c
index 446852564..58efd6ee5 100644
--- a/src/radeon_kms.c
+++ b/src/radeo
28 matches
Mail list logo
