Re: [PATCH 02/22] drm/amd/display: Refactor to move color helper into module

Hi Andreas, On 2016-12-21 12:21 PM, Andreas Boll wrote: Hi, 2016-12-21 17:29 GMT+01:00 Harry Wentland : From: Anthony Koo Refactor part 2 - Moving color helper into color module The color module will need table defined in the helper in order to calculate the logical regamma curve, and also

[PATCH 00/14] DC Patches Dec 22, 2016

* Some gamma correction rework and fixes * Some crash fixes * Fix licensing header in color module Andrey Grodzovsky (2): drm/amd/display: Add refcount debug assert drm/amd/display: Pass adev to fill_plane_attr Anthony Koo (1): drm/amd/display: Reset gamma to NULL after release Aric Cyr (1

[PATCH 01/14] drm/amd/display: add pitch to cursor attributes

From: Tony Cheng Change-Id: Ic9a3c7d606b6e48967da59746ca3ec4c217565af Signed-off-by: Tony Cheng Reviewed-by: Yongqiang Sun Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc_hw_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dc_hw_types.h

[PATCH 02/14] drm/amd/display: minor clock source refactor

From: Dmytro Laktyushkin This should make it easier to share code with newer ASICs Change-Id: I615c5774257125383439bd27060eab9db205cc95 Signed-off-by: Dmytro Laktyushkin Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- .../gpu/drm/amd/display/dc/dce/dce_clock_source.c | 68 +++--

[PATCH 14/14] drm/amd/display: Pass adev to fill_plane_attr

From: Andrey Grodzovsky Change-Id: I9e23df476423f216ac52727a288913ccb9c2ce94 Signed-off-by: Andrey Grodzovsky --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_types.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_

[PATCH 11/14] drm/amd/display: Fixed split update bug.

From: Yongqiang Sun Change-Id: I03970c775b188fabb05ee042e0b4482d4db209df Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/d

[PATCH 08/14] drm/amd/display: reset transfer_func to NULL on release

From: Yongqiang Sun Change-Id: I9a5c699fd9b17c15ea2903d6a1b13c47209f8311 Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_stream.c | 4 +++- drivers/gpu/drm/amd/display/dc/core/dc_surface.c | 8 ++-- 2 files changed,

[PATCH 05/14] drm/amd/display: Reset gamma to NULL after release

From: Anthony Koo Change-Id: I1542e96e23c2b2b943c09d2099d2fd5426cb0868 Signed-off-by: Anthony Koo Reviewed-by: Aric Cyr Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/modules/color/color.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/dis

[PATCH 03/14] drm/amd/display: Add dcc param to surface

From: Leon Elazar Change-Id: Ib8a0db5f2833602bb2c6a3480e81a63956b8c4ea Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/dc.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/display/dc/dc.h b/drivers/gpu/drm/amd/display/dc/dc.h index f

[PATCH 09/14] drm/amd/display: Fixed crash

From: Yongqiang Sun Change-Id: I921091f888efd1acd2a6d6421cf149326ebe8c17 Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/dr

[PATCH 07/14] drm/amd/display: don't crash if stream is NULL when trying to share clocks

From: Yongqiang Sun Change-Id: I490ec0a8edc46c677d93ebcced7e9d2653999481 Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/display/dc/

[PATCH 10/14] drm/amd/display: Fix licensing header

Change-Id: I571f298c0b4c01f1df8ebaf020daac3ea8e2974c Signed-off-by: Harry Wentland Reviewed-by: Anthony Koo Acked-by: Harry Wentland --- .../drm/amd/display/modules/color/color_helper.c | 31 +++--- .../drm/amd/display/modules/color/color_helper.h | 30 ++---

[PATCH 04/14] drm/amd/display: track cursor width in ipp

From: Tony Cheng Change-Id: Ia3ced1b3ecbb8e4443c10808a7f1e02d4f3f Signed-off-by: Tony Cheng Reviewed-by: Yongqiang Sun Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/inc/hw/ipp.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/displa

[PATCH 12/14] drm/amd/display: Fixed crash caused by unnecessary clock source in split pipe.

From: Yongqiang Sun Change-Id: Ic802ab470632b8577f80ad17c08a59dd654f93d4 Signed-off-by: Yongqiang Sun Reviewed-by: Tony Cheng Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc_resource.c| 20 ++-- .../drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 4

[PATCH 13/14] drm/amd/display: Add refcount debug assert

From: Andrey Grodzovsky Change-Id: I5832e930aacc1549df6286885e5f2bc67d80a797 Signed-off-by: Andrey Grodzovsky Signed-off-by: Jordan Lazare Signed-off-by: Tony Cheng Reviewed-by: Andrey Grodzovsky Reviewed-by: Jordan Lazare Acked-by: Harry Wentland --- drivers/gpu/drm/amd/display/dc/core/dc

[PATCH 06/14] drm/amd/display: Implement gamma correction using input LUT

From: Aric Cyr The dc_gamma in dc_surface will be programmed to the input LUT if provided. If dc_gamma is not provided in dc_surface regamma may be used to emulate gamma. Some refactor and cleanup included as well. Change-Id: I6bd82a4528befd009a136775cb9953ee67488c3f Signed-off-by: Aric Cyr R

Re: [RFC] Mechanism for high priority scheduling in amdgpu

Hey Christian, But yes, in general you don't want another compositor in the way, so we'll >> be acquiring the HMD display directly, separate from any desktop or display >> server. > > > Assuming that the the HMD is attached to the rendering device in some way > you have the X server and the Compos

Re: [RFC] Mechanism for high priority scheduling in amdgpu

I hate to keep bringing up display topics in an unrelated conversation, but I'm not sure where you got "Application -> X server -> compositor -> X server" from. As I was saying before, we need to be presenting directly to the HMD display as no display server can be in the way, both for latency

Re: [RFC] Mechanism for high priority scheduling in amdgpu

Hey John, I've collected bit of data using high priority SW scheduler queues, thought you might be interested. Implementation as per the patch above. Control test 1 == Sascha Willems mesh sample running on its own at regular priority Results --- Mesh: ~0.14ms per-frame latency

[PATCH 2/4] drm/amd/powerplay: Unify dpm level defines

Change-Id: I209a6732f7956778485b7e55fa9e85e6987c0229 --- drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.h | 19 --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c| 39 +-- drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 12 +++ drivers/gpu/drm/amd/amdgpu/kv

[PATCH 3/4] drm/amd/powerplay: fix bug dpm level set by user was reset to auto.

Change-Id: Id68b42dbb2c4e9403e097835a6758c9f930b836e Signed-off-by: Rex Zhu --- drivers/gpu/drm/amd/powerplay/eventmgr/eventtasks.c | 5 - drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/e

[PATCH 4/4] drm/amd/powerplay: add profiling mode in dpm level

Change-Id: I4a46440882cd94fe5e77e3f351aaccc218a2ece5 --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 17 + drivers/gpu/drm/amd/amdgpu/ci_dpm.c | 4 ++-- drivers/gpu/drm/amd/include/amd_shared.h | 1 + drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c |

Re: [PATCH 1/2] drm/amd/powerplay: add prefix for all powerplay pr_* prints

Hi, I would say drop all the header relocation churn, it distracts away from the functional changes in this commit. Also see inline comments. With those fixes, Acked-by: Edward O'Callaghan Kindest Regards, Edward. On 12/23/2016 01:45 PM, Huang Rui wrote: > Powerplay will be used them instead o

Re: [PATCH 1/2] drm/amd/powerplay: add prefix for all powerplay pr_* prints

On Fri, Dec 23, 2016 at 05:32:58PM +0800, Edward O'Callaghan wrote: > Hi, > > I would say drop all the header relocation churn, it distracts away from > the functional changes in this commit. Also see inline comments. > Yes, if double check undef, it needn't move macro before > With those fixe

[PATCH 2/2] drm/amd/powerplay: fix issue can't load another smu firmware.

need to release failed smu firmware before load another firmware. Change-Id: Ifb9e0f63a5261dffef28ee1e0ce982d9c5b0344c Signed-off-by: Rex Zhu Reviewed-by: Alex Deucher Reviewed-by: Huang Rui --- drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 1/2] drm/amd/powerplay: refine code in cz_smumgr.c

cz_smu_init will be called in sw_init. so it should not touch other blocks's firmware as they were not ready. Change-Id: I3af8cce2059aaacfc260e24a41b1af46a0aeb18b Signed-off-by: Rex Zhu Reviewed-by: Huang Rui --- drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 135 --- 1

Re: [PATCH 1/2] drm/amd/powerplay: add prefix for all powerplay pr_* prints

On 12/23/2016 08:54 PM, Huang Rui wrote: > On Fri, Dec 23, 2016 at 05:32:58PM +0800, Edward O'Callaghan wrote: >> Hi, >> >> I would say drop all the header relocation churn, it distracts away from >> the functional changes in this commit. Also see inline comments. >> > > Yes, if double check und

Re: [PATCH 02/23] drm/amdgpu: add kiq into compiling

Ah, I've clicked now - I thought Vega was a star name AI - Arctic Islands :D On Tue, 20 Dec 2016 at 04:07 Bridgman, John wrote: > An upcoming GPU generation (Vega). > > > > > > *From:* amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] *On Behalf > Of *Mike Lothian > *Sent:* Monday, Decembe

Re: [RFC] Mechanism for high priority scheduling in amdgpu

But yes, in general you don't want another compositor in the way, so we'll be acquiring the HMD display directly, separate from any desktop or display server. Assuming that the the HMD is attached to the rendering device in some way you have the X server and the Compositor which both try to be D