Reviewed-By: Emily Deng
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Alex Deucher
> Sent: Friday, September 30, 2016 12:14 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH 1/4] drm/amdgpu/virtual_dce:
Reviewed-By: Emily Deng
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Alex Deucher
> Sent: Friday, September 30, 2016 12:14 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: [PATCH 2/4] drm/amdgpu/virtual_dce:
Hi Alex,
It seems hasn't support virtual display for dce_v6_0 asic?
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Alex Deucher
> Sent: Friday, September 30, 2016 12:14 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
+ if (job && !job->vm_needs_flush && ring->type == AMDGPU_RING_TYPE_GFX) {
+ extra_nop = 128;
+ }
+
Please remove the redundant braces here. With that fixed, the patch is
Reviewed-by: Hawking Zhang
Regards,
Hawking
-Original Message-
From: amd-gfx [mailto:amd-gf
NAK, please stop adding workarounds like this into common code.
If we need to add the extra NOPs between each command submission than
just do this in one of the existing IP specific callbacks.
Additional to that this sounds more and more like the removal of the
double sync wasn't such a good
Enable multi crtcs for virtual display, user can set the number of crtcs
by amdgpu module parameter virtual_display.
Signed-off-by: Emily Deng
---
drivers/gpu/drm/amd/amdgpu/ObjectID.h | 25 -
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 27 +-
drivers/gpu/drm/amd/amdgpu/amdgpu_d
Thinking more about this. I assume that windows doesn't run into this
problem because of the larger padding for the GFX ring, doesn't they?
Well what do you think about just increasing the padding to what the
windows KMD is using then?
Regards,
Christian.
Am 30.09.2016 um 11:06 schrieb Chris
Am 29.09.2016 um 22:57 schrieb Alex Deucher:
This is needed for proper VCE DPM on some APUs.
v2: fix the asic list
Signed-off-by: Alex Deucher
Reviewed-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/dr
> -Original Message-
> From: Deng, Emily
> Sent: Friday, September 30, 2016 3:21 AM
> To: Alex Deucher; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander
> Subject: RE: [PATCH 3/4] drm/amdgpu/dce6: add dce_v6_0_disable_dce
>
> Hi Alex,
> It seems hasn't support virtual display for
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Monk Liu
> Sent: Friday, September 30, 2016 1:00 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Liu, Monk
> Subject: [PATCH] drm/amdgpu:fix exclusive mode game texture blank(v2)
>
> this fix DO
On Thu, Sep 29, 2016 at 11:56 PM, Monk Liu wrote:
> COND_EXEC are needed by GFX ring
>
> Change-Id: I4819300444061cb92b3bed44da660f82f2fc755e
> Signed-off-by: Monk Liu
Acked-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch enables detecting VCE/UVD PG features and fixes the
UVD powergate function.
Tested on a Tonga (by reading UVD tile/clk bits during playback/idle).
Signed-off-by: Tom St Denis
---
.../gpu/drm/amd/powerplay/hwmgr/smu7_clockpowergating.c| 12 +---
drivers/gpu/drm/amd/powerpl
Tested by reading tile/clk bits during load/idle.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/vi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index c6bc3df36118..c4394a6b82e9 100644
--- a/dr
Patch #1 fixes the UVD powergating function in the smu7 driver
as well as senses vce/uvd features (so we can fix/add vce PG later on).
Patch #2 enables it for tonga. Tested by reading tile/clk bits during
load/idle.
___
amd-gfx mailing list
amd-gfx@lis
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Tom St Denis
> Sent: Friday, September 30, 2016 11:02 AM
> To: amd-gfx@lists.freedesktop.org
> Subject: Enable UVD PG for SMU7 and turn on for Tonga
>
> Patch #1 fixes the UVD powergating fun
Thanks. I'll try it on FIJI next. Hopefully MGCG isn't needed for at least
basic tile power control.
Tom
From: amd-gfx on behalf of Deucher,
Alexander
Sent: Friday, September 30, 2016 11:10
To: 'Tom St Denis'; amd-gfx@lists.freedesktop.org
Subject: RE: Ena
I'm not sure Fiji supports PG on any blocks. You may want to double check with
the hw teams.
Alex
From: StDenis, Tom
Sent: Friday, September 30, 2016 11:13 AM
To: Deucher, Alexander; amd-gfx@lists.freedesktop.org
Subject: Re: Enable UVD PG for SMU7 and turn on for Tonga
Thanks. I'll try it o
On Fri, Sep 30, 2016 at 5:27 AM, Emily Deng wrote:
> Enable multi crtcs for virtual display, user can set the number of crtcs
> by amdgpu module parameter virtual_display.
>
> Signed-off-by: Emily Deng
> ---
> drivers/gpu/drm/amd/amdgpu/ObjectID.h | 25 -
> drivers/gpu/drm/amd/amdgpu/
Never used.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 35 ++--
1 file changed, 6 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
b/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
index 359fe56..cf43caa 1
From: Emily Deng
Enable multi crtcs for virtual display, user can set the number of crtcs
by amdgpu module parameter virtual_display.
v2: make timers per crtc
v3: agd: simplify implementation
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 28 +
d
Virtual crtcs interrupts do not show up in the IV ring,
so it will never be called.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/dce_virtual.c
b/drivers/g
No need to emulate all of the stuff for real hw.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c | 93 --
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 231 +++--
2 files changed, 144 insertions(+), 180 deletions(-)
diff --git a/dri
to match the other functions in that file.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 99a15ca..13
This reverts commit 16925c92dbd97524655525b6816625e1f0063d12.
This is no longer necessary.
---
drivers/gpu/drm/amd/amdgpu/ObjectID.h | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/ObjectID.h
b/drivers/gpu/drm/amd/amdgpu/ObjectID.h
index b8d6667..0619269 1006
We handle the virtual interrupts from a timer so no
need to try an look like we are handling IV ring events.
Signed-off-by: Alex Deucher
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 109 +++
1 file changed, 54 insertions(+), 55 deletions(-)
diff --git a/drivers/gpu
Am 30.09.2016 um 16:51 schrieb Alex Deucher:
On Thu, Sep 29, 2016 at 11:56 PM, Monk Liu wrote:
COND_EXEC are needed by GFX ring
Change-Id: I4819300444061cb92b3bed44da660f82f2fc755e
Signed-off-by: Monk Liu
Acked-by: Alex Deucher
I would rather say just drop the ring type check completely a
Am 30.09.2016 um 19:08 schrieb Alex Deucher:
Never used.
Signed-off-by: Alex Deucher
Acked-by: Christian König .
---
drivers/gpu/drm/amd/amdgpu/dce_virtual.c | 35 ++--
1 file changed, 6 insertions(+), 29 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/d
Am 30.09.2016 um 19:20 schrieb Leo Liu:
Adapt to recent firmware update, it's also compatible with previous
firwmare version
Signed-off-by: Leo Liu
Reviewed-by: Christian König
---
tests/amdgpu/vce_ib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/amdgpu/vce
Adapt to recent firmware update, it's also compatible with previous
firwmare version
Signed-off-by: Leo Liu
---
tests/amdgpu/vce_ib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/amdgpu/vce_ib.h b/tests/amdgpu/vce_ib.h
index bd0bf94..80ab179 100644
--- a/tests/amdgpu
On Tue, Sep 27, 2016 at 3:47 PM, Edward O'Callaghan
wrote:
> Use a struct to carry the calculated const state inside the
> main kfd_dev state to use where we need it. Minor cleanups
> while we are here.
>
> Signed-off-by: Edward O'Callaghan
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_dbgdev.c
30 matches
Mail list logo