Re: [PATCH 6/7] drm/amdkfd: Reuse function to find a process through pasid

2016-09-11 Thread Oded Gabbay
On Sat, Sep 10, 2016 at 4:31 AM, Edward O'Callaghan wrote: > The kfd_lookup_process_by_pasid() is just for that purpose, > so use it instead of repeating the code. > > Signed-off-by: Edward O'Callaghan > --- > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 58 > +--- > 1

Re: [PATCH 7/7] drm/amdkfd: Fix possible infinite loop

2016-09-11 Thread Oded Gabbay
On Sat, Sep 10, 2016 at 4:31 AM, Edward O'Callaghan wrote: > When the loop predicating timeout parameter passed happens to > not be a multiple of 20 the unsigned integer will overflow and > the loop will become unbounded. > > Signed-off-by: Edward O'Callaghan > --- > drivers/gpu/drm/amd/amdgpu/a

Re: [PATCH 2/7] radeonkfd/amdkfd: Implement get_local_mem_info()

2016-09-11 Thread Oded Gabbay
On Sat, Sep 10, 2016 at 4:31 AM, Edward O'Callaghan wrote: > Signed-off-by: Edward O'Callaghan Please give a little explanation why this new function is needed. In addition, I don't think "radeonkfd/amdkfd: .." is good as we never used this kind of title before. Let's just use "drm/amdkfd: ..."

[PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-11 Thread Huang Rui
Clean up the codes to move the release handles into fail labels. Signed-off-by: Huang Rui --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c b/drivers/gpu/drm/amd/amd

Re: [PATCH] drm/amdgpu: move some release handles into fail labels

2016-09-11 Thread zhoucm1
On 2016年09月12日 10:16, Huang Rui wrote: Clean up the codes to move the release handles into fail labels. Signed-off-by: Huang Rui Reviewed-by: Chunming Zhou --- drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff -