Add PCI domains compare and replace strncmp with strcmp.
Subject: [PATCH v2] drm/amdgpu: Change the virtual_display type from int to
char*.
For virtual display feature, as there may be mutiple GPUs,
for user could choose whiche GPU need to enable this feature, change
the type of virtual_display
Add PCI domains compare and replace strncmp with strcmp.
For virtual display feature, as there may be mutiple GPUs,
for user could choose whiche GPU need to enable this feature, change
the type of virtual_display from int to char*. The variable will be set
like this virtual_display=":xx:xx.x;x
On 09/08/16 04:47 PM, Emily Deng wrote:
> Add PCI domains compare and replace strncmp with strcmp.
>
> For virtual display feature, as there may be mutiple GPUs,
> for user could choose whiche GPU need to enable this feature, change
> the type of virtual_display from int to char*. The variable wil
Am 09.08.2016 um 04:44 schrieb Michel Dänzer:
On 08/08/16 06:55 PM, Christian König wrote:
[SNIP]
Who said that games need to be able to enable/disable it in the
kernel side?
The assumption is that some games (and maybe other apps, e.g.
compositors) won't work correctly with variable refresh
On 09/08/16 05:12 PM, Christian König wrote:
> Am 09.08.2016 um 04:44 schrieb Michel Dänzer:
>
>> I was basically thinking out loud that doing this via different modes
>> might be quite natural, *if* games allowed choosing a specific mode.
>> But unfortunately they don't. For the video playback ca
On 2016年08月08日 19:04, Christian König wrote:
Apart from that patch #1:
+ amdgpu_ttm_placement_init(adev, &placement,
+ placements, AMDGPU_GEM_DOMAIN_GTT,
+ AMDGPU_GEM_CREATE_CPU_GTT_USWC);
+
+return amdgpu_bo_create_restricted(adev, size, byte_align, true,
Am 09.08.2016 um 10:27 schrieb Michel Dänzer:
On 09/08/16 05:12 PM, Christian König wrote:
Am 09.08.2016 um 04:44 schrieb Michel Dänzer:
I was basically thinking out loud that doing this via different modes
might be quite natural, *if* games allowed choosing a specific mode.
But unfortunately
On 09/08/16 06:31 PM, Christian König wrote:
> Am 09.08.2016 um 10:27 schrieb Michel Dänzer:
>> On 09/08/16 05:12 PM, Christian König wrote:
>>> Am 09.08.2016 um 04:44 schrieb Michel Dänzer:
>>>
I was basically thinking out loud that doing this via different modes
might be quite natural,
Format stype correction.
For virtual display feature, as there may be multiple GPUs,
for user could choose whiche GPU need to enable this feature, change
the type of virtual_display from int to char*. The variable will be set
like this virtual_display=":xx:xx.x;:xx:xx.x;".
Signed-off-by:
Am 09.08.2016 um 12:03 schrieb Michel Dänzer:
On 09/08/16 06:31 PM, Christian König wrote:
Am 09.08.2016 um 10:27 schrieb Michel Dänzer:
On 09/08/16 05:12 PM, Christian König wrote:
Am 09.08.2016 um 04:44 schrieb Michel Dänzer:
I was basically thinking out loud that doing this via different
From: Christian König
Not used for a long time.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
index c309eaf..fe0ad2a 100644
--- a/drivers/gpu
From: Christian König
No need to carry that forward as a separate parameter.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 65 +++---
1 file changed, 29 insertions(+), 36 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
From: Christian König
We can add the fragment params before we split the update for the page tables.
That should save a few CPU cycles for larger updates.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 166 -
1 file changed, 79 inser
From: Christian König
We align to 64KB, but when userspace aligns even more we can easily use more.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
From: Christian König
We can actually do way more than just the 64KB we currently used as default.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu.h| 8
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git
From: Christian König
Well those are actually page table entry parameters.
This also makes the variable names used a bit shorter.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 91 --
1 file changed, 44 insertions(+), 47 deletions(-)
> -Original Message-
> From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf
> Of Emily Deng
> Sent: Tuesday, August 09, 2016 3:48 AM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deng, Emily
> Subject: [PATCH v2] drm/amdgpu: Change the virtual_display type from int
> to char*.
On Mon, Aug 08, 2016 at 01:30:37PM -0400, Alex Deucher wrote:
> On Fri, Aug 5, 2016 at 8:30 PM, Lyude wrote:
> > While I was investigating an unrelated bug on the radeon driver, I noticed
> > that
> > it's become rather difficult to actually read through dmesg with drm.debug
> > turned on, on acc
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 61 ---
1 file changed, 20 insertions(+), 41 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 8aa6b54f4516..5f91a834aed2 100644
--
Fix various whitespace issues in gfx v8 driver.
Signed-off-by: Tom St Denis
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 41 ++-
1 file changed, 16 insertions(+), 25 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
b/drivers/gpu/drm/amd/amdgpu/gfx_
This patch introduces a new macro WREG32_FIELD which is used
to write to a register with a new value in a field. It's designed
to replace the pattern:
tmp = RREG32(mmFoo);
tmp &= ~REG__FIELD_MASK;
tmp |= new_value << REG__FIELD__SHIFT;
WREG32(mmFoo, tmp)
with:
WREG32_FIELD(Foo, FIELD, new_value
These patches perform various cleanups in the GFX v8 driver.
Patch #1, performs various whitespace/error message cleanups.
Patch #2, performs various simplifications to routines to make them
easier to read (and reduce LOC).
Patch #3, introduces a WREG32_FIELD() macro which is then used to
red
Am 09.08.2016 um 16:27 schrieb Tom St Denis:
This patch introduces a new macro WREG32_FIELD which is used
to write to a register with a new value in a field. It's designed
to replace the pattern:
tmp = RREG32(mmFoo);
tmp &= ~REG__FIELD_MASK;
tmp |= new_value << REG__FIELD__SHIFT;
WREG32(mmFoo,
On Tue, Aug 9, 2016 at 8:52 AM, Christian König wrote:
> From: Christian König
>
> We align to 64KB, but when userspace aligns even more we can easily use more.
>
> Signed-off-by: Christian König
For the series:
Reviewed-by: Alex Deucher
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 12 ++
Probably could but I felt that implementation was cleaner.
Tom
From: Christian König
Sent: Tuesday, August 9, 2016 10:56
To: Tom St Denis; amd-gfx@lists.freedesktop.org
Cc: StDenis, Tom
Subject: Re: [PATCH 3/3] drm/amd/amdgpu: Simplify bitfield operations in gf
On 2016-08-09 07:52, Christian König wrote:
From: Christian König
We align to 64KB, but when userspace aligns even more we can easily use
more.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff
Am 09.08.2016 um 17:49 schrieb Jay Cornwall:
On 2016-08-09 07:52, Christian König wrote:
From: Christian König
We align to 64KB, but when userspace aligns even more we can easily
use more.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 12
1 file
On 2016-08-09 11:35, Christian König wrote:
Am 09.08.2016 um 17:49 schrieb Jay Cornwall:
On 2016-08-09 07:52, Christian König wrote:
From: Christian König
We align to 64KB, but when userspace aligns even more we can easily
use more.
Signed-off-by: Christian König
---
drivers/gpu/drm/amd/
Replace variable enable_virtual_display and change the type of
enable_virtual_display.
For virtual display feature, as there may be multiple GPUs,
for user could choose whiche GPU need to enable this feature, change
the type of virtual_display from int to char*. The variable will be set
like this
Doing S3 stress test, sometimes, driver can not get console lock. So use
console_trylock() to instead it.
Change-Id: I50177f3d7dbb923cb4f602a11ea51c397b12b3e6
Signed-off-by: JimQu
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --gi
On 09/08/16 07:44 PM, Christian König wrote:
> Am 09.08.2016 um 12:03 schrieb Michel Dänzer:
>> On 09/08/16 06:31 PM, Christian König wrote:
>>> Am 09.08.2016 um 10:27 schrieb Michel Dänzer:
On 09/08/16 05:12 PM, Christian König wrote:
> Am 09.08.2016 um 04:44 schrieb Michel Dänzer:
>
On 10/08/16 12:04 PM, jimqu wrote:
> Doing S3 stress test, sometimes, driver can not get console lock. So use
> console_trylock() to instead it.
This raises some questions:
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 087e520..
On 10/08/16 12:24 PM, Michel Dänzer wrote:
> On 10/08/16 12:04 PM, jimqu wrote:
>> Doing S3 stress test, sometimes, driver can not get console lock. So use
>> console_trylock() to instead it.
>
> This raises some questions:
>
>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
>> b/dri
HI Michel:
1. So far, I not sure which one causes the console_lock() fail, maybe I need
enable kernel mutex debug feature to trace it.
2. Phenomenally, it can be restore to desktop normally. Do you know any methods
to check it whether driver without calling amdgpu_fbdev_set_suspend(adev, 0)
h
On 2016年08月08日 19:04, Christian König wrote:
I need to work on the S3 issue again now, going to come back to this
patch set when I have more time.
I've addressed your previous comments, are you free? how about the other
patches?
Thanks,
David Zhou
Regards,
Christian.
On 10/08/16 01:39 PM, Qu, Jim wrote:
> HI Michel:
>
> 1. So far, I not sure which one causes the console_lock() fail, maybe I
> need enable kernel mutex debug feature to trace it.
Or, maybe you can just try fixing the cases in amdgpu_resume_kms where
console_unlock() isn't called, and see if that
36 matches
Mail list logo
