Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread Alexandre Demers
Demers > *Sent:* Friday, August 12, 2016 13:39 > > *To:* StDenis, Tom; Freedesktop - AMD-gfx > *Cc:* Alexander Deucher > *Subject:* Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails > Hi again, > > I'm talking about modifying radeon's side to mimic amdgp

Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread StDenis, Tom
Cheers, Tom From: Alexandre Demers Sent: Friday, August 12, 2016 13:39 To: StDenis, Tom; Freedesktop - AMD-gfx Cc: Alexander Deucher Subject: Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails Hi again, I'm talking about modifying radeon's side to mimic amdgpu's beha

Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread Alexandre Demers
-- > *From:* Alexandre Demers > *Sent:* Friday, August 12, 2016 12:11 > *To:* StDenis, Tom; Freedesktop - AMD-gfx > *Cc:* Alexander Deucher > *Subject:* Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails > > Thanks for the quick answer Tom. I was thinking mostly as you do,

Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread Christian König
1 *To:* StDenis, Tom; Freedesktop - AMD-gfx *Cc:* Alexander Deucher *Subject:* Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails Thanks for the quick answer Tom. I was thinking mostly as you do, but before sending the patch to the list, I wanted to be sure it was worth it. I'll send the

Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread StDenis, Tom
a good thing). Tom From: Alexandre Demers Sent: Friday, August 12, 2016 12:11 To: StDenis, Tom; Freedesktop - AMD-gfx Cc: Alexander Deucher Subject: Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails Thanks for the quick answer Tom. I was thinking mostly as you do, but before send

Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread Alexandre Demers
:* Freedesktop - AMD-gfx > *Cc:* Alexander Deucher > *Subject:* radeon VS amdgpu: _afmt_init() behavior if kzalloc fails > > Hi, > > While comparing radeon's radeon_afmt_init() to dce_vX_0_afmt_init() on the > amdgpu's side, I saw that on the latter: > 1- when kza

Re: radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread StDenis, Tom
few bytes you've got bigger problems to worry about than your audio not working ideally. Tom From: amd-gfx on behalf of Alexandre Demers Sent: Friday, August 12, 2016 11:43 To: Freedesktop - AMD-gfx Cc: Alexander Deucher Subject: radeon VS amdgpu: _afmt

radeon VS amdgpu: _afmt_init() behavior if kzalloc fails

2016-08-12 Thread Alexandre Demers
Hi, While comparing radeon's radeon_afmt_init() to dce_vX_0_afmt_init() on the amdgpu's side, I saw that on the latter: 1- when kzalloc fails to allocate mem for all afmt, an ENOMEM is returned 2- all previously allocated afmt are freed So on the amdgpu's side, it is an "all or none allocated" si