Re: force app kill patch

2018-04-18 Thread Christian König
n. /Monk *From:*Christian König [mailto:ckoenig.leichtzumer...@gmail.com] *Sent:* 2018年4月18日16:36 *To:* Liu, Monk ; Koenig, Christian ; Deng, Emily *Cc:* amd-gfx@lists.freedesktop.org *Subject:* Re: force app kill patch See that in “sched_entity_fini”, we only call dma_fence_put(entit

RE: force app kill patch

2018-04-18 Thread Liu, Monk
riggers memory leak and more critical the double put fence cause NULL pointer access /Monk From: Liu, Monk Sent: 2018年4月18日 15:11 To: Koenig, Christian <mailto:christian.koe...@amd.com>; Deng, Emily <mailto:emily.d...@amd.com> Cc: amd-gfx@lists.freedesktop.org<mailto:amd-gfx

Re: force app kill patch

2018-04-18 Thread Christian König
e put fence cause NULL pointer access /Monk *From:*Liu, Monk *Sent:* 2018年4月18日15:11 *To:* Koenig, Christian ; Deng, Emily *Cc:* amd-gfx@lists.freedesktop.org *Subject:* force app kill patch Hi Christian & Emily I think the v4 fix for “fix force app kill hang”is still not good enough: Firs

RE: force app kill patch

2018-04-18 Thread Liu, Monk
年4月18日 15:11 To: Koenig, Christian ; Deng, Emily Cc: amd-gfx@lists.freedesktop.org Subject: force app kill patch Hi Christian & Emily I think the v4 fix for “fix force app kill hang” is still not good enough: First: See that in “sched_entity_fini”, we only call dma_fence_put(entity->las

force app kill patch

2018-04-18 Thread Liu, Monk
Hi Christian & Emily I think the v4 fix for "fix force app kill hang" is still not good enough: First: See that in "sched_entity_fini", we only call dma_fence_put(entity->last_scheduled" under the condition of "If (entity->fini_status)", so This way there is memory leak for the case of "entity