Re: [PATCH v3] drm/amdgpu: dequeue mes scheduler during fini

2022-10-18 Thread Xiao, Jack
[AMD Official Use Only - General] Reviewed-by: Jack Xiao Regards, Jack From: amd-gfx on behalf of YuBiao Wang Sent: Tuesday, 18 October 2022 13:37 To: amd-gfx@lists.freedesktop.org Cc: Wang, YuBiao ; Grodzovsky, Andrey ; Xiao, Jack ; Xu, Feifei ; Chen, Hora

Re: [PATCH v3] drm/amdgpu: dequeue mes scheduler during fini

2022-10-17 Thread Xiao, Jack
[AMD Official Use Only - General] >> + /* dequeue sched pipe via kiq */ >> + void(*kiq_dequeue_sched)(struct >> amdgpu_device *adev); >> + It's unnecessary to expose a new callback function proto to perform dequeuing scheduler queue, for kiq_fini or mes_

RE: [PATCH v3] drm/amdgpu: dequeue mes scheduler during fini

2022-10-17 Thread Wang, YuBiao
; Deucher, Alexander ; Xiao, Jack ; Zhang, Hawking ; Liu, Monk ; Xu, Feifei ; Wang, Yang(Kevin) Subject: Re: [PATCH v3] drm/amdgpu: dequeue mes scheduler during fini Am 14.10.22 um 05:34 schrieb YuBiao Wang: > Update: Remove redundant comments as Christian suggests. > > [Why] > If mes is

Re: [PATCH v3] drm/amdgpu: dequeue mes scheduler during fini

2022-10-14 Thread Christian König
Am 14.10.22 um 05:34 schrieb YuBiao Wang: Update: Remove redundant comments as Christian suggests. [Why] If mes is not dequeued during fini, mes will be in an uncleaned state during reload, then mes couldn't receive some commands which leads to reload failure. [How] Perform MES dequeue via MMIO