That's fine, I can do that change and submit the series per Alex's RB.
Kent
> -Original Message-
> From: Chen, Guchun
> Sent: Friday, December 17, 2021 9:49 PM
> To: Russell, Kent ; amd-gfx@lists.freedesktop.org
> Cc: Russell, Kent
> Subject: RE: [PATCH 4/4
[Public]
Hi Kent,
+
+ if (adev->asic_type == CHIP_ALDEBARAN)
+ offset = 0;
if (!is_fru_eeprom_supported(adev))
I prefer to put 'adev->asic_type == CHIP_ALDEBARAN' after calling
is_fru_eeprom_supported to make code logic cleaner. Without FRU support, we
should do n
[AMD Official Use Only]
Series is:
Reviewed-by: Alex Deucher
From: amd-gfx on behalf of Kent Russell
Sent: Friday, December 17, 2021 10:31 AM
To: amd-gfx@lists.freedesktop.org
Cc: Russell, Kent
Subject: [PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran
Thi
ists.freedesktop.org
> Cc: Russell, Kent
> Subject: RE: [PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran
>
> [Public]
>
> BTW, does FRU exists on all the Aldebaran SKUs?
>
> This patch acks FRU's presence when it's Aldebaran. So if some Aldebaran SKUs
> do not
Of Chen, Guchun
Sent: Tuesday, December 14, 2021 11:17 AM
To: Russell, Kent ; amd-gfx@lists.freedesktop.org
Cc: Russell, Kent
Subject: RE: [PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran
[Public]
+ if (adev->asic_type == CHIP_ALDEBARAN)
+ offset = 0
[Public]
+ if (adev->asic_type == CHIP_ALDEBARAN)
+ offset = 0;
if (!is_fru_eeprom_supported(adev))
return 0;
I assume the logic should be adjusted. It's better to put the asic_type check
after is_fru_eeprom_supported.
Regards,
Guchun
-Original
