Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Sharma, Shashank
, February 4, 2022 1:41 PM *To:* Sharma, Shashank ; Lazar, Lijo ; amd-gfx@lists.freedesktop.org *Cc:* Somalapuram, Amaranath ; Koenig, Christian *Subject:* Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler [Public] [Public] In the suspend and hibernate cases, we don't care

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Deucher, Alexander
To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler On 2/4/2022 6:20 PM, Lazar, Lijo wrote: > [AMD Official Use Only] > > One more thing >In sus

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Deucher, Alexander
esktop.org Cc: Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler On 2/4/2022 6:20 PM, Lazar, Lijo wrote: > [AMD Official Use Only] > > One more thing >In suspend-reset case, won't this

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Sharma, Shashank
Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler On 2/4/2022 6:11 PM, Lazar, Lijo wrote: BTW, since this is already providing a set of values it would be useful to provide one more field as the reset reason - RAS erro

RE: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Lazar, Lijo
om: Sharma, Shashank Sent: Friday, February 4, 2022 10:47 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler On 2/4/2022 6:11 PM, Lazar, Lijo wrote: > BTW,

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Sharma, Shashank
On 2/4/2022 6:11 PM, Lazar, Lijo wrote: BTW, since this is already providing a set of values it would be useful to provide one more field as the reset reason - RAS error recovery, GPU hung recovery or something else. Adding this additional parameter instead of blocking something in kernel

RE: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Lazar, Lijo
anath ; Koenig, Christian Subject: Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler On 2/4/2022 6:02 PM, Lazar, Lijo wrote: > [Public] > > The problem is app doesn't know why the reset happened. It just receives a > bunch of registers to be read. On what basis an a

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Sharma, Shashank
Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler On 2/4/2022 5:50 PM, Lazar, Lijo wrote: [AMD Official Use Only] To explain more - It's an unconditional reset done by the kernel on every suspend (S3/S4). In su

RE: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Lazar, Lijo
d-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler On 2/4/2022 5:50 PM, Lazar, Lijo wrote: > [AMD Official Use Only] > > To explain more - > It's an unconditional re

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Sharma, Shashank
in design philosophy maybe :) - Shashank Thanks, Lijo -Original Message- From: Sharma, Shashank Sent: Friday, February 4, 2022 10:09 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH 4/4] drm/amd

RE: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Lazar, Lijo
x27;t look like a good idea. Thanks, Lijo -Original Message- From: Sharma, Shashank Sent: Friday, February 4, 2022 10:09 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Somalapuram, Amaranath ; Koenig, Christian Subject: Re: [PATCH 4/4] drm/amdgpu/nv: add navi

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-02-04 Thread Sharma, Shashank
Hey Lijo, I somehow missed to respond on this comment, pls find inline: Regards Shashank On 1/22/2022 7:42 AM, Lazar, Lijo wrote: On 1/22/2022 2:04 AM, Sharma, Shashank wrote:  From 899ec6060eb7d8a3d4d56ab439e4e6cdd74190a4 Mon Sep 17 00:00:00 2001 From: Somalapuram Amaranath Date: Fri, 21 J

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-01-24 Thread Sharma, Shashank
On 1/24/2022 6:08 PM, Andrey Grodzovsky wrote: It's just an infrastructure you use when you need. I never tested it during reset i think but, we deliberately did it very self reliant where you simply iterate a FIFO of the dump through PMI3 registers interface and dump out the content. It cur

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-01-24 Thread Andrey Grodzovsky
It's just an infrastructure you use when you need. I never tested it during reset i think but, we deliberately did it very self reliant where you simply iterate a FIFO of the dump through PMI3 registers interface and dump out the content. It currently supposed to work for the NV family. In ca

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-01-24 Thread Sharma, Shashank
On 1/24/2022 8:18 AM, Christian König wrote: Am 21.01.22 um 21:34 schrieb Sharma, Shashank: From 899ec6060eb7d8a3d4d56ab439e4e6cdd74190a4 Mon Sep 17 00:00:00 2001 From: Somalapuram Amaranath Date: Fri, 21 Jan 2022 14:19:42 +0530 Subject: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handle

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-01-24 Thread Sharma, Shashank
Hey Andrey, That seems like a good idea, may I know if there is a trigger for STB dump ? or is it just the infrastructure which one can use when they feel a need to dump info ? Also, how reliable is the STB infra during a reset ? Regards Shashank On 1/24/2022 5:32 PM, Andrey Grodzovsky wrote:

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-01-24 Thread Andrey Grodzovsky
You probably can add the STB dump we worked on a while ago to your info dump - a reminder on the feature is here https://www.spinics.net/lists/amd-gfx/msg70751.html Andrey On 2022-01-21 15:34, Sharma, Shashank wrote: From 899ec6060eb7d8a3d4d56ab439e4e6cdd74190a4 Mon Sep 17 00:00:00 2001 From:

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-01-23 Thread Christian König
Am 21.01.22 um 21:34 schrieb Sharma, Shashank: From 899ec6060eb7d8a3d4d56ab439e4e6cdd74190a4 Mon Sep 17 00:00:00 2001 From: Somalapuram Amaranath Date: Fri, 21 Jan 2022 14:19:42 +0530 Subject: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler This patch adds a GPU reset handler for Navi

Re: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler

2022-01-21 Thread Lazar, Lijo
On 1/22/2022 2:04 AM, Sharma, Shashank wrote: From 899ec6060eb7d8a3d4d56ab439e4e6cdd74190a4 Mon Sep 17 00:00:00 2001 From: Somalapuram Amaranath Date: Fri, 21 Jan 2022 14:19:42 +0530 Subject: [PATCH 4/4] drm/amdgpu/nv: add navi GPU reset handler This patch adds a GPU reset handler for Navi