Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-23 Thread Jingwen Chen
On Fri Jul 23, 2021 at 10:45:49AM +0200, Christian König wrote: > Am 23.07.21 um 09:07 schrieb Jingwen Chen: > > [SNIP] > > Hi Christian, > > > > The thing is vm flush fence has no job passed to amdgpu_fence_emit, so > > go through the jobs cannot help find the vm flush fence. And keep the > > res

RE: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-23 Thread Liu, Monk
-GPU Core team -- -Original Message- From: Jingwen Chen Sent: Friday, July 23, 2021 3:07 PM To: Christian König ; Grodzovsky, Andrey ; amd-gfx@lists.freedesktop.org Cc: Chen, Horace ; Liu, Monk ; Zhang, Jack (Jian) Subject: Re: [PATCH 2/2] drm: add

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-23 Thread Jingwen Chen
On Fri Jul 23, 2021 at 08:33:02AM +0200, Christian König wrote: > Am 22.07.21 um 18:47 schrieb Jingwen Chen: > > On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: > > > Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: > > > > On 2021-07-22 6:45 a.m., Jingwen Chen wrote: > > > > > On We

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-23 Thread Christian König
Am 23.07.21 um 11:25 schrieb Jingwen Chen: On Fri Jul 23, 2021 at 10:45:49AM +0200, Christian König wrote: Am 23.07.21 um 09:07 schrieb Jingwen Chen: [SNIP] Hi Christian, The thing is vm flush fence has no job passed to amdgpu_fence_emit, so go through the jobs cannot help find the vm flush fe

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-23 Thread Christian König
Am 23.07.21 um 09:07 schrieb Jingwen Chen: [SNIP] Hi Christian, The thing is vm flush fence has no job passed to amdgpu_fence_emit, so go through the jobs cannot help find the vm flush fence. And keep the rest fences in the RCU array will lead to signaling them in the ib_test right after ASIC re

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-23 Thread Jingwen Chen
On Fri Jul 23, 2021 at 12:06:32AM -0400, Andrey Grodzovsky wrote: > > On 2021-07-22 8:20 p.m., Jingwen Chen wrote: > > On Thu Jul 22, 2021 at 01:50:09PM -0400, Andrey Grodzovsky wrote: > > > On 2021-07-22 1:27 p.m., Jingwen Chen wrote: > > > > On Thu Jul 22, 2021 at 01:17:13PM -0400, Andrey Grodzo

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-23 Thread Andrey Grodzovsky
On 2021-07-22 8:20 p.m., Jingwen Chen wrote: On Thu Jul 22, 2021 at 01:50:09PM -0400, Andrey Grodzovsky wrote: On 2021-07-22 1:27 p.m., Jingwen Chen wrote: On Thu Jul 22, 2021 at 01:17:13PM -0400, Andrey Grodzovsky wrote: On 2021-07-22 12:47 p.m., Jingwen Chen wrote: On Thu Jul 22, 2021 at 0

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Christian König
Am 22.07.21 um 18:47 schrieb Jingwen Chen: On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: On 2021-07-22 6:45 a.m., Jingwen Chen wrote: On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: On 2021-07-20 11:13 p.m., J

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Thu Jul 22, 2021 at 01:50:09PM -0400, Andrey Grodzovsky wrote: > > On 2021-07-22 1:27 p.m., Jingwen Chen wrote: > > On Thu Jul 22, 2021 at 01:17:13PM -0400, Andrey Grodzovsky wrote: > > > On 2021-07-22 12:47 p.m., Jingwen Chen wrote: > > > > On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian Kö

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Andrey Grodzovsky
On 2021-07-22 1:27 p.m., Jingwen Chen wrote: On Thu Jul 22, 2021 at 01:17:13PM -0400, Andrey Grodzovsky wrote: On 2021-07-22 12:47 p.m., Jingwen Chen wrote: On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: On 2021-07-22 6:45 a.m.

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Thu Jul 22, 2021 at 01:17:13PM -0400, Andrey Grodzovsky wrote: > > On 2021-07-22 12:47 p.m., Jingwen Chen wrote: > > On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: > > > Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: > > > > On 2021-07-22 6:45 a.m., Jingwen Chen wrote: > > > >

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Andrey Grodzovsky
On 2021-07-22 12:47 p.m., Jingwen Chen wrote: On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: On 2021-07-22 6:45 a.m., Jingwen Chen wrote: On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: On 2021-07-20 11:13 p.m

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Thu Jul 22, 2021 at 06:24:28PM +0200, Christian König wrote: > Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: > > > > On 2021-07-22 6:45 a.m., Jingwen Chen wrote: > > > On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: > > > > On 2021-07-20 11:13 p.m., Jingwen Chen wrote: > > >

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Thu Jul 22, 2021 at 10:45:40AM -0400, Andrey Grodzovsky wrote: > > On 2021-07-22 6:45 a.m., Jingwen Chen wrote: > > On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: > > > On 2021-07-20 11:13 p.m., Jingwen Chen wrote: > > > > [Why] > > > > After embeded hw_fence to amdgpu_job, w

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Andrey Grodzovsky
On 2021-07-22 6:45 a.m., Jingwen Chen wrote: On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: On 2021-07-20 11:13 p.m., Jingwen Chen wrote: [Why] After embeded hw_fence to amdgpu_job, we need to add tdr support for this feature. [How] 1. Add a resubmit_flag for resubmit jobs

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Christian König
Am 22.07.21 um 16:45 schrieb Andrey Grodzovsky: On 2021-07-22 6:45 a.m., Jingwen Chen wrote: On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: On 2021-07-20 11:13 p.m., Jingwen Chen wrote: [Why] After embeded hw_fence to amdgpu_job, we need to add tdr support for this feature.

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-22 Thread Jingwen Chen
On Wed Jul 21, 2021 at 12:53:51PM -0400, Andrey Grodzovsky wrote: > > On 2021-07-20 11:13 p.m., Jingwen Chen wrote: > > [Why] > > After embeded hw_fence to amdgpu_job, we need to add tdr support > > for this feature. > > > > [How] > > 1. Add a resubmit_flag for resubmit jobs. > > 2. Clear job fen

Re: [PATCH 2/2] drm: add tdr support for embeded hw_fence

2021-07-21 Thread Andrey Grodzovsky
On 2021-07-20 11:13 p.m., Jingwen Chen wrote: [Why] After embeded hw_fence to amdgpu_job, we need to add tdr support for this feature. [How] 1. Add a resubmit_flag for resubmit jobs. 2. Clear job fence from RCU and force complete vm flush fences in pre_asic_reset 3. skip dma_fence_get for