Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-05 Thread Felix Kuehling
Am 2021-05-05 um 9:51 a.m. schrieb Eric Huang: > In NPS4 BIOS we need to find the closest numa node when creating > topology io link between cpu and gpu, if PCI driver doesn't set > it. > > Signed-off-by: Eric Huang Reviewed-by: Felix Kuehling > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 9

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-05 Thread Eric Huang
On 2021-05-03 3:34 p.m., Felix Kuehling wrote: Am 2021-05-03 um 3:27 p.m. schrieb Eric Huang: On 2021-05-03 3:13 p.m., Felix Kuehling wrote: Am 2021-05-03 um 10:47 a.m. schrieb Eric Huang: In NPS4 BIOS we need to find the closest numa node when creating topology io link between cpu and gpu,

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-04 Thread Eric Huang
hanks, Lijo *From:* Huang, JinHuiEric *Sent:* Tuesday, May 4, 2021 7:30:44 PM *To:* Lazar, Lijo ; amd-gfx@lists.freedesktop.org *Subject:* Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology Like I answer Oak'

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-04 Thread Lazar, Lijo
esday, May 4, 2021 7:30:44 PM To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology Like I answer Oak's question, "For GCD parsing, the relation of GCD to CCD is defined by AMD, generic parsing in srat.c is considering a GC

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-04 Thread Eric Huang
Like I answer Oak's question, "For GCD parsing, the relation of GCD to CCD is defined by AMD, generic parsing in srat.c is considering a GCD as a new numa node which is not suitable for our need." GCD's pxm domain will get a wrong numa node which may be bigger than CCD domains, so I have to d

RE: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-04 Thread Lazar, Lijo
[AMD Public Use] > *numa_node > max_pxm Why numa node number is compared to a proximity domain? Since you are already using pxm_to_node() API, assume that should take care. That also will avoid parsing ACPI_SRAT_TYPE_CPU_AFFINITY structs. Thanks, Lijo -Original Message- From: amd-gfx

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-03 Thread Zeng, Oak
Ok, that makes sense. Thanks for explaining. Regards, Oak On 2021-05-03, 3:13 PM, "Huang, JinHuiEric" wrote: In drivers/acpi/numa/srat.c, the generic CCD parsing is for the mapping of numa node and pxm domain that creates arrays of pxm_to_node_map and node_to_pxm_map. We are

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-03 Thread Felix Kuehling
Am 2021-05-03 um 3:27 p.m. schrieb Eric Huang: > > > On 2021-05-03 3:13 p.m., Felix Kuehling wrote: >> Am 2021-05-03 um 10:47 a.m. schrieb Eric Huang: >>> In NPS4 BIOS we need to find the closest numa node when creating >>> topology io link between cpu and gpu, if PCI driver doesn't set >>> it. >>>

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-03 Thread Eric Huang
On 2021-05-03 3:13 p.m., Felix Kuehling wrote: Am 2021-05-03 um 10:47 a.m. schrieb Eric Huang: In NPS4 BIOS we need to find the closest numa node when creating topology io link between cpu and gpu, if PCI driver doesn't set it. Signed-off-by: Eric Huang --- drivers/gpu/drm/amd/amdkfd/kfd_c

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-03 Thread Eric Huang
In drivers/acpi/numa/srat.c, the generic CCD parsing is for the mapping of numa node and pxm domain that creates arrays of pxm_to_node_map and node_to_pxm_map. We are currently using API pxm_to_node() to get the corresponding information. For GCD parsing, the relation of GCD to CCD is defined

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-03 Thread Felix Kuehling
Am 2021-05-03 um 10:47 a.m. schrieb Eric Huang: > In NPS4 BIOS we need to find the closest numa node when creating > topology io link between cpu and gpu, if PCI driver doesn't set > it. > > Signed-off-by: Eric Huang > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 95 ++- >

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-03 Thread Zeng, Oak
I feel such parsing work should be part of the ACPI generic work so should be done in drivers/acpi/num/srat.c (see acpi_table_parse_srat) and the acpi subsystem should expose APIs for rest drivers to query such numa information. Regards, Oak On 2021-04-28, 11:12 AM, "amd-gfx on behalf of E

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-05-03 Thread Eric Huang
Thanks Felix for your review. I will send another patch. Eric On 2021-04-30 7:42 p.m., Felix Kuehling wrote: Am 2021-04-28 um 11:11 a.m. schrieb Eric Huang: In NPS4 BIOS we need to find the closest numa node when creating topology io link between cpu and gpu, if PCI driver doesn't set it. Sig

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-04-30 Thread Felix Kuehling
Am 2021-04-28 um 11:11 a.m. schrieb Eric Huang: > In NPS4 BIOS we need to find the closest numa node when creating > topology io link between cpu and gpu, if PCI driver doesn't set > it. > > Signed-off-by: Eric Huang > --- > drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 94 ++- >

Re: [PATCH] drm/amdkfd: add ACPI SRAT parsing for topology

2021-04-30 Thread Eric Huang
ping... On 2021-04-28 11:11 a.m., Eric Huang wrote: In NPS4 BIOS we need to find the closest numa node when creating topology io link between cpu and gpu, if PCI driver doesn't set it. Signed-off-by: Eric Huang --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 94 ++- 1 fi