RE: [PATCH] drm/amdgpu: protect kiq overrun

2020-04-22 Thread Tao, Yintian
Sent: 2020年4月23日 2:43 To: Tao, Yintian ; Liu, Monk ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: protect kiq overrun Am 22.04.20 um 16:50 schrieb Yintian Tao: > Wait for the oldest sequence on the kiq ring to be signaled in order > to make sure ther

Re: [PATCH] drm/amdgpu: protect kiq overrun

2020-04-22 Thread Christian König
Am 22.04.20 um 16:50 schrieb Yintian Tao: Wait for the oldest sequence on the kiq ring to be signaled in order to make sure there will be no kiq overrun. v2: remove unused the variable and correct kiq max_sub_num value First of all this should probably be added to the fence handling code

Re: [PATCH] drm/amdgpu: protect kiq overrun

2020-04-22 Thread Christian König
oyun ; Tao, Yintian ; Liu, Monk ; Kuehling, Felix Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: protect kiq overrun The amdgpu_ring_alloc() function checks if the requested number of DW don't exceed the maximum submission size. It does NOT check if there is enough room on

RE: [PATCH] drm/amdgpu: protect kiq overrun

2020-04-22 Thread Liu, Shaoyun
PATCH] drm/amdgpu: protect kiq overrun The amdgpu_ring_alloc() function checks if the requested number of DW don't exceed the maximum submission size. It does NOT check if there is enough room on the ring. That would require MMIO access and that is what we want to avoid. Regards, Christian. A

Re: [PATCH] drm/amdgpu: protect kiq overrun

2020-04-22 Thread Christian König
The amdgpu_ring_alloc() function checks if the requested number of DW don't exceed the maximum submission size. It does NOT check if there is enough room on the ring. That would require MMIO access and that is what we want to avoid. Regards, Christian. Am 22.04.20 um 16:54 schrieb Liu, Shaoy

RE: [PATCH] drm/amdgpu: protect kiq overrun

2020-04-22 Thread Liu, Shaoyun
[AMD Official Use Only - Internal Distribution Only] I think each kiq operation will call ring_alloc for the package space , why not just check whether this allocation is succeed or not ? Shaoyun.liu -Original Message- From: amd-gfx On Behalf Of Yintian Tao Sent: Wednesday, Apri