Re: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job

2025-08-04 Thread Christian König
On 23.07.25 11:06, YuanShang wrote: > job->vm is used in function amdgpu_job_run to get the page > table re-generation counter and decide whether the job should be skipped. Support for resubmitting jobs was removed, so that code should probably be removed as well. We should probably move the cal

RE: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job

2025-07-29 Thread YuanShang Mao (River)
ne) Subject: Re: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job On Mon, Jul 28, 2025 at 10:41 PM YuanShang Mao (River) wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Alexander > > > I didn't think we actually resubmi

Re: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job

2025-07-29 Thread Alex Deucher
m: Alex Deucher > Sent: Tuesday, July 29, 2025 2:10 AM > To: YuanShang Mao (River) > Cc: Deucher, Alexander ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org; cao, lin > ; Zhang, Tiantian (Celine) > Subject: Re: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_pre

RE: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job

2025-07-28 Thread YuanShang Mao (River)
tian (Celine) Subject: Re: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job On Mon, Jul 28, 2025 at 5:01 AM YuanShang Mao (River) wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Alexander > > Since Christian is on vacation. Could yo

Re: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job

2025-07-28 Thread Alex Deucher
On Mon, Jul 28, 2025 at 5:01 AM YuanShang Mao (River) wrote: > > [AMD Official Use Only - AMD Internal Distribution Only] > > Hi Alexander > > Since Christian is on vacation. Could you help review the below patch? > If set job->vm to null in amdgpu_job_prepare_job, the job which >

RE: [PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job

2025-07-28 Thread YuanShang Mao (River)
[AMD Official Use Only - AMD Internal Distribution Only] Hi Alexander Since Christian is on vacation. Could you help review the below patch? If set job->vm to null in amdgpu_job_prepare_job, the job which should be skipped in amdgpu_job_run will be submitted unexpectedly. Thanks