Re: [PATCH] drm/amdgpu: further lower VRAM allocation overhead

2021-07-15 Thread Felix Kuehling
Looking at the ticket, it's getting a segfault in user mode. The only possible mechanism I can see where this change causes that segfault, is a badly handled memory allocation failure. But I don't have an explanation for how this patch introduces a memory allocation failure that wasn't there before

Re: [PATCH] drm/amdgpu: further lower VRAM allocation overhead

2021-07-15 Thread Eric Huang
Hi Christian, I have pushed it into amd-staging-dkms-5.11, but it causes a regression with test TransferBench on MI200. Jira is here: https://ontrack-internal.amd.com/browse/SWDEV-295245 Can you please take a look? Thanks! Regards, Eric On 2021-07-14 4:33 a.m., Christian König wrote: Hi Eri

Re: [PATCH] drm/amdgpu: further lower VRAM allocation overhead

2021-07-14 Thread Pan, Xinhui
> 2021年7月14日 16:33,Christian König 写道: > > Hi Eric, > > feel free to push into amd-staging-dkms-5.11, but please don't push it into > amd-staging-drm-next. > > The later will just cause a merge failure which Alex needs to resolve > manually. > > I can take care of pushing to amd-staging-dr

Re: [PATCH] drm/amdgpu: further lower VRAM allocation overhead

2021-07-14 Thread Christian König
Am 14.07.21 um 11:41 schrieb Pan, Xinhui: 2021年7月14日 16:33,Christian König 写道: Hi Eric, feel free to push into amd-staging-dkms-5.11, but please don't push it into amd-staging-drm-next. The later will just cause a merge failure which Alex needs to resolve manually. I can take care of pushin

Re: [PATCH] drm/amdgpu: further lower VRAM allocation overhead

2021-07-14 Thread Christian König
Am 13.07.21 um 18:11 schrieb Felix Kuehling: Am 2021-07-13 um 9:32 a.m. schrieb Christian König: For allocations larger than 48MiB we need more than a page for the housekeeping in the worst case resulting in the usual vmalloc overhead. Try to avoid this by assuming the good case and only fallin

Re: [PATCH] drm/amdgpu: further lower VRAM allocation overhead

2021-07-14 Thread Christian König
Hi Eric, feel free to push into amd-staging-dkms-5.11, but please don't push it into amd-staging-drm-next. The later will just cause a merge failure which Alex needs to resolve manually. I can take care of pushing to amd-staging-drm-next as soon as that is rebased on latest upstream. Reg

Re: [PATCH] drm/amdgpu: further lower VRAM allocation overhead

2021-07-13 Thread Eric Huang
Hi Christian/Felix, If you don't have objection, it will be pushed into amd-staging-dkms-5.11 and amd-staging-drm-next. Thanks, Eric On 2021-07-13 3:17 p.m., Eric Huang wrote: For allocations larger than 48MiB we need more than a page for the housekeeping in the worst case resulting in the u

Re: [PATCH] drm/amdgpu: further lower VRAM allocation overhead

2021-07-13 Thread Eric Huang
I am converting codes into amd-staging-drm-next. Theoretically it will improve a lot on the latency, the size of the array allocated is 24 (PAGE_SIZE/struct drm_mm_node) with this patch, and it was 8192 before. So the latency should be reduced by 98 us. Regards, Eric On 2021-07-13 12:11 p.m.,

Re: [PATCH] drm/amdgpu: further lower VRAM allocation overhead

2021-07-13 Thread Felix Kuehling
Am 2021-07-13 um 9:32 a.m. schrieb Christian König: > For allocations larger than 48MiB we need more than a page for the > housekeeping in the worst case resulting in the usual vmalloc overhead. > > Try to avoid this by assuming the good case and only falling back to the > worst case if this didn't