Re: [PATCH] drm/amdgpu: fix huge page handling on Vega10

2018-11-13 Thread Samuel Pitoiset
On 11/13/18 9:14 AM, Christian König wrote: Am 12.11.18 um 22:45 schrieb Samuel Pitoiset: On 11/12/18 6:16 PM, Alex Deucher wrote: On Mon, Nov 12, 2018 at 12:09 PM Christian König wrote: We accidentially set the huge flag on the parent instead of the childs. This caused some VM faults un

Re: [PATCH] drm/amdgpu: fix huge page handling on Vega10

2018-11-13 Thread Christian König
Am 12.11.18 um 22:45 schrieb Samuel Pitoiset: On 11/12/18 6:16 PM, Alex Deucher wrote: On Mon, Nov 12, 2018 at 12:09 PM Christian König wrote: We accidentially set the huge flag on the parent instead of the childs. This caused some VM faults under memory pressure. Signed-off-by: Christian

Re: [PATCH] drm/amdgpu: fix huge page handling on Vega10

2018-11-12 Thread Christian König
Am 13.11.18 um 00:50 schrieb Kuehling, Felix: On 2018-11-12 12:09 p.m., Christian König wrote: We accidentially set the huge flag on the parent instead of the childs. This caused some VM faults under memory pressure. Reviewed-by: Felix Kuehling I got a bit confused when re-reading this code.

Re: [PATCH] drm/amdgpu: fix huge page handling on Vega10

2018-11-12 Thread Kuehling, Felix
On 2018-11-12 12:09 p.m., Christian König wrote: > We accidentially set the huge flag on the parent instead of the childs. > This caused some VM faults under memory pressure. Reviewed-by: Felix Kuehling I got a bit confused when re-reading this code. Maybe part of it is that cursor.entry is not

Re: [PATCH] drm/amdgpu: fix huge page handling on Vega10

2018-11-12 Thread Samuel Pitoiset
On 11/12/18 6:16 PM, Alex Deucher wrote: On Mon, Nov 12, 2018 at 12:09 PM Christian König wrote: We accidentially set the huge flag on the parent instead of the childs. This caused some VM faults under memory pressure. Signed-off-by: Christian König Yes, this fixes GPU hangs with F12017

Re: [PATCH] drm/amdgpu: fix huge page handling on Vega10

2018-11-12 Thread Alex Deucher
On Mon, Nov 12, 2018 at 12:09 PM Christian König wrote: > > We accidentially set the huge flag on the parent instead of the childs. > This caused some VM faults under memory pressure. > > Signed-off-by: Christian König Acked-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 18