Re: [PATCH] drm/amdgpu: always use polling mem to update wptr v2

2017-12-12 Thread Christian König
One minor style nit pick: + } else + ring->use_pollmem = true; When the true part of an "if/else" uses {} the false part should use it as well. With that fixed and a Monks comment addressed the patch is Reviewed-by: Christian König . Christian. Am 12.12.

RE: [PATCH] drm/amdgpu: always use polling mem to update wptr v2

2017-12-11 Thread Liu, Monk
Please make description in your comments more detail, e.g. : We have two sources to update wptr registers for sdma3: 1) wptr_poll and 2) is doorbell. When doorbell and wptr_poll are both enabled on sdma3, there will be collision hit in occasion between those two sources when ucode and h/w are do

Re: [PATCH] drm/amdgpu: always use polling mem to update wptr

2017-12-11 Thread Ding, Pixel
Hi Monk, Please review. — Sincerely Yours, Pixel On 12/12/2017, 2:05 PM, "Pixel Ding" wrote: Both doorbell and polling mem are working on Tonga VF. SDMA issue happens because SDMA engine accepts doorbell writes even if it's inactive, that introduces conflict when world switch rou