Re: [PATCH] drm/amdgpu: add JPEG check to VCN idle handler and begin use

2019-12-12 Thread Leo Liu
On 2019-12-12 3:18 a.m., Christian König wrote: Am 11.12.19 um 20:48 schrieb Leo Liu: Since it's only needed with VCN1.0 when HW has no its own JPEG HW IP block Wouldn't it be simpler/cleaner to just define a vcn_v1_0_ring_begin_use() and vcn_v1_0_idle_work_handler() instead? Yeah, this wa

Re: [PATCH] drm/amdgpu: add JPEG check to VCN idle handler and begin use

2019-12-12 Thread Christian König
Am 12.12.19 um 16:57 schrieb Leo Liu: On 2019-12-12 3:18 a.m., Christian König wrote: Am 11.12.19 um 20:48 schrieb Leo Liu: Since it's only needed with VCN1.0 when HW has no its own JPEG HW IP block Wouldn't it be simpler/cleaner to just define a vcn_v1_0_ring_begin_use() and vcn_v1_0_idle_

Re: [PATCH] drm/amdgpu: add JPEG check to VCN idle handler and begin use

2019-12-12 Thread Christian König
Am 11.12.19 um 20:48 schrieb Leo Liu: Since it's only needed with VCN1.0 when HW has no its own JPEG HW IP block Wouldn't it be simpler/cleaner to just define a vcn_v1_0_ring_begin_use() and vcn_v1_0_idle_work_handler() instead? Regards, Christian. Signed-off-by: Leo Liu --- drivers/gp

RE: [PATCH] drm/amdgpu: add JPEG check to VCN idle handler and begin use

2019-12-11 Thread Zhang, Boyuan
This patch is Reviewed-by: Boyuan Zhang -Original Message- From: amd-gfx On Behalf Of Leo Liu Sent: December 11, 2019 2:48 PM To: amd-gfx@lists.freedesktop.org Cc: Liu, Leo Subject: [PATCH] drm/amdgpu: add JPEG check to VCN idle handler and begin use Since it's only needed with VCN1.

Re: [PATCH] drm/amdgpu: add JPEG check to VCN idle handler and begin use

2019-12-11 Thread Alex Deucher
On Wed, Dec 11, 2019 at 2:49 PM Leo Liu wrote: > > Since it's only needed with VCN1.0 when HW has no its > own JPEG HW IP block typo "HW does not have its own" With that fixed: Reviewed-by: Alex Deucher > > Signed-off-by: Leo Liu > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 29 ++