RE: [PATCH] drm/amdgpu: Need to free discovery memory

2019-11-01 Thread Zhang, Hawking
Emily ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Need to free discovery memory Hi Emily, Thanks for catching this. I think freeing Discovery TMR bo should be put at amdgpu_ttm_fini() instead of amdgpu_ttm_late_init() because unlike VGA stolen bo, touching PSP-protected Disc

Re: [PATCH] drm/amdgpu: Need to free discovery memory

2019-11-01 Thread Yuan, Xiaojie
Hi Emily, Thanks for catching this. I think freeing Discovery TMR bo should be put at amdgpu_ttm_fini() instead of amdgpu_ttm_late_init() because unlike VGA stolen bo, touching PSP-protected Discovery TMR bo will cause GPU hang. Therefore, it should be reserved across the life-cycle of amdgpu