Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-28 Thread Felix Kuehling
rg *Cc:* Grodzovsky, Andrey ; Chen, Guchun *Subject:* Re: [PATCH] drm/amdgpu: Fix an error message in rmmod The hang you're seeing is the result of a command submission of an UNMAP_QUEUES and QUERY_STATUS command to the HIQ. This is done using a doorbell. KFD writes commands to the HIQ and rings

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-27 Thread Yin, Tianci (Rico)
ent: Thursday, January 27, 2022 23:28 To: Yin, Tianci (Rico) ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Chen, Guchun Subject: Re: [PATCH] drm/amdgpu: Fix an error message in rmmod The hang you're seeing is the result of a command submission of an UNMAP_QU

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-27 Thread Felix Kuehling
*From:* Kuehling, Felix *Sent:* Wednesday, January 26, 2022 23:08 *To:* Yin, Tianci (Rico) ; Wang, Yang(Kevin) ; amd-gfx@lists.freedesktop.org *Cc:* Grodzovsky, Andrey ; Chen, Guchun *Subject:* Re: [PATCH] drm/amdgpu: Fix an error message in rmmod My question is, why is this problem only seen during m

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-26 Thread Yin, Tianci (Rico)
: Grodzovsky, Andrey ; Chen, Guchun Subject: Re: [PATCH] drm/amdgpu: Fix an error message in rmmod My question is, why is this problem only seen during module unload? Why aren't we seeing HWS hangs due to GFX_OFF all the time in normal operations? For example when the GPU is idle and a new KFD p

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-26 Thread Felix Kuehling
lix *Sent:* Tuesday, January 25, 2022 23:31 *To:* Wang, Yang(Kevin) ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org *Cc:* Grodzovsky, Andrey ; Chen, Guchun *Subject:* Re: [PATCH] drm/amdgpu: Fix an error message in rmmod I have no objection to the change. It restores the sequence tha

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-25 Thread Yin, Tianci (Rico)
hanks again! Rico From: Kuehling, Felix Sent: Tuesday, January 25, 2022 23:31 To: Wang, Yang(Kevin) ; Yin, Tianci (Rico) ; amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Chen, Guchun Subject: Re: [PATCH] drm/amdgpu: Fix an error message in rmmod I ha

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-25 Thread Felix Kuehling
I have no objection to the change. It restores the sequence that was used before e9669fb78262. But I don't understand why GFX_OFF is causing a preemption error during module unload, but not when KFD is in normal use. Maybe it's because of the compute power profile that's normally set by amdgpu_

Re: [PATCH] drm/amdgpu: Fix an error message in rmmod

2022-01-25 Thread Wang, Yang(Kevin)
[AMD Official Use Only] the issue is introduced in following patch, so add following information is better. fixes: (e9669fb78262) drm/amdgpu: Add early fini callback Reviewed-by: Yang Wang Best Regards, Kevin From: amd-gfx on behalf of Tianci Yin Sent: Tues