,
Jiawei
*From:* Christian König
*Sent:* Wednesday, May 19, 2021 9:23 PM
*To:* Deucher, Alexander ; Gu, JiaWei
(Will) ; Nieto, David M ;
Koenig, Christian ;
amd-gfx@lists.freedesktop.org; mar...@gmail.com
*Cc:* Deng, Emily
*Subject:* Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
On Wed, May 19, 2021 at 10:59 PM Jiawei Gu wrote:
>
> Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info.
>
> Provides a way for the user application to get the VBIOS
> information without having to parse the binary.
> It is useful for the user to be able to display in a simple way the
; mar...@gmail.com
Cc: Deng, Emily
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
Good point.
If you want to double check the alignment you can use something like "pahole
drivers/gpu/drm/amd/amdgpu/amdgpu.ko -C drm_amdgpu_info_vbios" after building
the kernel module
tr[32];
> + __u8 date[32];
> +};
*From:* Gu, JiaWei (Will)
*Sent:* Tuesday, May 18, 2021 1:58 AM
*To:* Nieto, David M ; Koenig, Christian
; amd-gfx@lists.freedesktop.org
; mar...@gmail.com ;
Deucher, Alexander
*Cc:* Deng, Emily
*Subject:* RE: [PATCH] drm/amdgpu: Add vbios info
t; + __u8 date[32];
> +};
From: Gu, JiaWei (Will)
Sent: Tuesday, May 18, 2021 1:58 AM
To: Nieto, David M ; Koenig, Christian
; amd-gfx@lists.freedesktop.org
; mar...@gmail.com ; Deucher,
Alexander
Cc: Deng, Emily
Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[Public]
Hi
, Alexander
Cc: Deng, Emily
Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[Public]
Not sure about this one – vbios version : 285409288
Windows driver reports VBIOS version from atom_firmware_info_v3_1 /
firmware_revision.
Thanks,
Lijo
From: amd-gfx On Behalf Of Gu, JiaWei
t; From: StDenis, Tom
> Sent: Tuesday, May 18, 2021 9:26 PM
> To: Koenig, Christian ; Gu, JiaWei (Will) <
> jiawei...@amd.com>; amd-gfx@lists.freedesktop.org; Nieto, David M <
> david.ni...@amd.com>; mar...@gmail.com; Deucher, Alexander <
> alexander.deuc...@amd.com>
>
riginal Message-
From: StDenis, Tom
Sent: Tuesday, May 18, 2021 9:26 PM
To: Koenig, Christian ; Gu, JiaWei (Will)
; amd-gfx@lists.freedesktop.org; Nieto, David M
; mar...@gmail.com; Deucher, Alexander
Cc: Deng, Emily
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[AMD Of
önig
Sent: Tuesday, May 18, 2021 09:17
To: Gu, JiaWei (Will); amd-gfx@lists.freedesktop.org; Nieto, David M;
mar...@gmail.com; Deucher, Alexander
Cc: Deng, Emily
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
Well not an expert on that stuff, but looks like that should work for me.
Well not an expert on that stuff, but looks like that should work for me.
Question is can you provide a patch to use that information in Mesa as
well? Umr might be sufficient as well as justification for upstreaming,
but I want to be better save than sorry.
Unless Marek has a better idea mayb
[AMD Official Use Only - Internal Distribution Only]
Hi all,
Please help confirm that we're all fine with this new struct in uapi in this V3
patch:
+struct drm_amdgpu_info_vbios {
+ __u8 name[64];
+ __u8 vbios_pn[64];
+ __u32 version;
+ __u8 vbios_ver_str[32];
+ __
-gfx@lists.freedesktop.org; mar...@gmail.com;
Deucher, Alexander
Cc: Deng, Emily
Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[Public]
[Public]
Hi all,
Then the struct looks like:
> +struct drm_amdgpu_info_vbios {
> + __u8 name[64];
> + __u8 vb
Best regards,
Jiawei
From: Nieto, David M
Sent: Tuesday, May 18, 2021 12:40 PM
To: Gu, JiaWei (Will) ; Koenig, Christian
; amd-gfx@lists.freedesktop.org; mar...@gmail.com;
Deucher, Alexander
Cc: Deng, Emily
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[Public]
Y
Sent: Tuesday, May 18, 2021 12:40 PM
To: Gu, JiaWei (Will) ; Koenig, Christian
; amd-gfx@lists.freedesktop.org; mar...@gmail.com;
Deucher, Alexander
Cc: Deng, Emily
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[Public]
Yes, let's remove that too,
Thanks,
David
_
rds,
Jiawei
From: Nieto, David M
Sent: Tuesday, May 18, 2021 10:45 AM
To: Gu, JiaWei (Will) ; Koenig, Christian
; amd-gfx@lists.freedesktop.org; mar...@gmail.com;
Deucher, Alexander
Cc: Deng, Emily
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[AMD Official Use Only - I
18, 2021 10:45 AM
To: Gu, JiaWei (Will) ; Koenig, Christian
; amd-gfx@lists.freedesktop.org; mar...@gmail.com;
Deucher, Alexander
Cc: Deng, Emily
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[AMD Official Use Only - Internal Distribution Only]
The serial number is ASIC in
Sent: Monday, May 17, 2021 7:11 PM
To: Koenig, Christian ; amd-gfx@lists.freedesktop.org
; Nieto, David M ;
mar...@gmail.com ; Deucher, Alexander
Cc: Deng, Emily
Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[AMD Official Use Only - Internal Distribution Only]
So I guess the db
ail.com; Deucher, Alexander
Cc: Deng, Emily
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
I'm not very familiar with the technical background why we have the fields here
once more.
But of hand we should at least remove everything which is also available from
the PCI i
I'm not very familiar with the technical background why we have the
fields here once more.
But of hand we should at least remove everything which is also available
from the PCI information.
E.g. dev_id, rev_id, sub_dev_id, sub_ved_id.
Regards,
Christian.
Am 17.05.21 um 14:17 schrieb Gu, Jia
[AMD Official Use Only - Internal Distribution Only]
Hi all,
Thanks Christian's suggestion.
I reverted the previous patches and squash them into this single one.
As this patch shows, the current uapi change looks like this:
+struct drm_amdgpu_info_vbios {
+ __u8 name[64];
+ __u32 db
Hi!
This patch needs some fixing.
On Thu, Apr 22, 2021 at 10:34:48AM +0800, Jiawei Gu wrote:
> + case AMDGPU_INFO_VBIOS_INFO: {
> + struct drm_amdgpu_info_vbios vbios_info = {};
> + struct atom_context *atom_context;
> +
> +
; To: Gu, JiaWei (Will) ; Deucher, Alexander
>
> Cc: StDenis, Tom ; Deucher, Alexander
> ; Christian König
> ; Gu, JiaWei (Will) ;
> amd-gfx@lists.freedesktop.org; Nieto, David M ;
> linux-n...@vger.kernel.org
> Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interfac
From: Kees Cook
Sent: Saturday, May 8, 2021 2:51 AM
To: Gu, JiaWei (Will)
Cc: Deucher, Alexander ; StDenis, Tom
; Christian König ;
amd-gfx@lists.freedesktop.org ; Nieto, David M
; linux-n...@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
On Sat, May 08
Sent: Saturday, May 8, 2021 12:28 PM
To: Gu, JiaWei (Will) ; Deucher, Alexander
Cc: StDenis, Tom ; Deucher, Alexander
; Christian König
; Gu, JiaWei (Will) ;
amd-gfx@lists.freedesktop.org; Nieto, David M ;
linux-n...@vger.kernel.org
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl
esktop.org; StDenis,
> Tom
> Cc: Deucher, Alexander
> Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface
>
> [AMD Official Use Only - Internal Distribution Only]
>
> Hi @StDenis, Tom<mailto:tom.stde...@amd.com>,
>
> We have merged vbios info ioctl patch.
>
in if it was reverted before?
>
> Thanks in advance!
> Jiawei
>
> From: Gu, JiaWei (Will)
> Sent: Wednesday, April 28, 2021 4:21 PM
> To: Christian König ; Nieto, David M
> ; amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander ; StDenis, Tom
>
> Subject: RE:
nig; Nieto, David M; amd-gfx@lists.freedesktop.org; StDenis, Tom
Cc: Deucher, Alexander
Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[AMD Official Use Only - Internal Distribution Only]
Hi @StDenis, Tom<mailto:tom.stde...@amd.com>,
We have merged vbios info ioctl patch.
C
, 2021 4:21 PM
To: Christian König ; Nieto, David M
; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; StDenis, Tom
Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[AMD Official Use Only - Internal Distribution Only]
Thanks Christian,
I amended the commit message and rese
; Gu, JiaWei (Will)
; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; StDenis, Tom
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
Yeah, makes sense. Please note that in the commit message.
With that feel free to put an Acked-by: Christian König
<mailto:christian.
.freedesktop.org>
<mailto:amd-gfx@lists.freedesktop.org>
*Cc: *"Deucher, Alexander"
<mailto:alexander.deuc...@amd.com>, "StDenis, Tom"
<mailto:tom.stde...@amd.com>, "Nieto, David
M" <mailto:david.ni...@amd.com>
*S
sts.freedesktop.org"
Cc: "Deucher, Alexander" , "StDenis, Tom"
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
Well displaying the VBIOS information along with the other firmware in
userspace is certainly useful.
We should just avoid making strong depend
uot;
*Cc: *"Deucher, Alexander" , "StDenis, Tom"
, "Nieto, David M"
*Subject: *RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[AMD Official Use Only - Internal Distribution Only]
Hi Christian,
It will be used by a user space SMI-lib for GPU status query.
ot;Gu, JiaWei
(Will)"
Date: Thursday, April 22, 2021 at 8:25 PM
To: Christian König ,
"amd-gfx@lists.freedesktop.org"
Cc: "Deucher, Alexander" , "StDenis, Tom"
, "Nieto, David M"
Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface
[AMD O
il 22, 2021 9:27 PM
To: Gu, JiaWei (Will) ; amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander ; StDenis, Tom
Subject: Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface
Is that useful to Vulkan/OpenGL/other clients in any way?
Christian.
Am 22.04.21 um 15:18 schrieb Gu, JiaWei (Will):
Is that useful to Vulkan/OpenGL/other clients in any way?
Christian.
Am 22.04.21 um 15:18 schrieb Gu, JiaWei (Will):
CC Tom.
On Apr 22, 2021, at 21:09, Gu, JiaWei (Will) wrote:
<[v2][umr]add-vbios-info-query.patch>
UMR patch which calls this new IOCTL attached.
Best regards,
Jiawei
On Ap
CC Tom.
> On Apr 22, 2021, at 21:09, Gu, JiaWei (Will) wrote:
>
> <[v2][umr]add-vbios-info-query.patch>
> UMR patch which calls this new IOCTL attached.
>
> Best regards,
> Jiawei
>
>> On Apr 22, 2021, at 10:34, Jiawei Gu wrote:
>>
>> Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbio
UMR patch which calls this new IOCTL attached.
Best regards,
Jiawei
> On Apr 22, 2021, at 10:34, Jiawei Gu wrote:
>
> Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info.
>
> Signed-off-by: Jiawei Gu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 19 +++
> drivers/gpu/drm/am
On Wed, Apr 14, 2021 at 5:09 AM Jiawei Gu wrote:
>
> Add AMDGPU_INFO_VBIOS_INFO subquery id for detailed vbios info.
Please provide a link to patches for an open source tool which uses
this new query.
>
> Signed-off-by: Jiawei Gu
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c| 19 +++
>
38 matches
Mail list logo
