RE: [PATCH] drm/amdgpu: Add comments to gmc structure

2019-11-07 Thread Zeng, Oak
: Thursday, November 7, 2019 12:16 PM To: Alex Deucher ; Zeng, Oak Cc: Kuehling, Felix ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Add comments to gmc structure If this is not submitted, I would like to see some comments regarding the explanation of MC address

Re: [PATCH] drm/amdgpu: Add comments to gmc structure

2019-11-07 Thread Zhao, Yong
, November 7, 2019 9:02 AM To: Zeng, Oak Cc: Kuehling, Felix ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: Add comments to gmc structure On Wed, Nov 6, 2019 at 12:27 PM Zeng, Oak wrote: > > Explain fields like aper_base, agp_start etc. The definition >

Re: [PATCH] drm/amdgpu: Add comments to gmc structure

2019-11-07 Thread Alex Deucher
On Wed, Nov 6, 2019 at 12:27 PM Zeng, Oak wrote: > > Explain fields like aper_base, agp_start etc. The definition > of those fields are confusing as they are from different view > (CPU or GPU). Add comments for easier understand. > > Change-Id: I02c2a27cd0dbc205498eb86aafa722f2e0c25fe6 > Signed-of

Re: [PATCH] drm/amdgpu: Add comments to gmc structure

2019-11-07 Thread Christian König
Am 06.11.19 um 18:26 schrieb Zeng, Oak: Explain fields like aper_base, agp_start etc. The definition of those fields are confusing as they are from different view (CPU or GPU). Add comments for easier understand. Change-Id: I02c2a27cd0dbc205498eb86aafa722f2e0c25fe6 Signed-off-by: Oak Zeng ---

Re: [PATCH] drm/amdgpu: Add comments to gmc structure

2019-11-07 Thread Koenig, Christian
Koenig, Christian > Subject: Re: [PATCH] drm/amdgpu: Add comments to gmc structure > > On Wed, Nov 6, 2019 at 12:21 PM Zeng, Oak wrote: >> Explain fields like aper_base, agp_start etc. The definition of those >> fields are confusing as they are from different view (C

RE: [PATCH] drm/amdgpu: Add comments to gmc structure

2019-11-06 Thread Zeng, Oak
Oak Cc: amd-gfx@lists.freedesktop.org; Kuehling, Felix ; Koenig, Christian Subject: Re: [PATCH] drm/amdgpu: Add comments to gmc structure On Wed, Nov 6, 2019 at 12:21 PM Zeng, Oak wrote: > > Explain fields like aper_base, agp_start etc. The definition of those > fields are confusing as t

Re: [PATCH] drm/amdgpu: Add comments to gmc structure

2019-11-06 Thread Alex Deucher
On Wed, Nov 6, 2019 at 12:21 PM Zeng, Oak wrote: > > Explain fields like aper_base, agp_start etc. The definition > of those fields are confusing as they are from different view > (CPU or GPU). Add comments for easier understand. > > Change-Id: I02c2a27cd0dbc205498eb86aafa722f2e0c25fe6 > Signed-of