Re: [PATCH] drm/amdgpu: Add GFXOFF auto-tunning algorithm

2025-03-25 Thread Sergey Kovalenko
Here is the impact: Ryzen 5 2500U Idle PkgWatt: 1.3W -> 0.75W glxgears fps: 7200 -> 4500 aquarium 15,000 fish: 56-60 -> 45-50 These results are for gfx_off_ctrl_immediate() https://github.com/pacoandres/laikm/issues/56 https://github.com/pacoandres/laikm/issues/47 Same results are for default zer

Re: [PATCH] drm/amdgpu: Add GFXOFF auto-tunning algorithm

2025-03-25 Thread Sergey Kovalenko
"Moreover the work only gets scheduled/cancelled around a ref count of 0" - and this happens more than 600 times per second under load, as you can see from the table. Moreover these 600 GFXOFF requests are executed with a very little interval between them. If we set GFXOFF delay to 0 by default, i

Re: [PATCH] drm/amdgpu: Add GFXOFF auto-tunning algorithm

2025-03-25 Thread Sergey Kovalenko
Since there are several GPU series that require additional GFXOFF ON/OFF switches to ensure stability, this algorithm can be seen as a way to mitigate the negative effects of workarounds. Simple and efficient. Regards, Sergey On Mon, Mar 24, 2025 at 4:34 PM Sergey Kovalenko wrote: > > Hello Alex

Re: [PATCH] drm/amdgpu: Add GFXOFF auto-tunning algorithm

2025-03-25 Thread Sergey Kovalenko
Hello Alex! "If there are a lot of requests to toggle gfxoff, the worker thread to allow it again gets cancelled and scheduled again, extending the time it's disallowed." - That's true except one thing: cancelling and scheduling also take CPU cycles, and the pause between submissions can exceed 10

Re: [PATCH] drm/amdgpu: Add GFXOFF auto-tunning algorithm

2025-03-24 Thread Alex Deucher
On Mon, Mar 24, 2025 at 11:14 AM Sergey Kovalenko wrote: > > "Moreover the work only gets scheduled/cancelled > around a ref count of 0" - and this happens more than 600 times > per second under load, as you can see from the table. > Moreover these 600 GFXOFF requests are executed with a very > l

Re: [PATCH] drm/amdgpu: Add GFXOFF auto-tunning algorithm

2025-03-24 Thread Alex Deucher
On Mon, Mar 24, 2025 at 10:34 AM Sergey Kovalenko wrote: > > Hello Alex! > > "If there are a lot of requests to toggle gfxoff, the worker thread to > allow it again gets > cancelled and scheduled again, extending the time it's disallowed." - > That's true except one thing: > cancelling and schedul

Re: [PATCH] drm/amdgpu: Add GFXOFF auto-tunning algorithm

2025-03-24 Thread Alex Deucher
On Mon, Mar 24, 2025 at 5:06 AM Sergey Kovalenko wrote: > > Predict an optimal delay to enable GFXOFF for the next interval > based on the request count: > - less than 15 requests per second - zero delay > - less than 25 requests per second - default delay > - 25 and more requests per second - don