Re: [PATCH] drm/amd/pm: Check feature support using IP version

2022-03-25 Thread Lazar, Lijo
On 3/25/2022 4:55 PM, Wang, Yang(Kevin) wrote: [AMD Official Use Only]    if (adev->asic_type > CHIP_VEGA20) { +   if (gc_ver != IP_VERSION(9, 4, 0) && mp1_ver > IP_VERSION(9, 0, 0)) { /* VCN clocks */ [kevin]: please put some comments here (why mp1_ver and gc_v

Re: [PATCH] drm/amd/pm: Check feature support using IP version

2022-03-25 Thread Wang, Yang(Kevin)
[AMD Official Use Only] if (adev->asic_type > CHIP_VEGA20) { + if (gc_ver != IP_VERSION(9, 4, 0) && mp1_ver > IP_VERSION(9, 0, 0)) { /* VCN clocks */ [kevin]: please put some comments here (why mp1_ver and gc_ver is needed both), it can help developer to understand