Re: [PATCH] amdkfd: wq_release signals dma_fence only when available

2024-12-12 Thread Felix Kuehling
On 2024-12-12 0:30, Zhu Lingshan wrote: > On 12/12/2024 12:19 PM, Felix Kuehling wrote: >> >> On 2024-12-11 22:06, Zhu Lingshan wrote: >>> kfd_process_wq_release() signals eviction fence by >>> dma_fence_signal() which wanrs if dma_fence >>> is NULL. >> That's news to me. Looking at the dma_fenc

Re: [PATCH] amdkfd: wq_release signals dma_fence only when available

2024-12-12 Thread Chen, Xiaogang
On 12/11/2024 11:30 PM, Zhu Lingshan wrote: On 12/12/2024 12:19 PM, Felix Kuehling wrote: On 2024-12-11 22:06, Zhu Lingshan wrote: kfd_process_wq_release() signals eviction fence by dma_fence_signal() which wanrs if dma_fence is NULL. That's news to me. Looking at the dma_fence_signal impleme

Re: [PATCH] amdkfd: wq_release signals dma_fence only when available

2024-12-11 Thread Zhu Lingshan
On 12/12/2024 12:19 PM, Felix Kuehling wrote: > > On 2024-12-11 22:06, Zhu Lingshan wrote: >> kfd_process_wq_release() signals eviction fence by >> dma_fence_signal() which wanrs if dma_fence >> is NULL. > That's news to me. Looking at the dma_fence_signal implementation on > amd-staging-drm-next,

Re: [PATCH] amdkfd: wq_release signals dma_fence only when available

2024-12-11 Thread Felix Kuehling
On 2024-12-11 22:06, Zhu Lingshan wrote: > kfd_process_wq_release() signals eviction fence by > dma_fence_signal() which wanrs if dma_fence > is NULL. That's news to me. Looking at the dma_fence_signal implementation on amd-staging-drm-next, it just silently returns -EINVAL if the fence pointe