Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-16 Thread Huang Rui
> >> AUTO_CTXSW_ENABLE is not relevant to worldswitch preemption. it only > >> applies for ring buffer preemption. SDMA will do worldswitch whatever > >> AUTO_CTXSW_ENABLE is 1 or 0. > >> > >> -Original Message- > >> From: Liu, Monk > &

Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-16 Thread Christian König
; Min, Frank Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV Hi Monk, AUTO_CTXSW_ENABLE is not relevant to worldswitch preemption. it only applies for ring buffer preemption. SDMA will do worldswitch whatever AUTO_CTXSW_ENABLE is 1

Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-12 Thread Koenig, Christian
gt; > -Original Message- > From: Ma, Sigil > Sent: Wednesday, October 10, 2018 3:25 PM > To: Liu, Monk ; Koenig, Christian > ; Huang, Ray ; Min, Frank > > Cc: amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV &g

RE: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-10 Thread Liu, Monk
@lists.freedesktop.org Subject: RE: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV Hi Monk, AUTO_CTXSW_ENABLE is not relevant to worldswitch preemption. it only applies for ring buffer preemption. SDMA will do worldswitch whatever AUTO_CTXSW_ENABLE is 1 or 0. -Original Message- From

RE: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-10 Thread Ma, Sigil
, Ray ; Min, Frank ; Ma, Sigil Cc: amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV Oh, that mean I remember it reversed way, according to code looks we need to enable ctx_switch to support WORLD SWITCH for SDMA engine But better let Sigil

RE: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-09 Thread Liu, Monk
g, Ray ; Min, Frank ; Ma, Sigil Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV Hi Monk, well that doesn't make much sense to me what you say here cause context switching certainly is already enabled under SRIOV: > -   if

Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-09 Thread Koenig, Christian
for world switch , thanks ! > > /Monk > > -Original Message- > From: Christian König > Sent: Tuesday, October 9, 2018 6:57 PM > To: Huang, Ray ; Liu, Monk ; Min, Frank > > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 sta

RE: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-09 Thread Liu, Monk
18 6:57 PM To: Huang, Ray ; Liu, Monk ; Min, Frank Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV Am 09.10.2018 um 11:17 schrieb Huang Rui: > On Mon, Oct 08, 2018 at 03:35:15PM +0200, Christian König wrote: >> [SNI

Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-09 Thread Christian König
Am 09.10.2018 um 11:17 schrieb Huang Rui: On Mon, Oct 08, 2018 at 03:35:15PM +0200, Christian König wrote: [SNIP] - if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP) { - r = sdma_v4_0_load_microcode(adev); + /* start the gfx rings and rlc compute queues */ + for

Re: [PATCH 2/8] drm/amdgpu: fix sdma v4 startup under SRIOV

2018-10-09 Thread Huang Rui
On Mon, Oct 08, 2018 at 03:35:15PM +0200, Christian König wrote: > Under SRIOV we were enabling the ring buffer before it was initialized. > > Signed-off-by: Christian König > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 234 > - > 1 file changed, 116 insertion