Re: [PATCH 2/2] drm/amd/smu: unify smu ppt callback marcos

2020-06-16 Thread Wang, Kevin(Yang)
to correct it. thanks. Best Regards, Kevin From: Zhang, Hawking Sent: Tuesday, June 16, 2020 6:03 PM To: Wang, Kevin(Yang) ; amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: RE: [PATCH 2/2] drm/amd/smu: unify smu ppt callback marcos [AMD Public Use]

RE: [PATCH 2/2] drm/amd/smu: unify smu ppt callback marcos

2020-06-16 Thread Zhang, Hawking
[AMD Public Use] The naming style smu_ppt_xxx makes me confusing. at first glance, I thought you just have some dummy code or the patch is something still working in progress. It would be better to rename it to smu_ppt_funcs. Regards, Hawking -Original Message- From: Wang, Kevin(Ya