[AMD Public Use]
Good suggestion, will refine the name.
Brs
Wenhui
-Original Message-
From: Zhang, Hawking
Sent: Monday, July 13, 2020 1:55 PM
To: Sheng, Wenhui ; amd-gfx@lists.freedesktop.org
Cc: Gao, Likun
Subject: RE: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 reset
[AMD
2_SOC15, is it correct?
Brs
Wenhui
-Original Message-
From: Zhang, Hawking
Sent: Monday, July 13, 2020 1:44 PM
To: Sheng, Wenhui ; Li, Dennis ;
amd-gfx@lists.freedesktop.org
Cc: Gao, Likun
Subject: RE: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 reset
[AMD Public Use]
RE - [Dennis Li]
: Gao, Likun
Subject: RE: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 reset
[AMD Public Use]
RE - [Dennis Li] It is better change to use RREG32_SOC15_NO_KIQ, because when
GPU hang, RREG32_SOC15 will fail if it use RREG32_KIQ to read register
RREG32_SOC15_NO_KIQ should have no difference from
[AMD Public Use]
V2 looks good to me except for the following nitpicks
+#define SMU11_MODE1_RESET_WAIT_TIME 500 //500ms
It would be better explicitly call ms units out in the macro name, say
SMU11_MODE1_RESET_WAIT_TIMEOUT_IN_MS.
Regards,
Hawking
-Original Message-
From: Sheng, Wenhui
@lists.freedesktop.org
Cc: Gao, Likun ; Zhang, Hawking
Subject: RE: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 reset
[AMD Official Use Only - Internal Distribution Only]
Ok, will refine it.
Brs
Wenhui
-Original Message-
From: Li, Dennis
Sent: Monday, July 13, 2020 11:10 AM
To: Sheng
, Wenhui ;
Zhang, Hawking
Subject: RE: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 reset
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Wenhui Sheng
Sent: Friday, July 10, 2020 10:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun
] drm/amd/powerplay: add SMU mode1 reset
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Wenhui Sheng
Sent: Friday, July 10, 2020 10:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wenhui ;
Zhang, Hawking
Subject: [PATCH 1
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Wenhui Sheng
Sent: Friday, July 10, 2020 10:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wenhui ;
Zhang, Hawking
Subject: [PATCH 1/3] drm/amd/powerplay: add SMU mode1 re
[AMD Official Use Only - Internal Distribution Only]
-Original Message-
From: amd-gfx On Behalf Of Wenhui Sheng
Sent: Friday, July 10, 2020 10:17 PM
To: amd-gfx@lists.freedesktop.org
Cc: Gao, Likun ; Sheng, Wenhui ;
Zhang, Hawking
Subject: [PATCH 1/3] drm/amd/powerplay: add SMU mode1
