Re: [PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-07 Thread Christian König
I think you mean loading KMS multiple times by “reuse”. No, as far as I know the fb emulation can be initialized multiple times without driver reload. I can’t see a case that fb_probe is invoked out of loading KMS, is there? I'm not so deeply into this, but I knew that you can certainly unbind

Re: [PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-06 Thread Ding, Pixel
Hi Christian, I think you mean loading KMS multiple times by “reuse”. At every time loading KMS, guest driver tells the host to clear FB during early init. I can’t see a case that fb_probe is invoked out of loading KMS, is there? Anyway I understand we don’t want to have many SRIOV conditional

Re: [PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-06 Thread Ding, Pixel
Thank you for the clarification, I get it. — Sincerely Yours, Pixel On 06/02/2017, 5:17 PM, "Koenig, Christian" wrote: >Hi Pixel, > >you don't seem to understand the reason for the clear here. > >It is completely irrelevant that the host is clearing the memory for the >guest, the proble

Re: [PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-06 Thread Ding, Pixel
Hi Christian, The underlying host driver clears VF’s framebuffer when guest driver shake hands with it, that is done before guest driver init. I think it’s unnecessary to clear FB again even with GPU for VF. — Sincerely Yours, Pixel On 06/02/2017, 4:49 PM, "Koenig, Christian" wrote: >Am

Re: [PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-06 Thread Christian König
Hi Pixel, you don't seem to understand the reason for the clear here. It is completely irrelevant that the host is clearing the memory for the guest, the problem is that the guest reuse the memory it got assigned from the host multiple times. IIRC we added this because you could see leftover

Re: [PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-06 Thread Christian König
Am 06.02.2017 um 07:24 schrieb Pixel Ding: The SRIOV host driver cleans framebuffer for each VF, guest driver needn't this action which costs much time on some virtualization platform, otherwise it might get timeout to initialize. Signed-off-by: Pixel Ding --- drivers/gpu/drm/amd/amdgpu/amdgp

RE: [PATCH 1/2] drm/amdgpu: don't clean the framebuffer for VF

2017-02-05 Thread Yu, Xiangliang
Acked-by: Xiangliang.Yu Thanks! Xiangliang Yu > -Original Message- > From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf > Of Pixel Ding > Sent: Monday, February 06, 2017 2:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Ding, Pixel ; ding.pi...@amd.com > Subject: [P